Introduce validators for the outputs of the responders in user-responders.js and for all inner types. Values for tests are generated by printing the example output values of the responders.
Depends on D7571
Details
Details
- Reviewers
kamil inka tomek - Commits
- rCOMM3ecd8be5cefd: [lib] Introduce user responder validators
Run yarn jest
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Haven't compared validators with the types as it is more time consuming here than in other diffs, where the Flow types were next to tComb ones. If you could make comments with the Flow types, I would take another look.
| keyserver/src/responders/responder-validators.test.js | ||
|---|---|---|
| 9–10 ↗ | (On Diff #25550) | Test names can be made a little useful when they are more readable. Usually, we should aim at making them being read as sentences, especially it. In this case we can have e.g. describe('user responders', () => {
describe('validators', () => {
it('should validate logout response', () => {Notice that it('should validate logout response', is almost like a sentence. We can also leave it as it is, as the improvement isn't that big and this change will take time. |
| 151 ↗ | (On Diff #25550) | Can we make all the lines at most 80 chars wide? |
Comment Actions
Fixed test naming and long lines. Added flow types in the inline comments.
| keyserver/src/responders/user-responders.js | ||
|---|---|---|
| 209–213 ↗ | (On Diff #25550) | export type LogOutResponse = {
+currentUserInfo: LoggedOutUserInfo,
}; |
| 243–256 ↗ | (On Diff #25550) | export type RegisterResponse = {
id: string,
rawMessageInfos: $ReadOnlyArray<RawMessageInfo>,
currentUserInfo: OldLoggedInUserInfo | LoggedInUserInfo,
cookieChange: {
threadInfos: { +[id: string]: RawThreadInfo },
userInfos: $ReadOnlyArray<UserInfo>,
},
}; |
| 404–421 ↗ | (On Diff #25550) | export type LogInResponse = {
+currentUserInfo: LoggedInUserInfo | OldLoggedInUserInfo,
+rawMessageInfos: $ReadOnlyArray<RawMessageInfo>,
+truncationStatuses: MessageTruncationStatuses,
+userInfos: $ReadOnlyArray<UserInfo>,
+rawEntryInfos?: ?$ReadOnlyArray<RawEntryInfo>,
+serverTime: number,
+cookieChange: {
+threadInfos: { +[id: string]: RawThreadInfo },
+userInfos: $ReadOnlyArray<UserInfo>,
},
+notAcknowledgedPolicies?: $ReadOnlyArray<PolicyType>,
}; |
Comment Actions
Add subscriptionUpdateResponseValidator because I missed it, and move logOutResponseValidator higher because it will be used earlier (must be declared before it can be used).