Page MenuHomePhabricator
Differential D10606

[lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`
ClosedPublic
Actions

Authored by atul on Jan 11 2024, 8:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 7:19 AM
Unknown Object (File)
Sat, Nov 23, 12:56 AM
Unknown Object (File)
Wed, Nov 6, 12:53 PM
Unknown Object (File)
Tue, Nov 5, 8:35 AM
Unknown Object (File)
Wed, Oct 30, 1:40 PM
Unknown Object (File)
Wed, Oct 30, 1:06 PM
Unknown Object (File)
Oct 14 2024, 6:28 PM
Unknown Object (File)
Oct 14 2024, 6:28 PM
View All 61 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMMc6999dbbc0a7: [lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`
Summary

Followup to D10588. This is the first step in removing the invariant inside the

action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === registerActionTypes.success ||
action.type === fullStateSyncActionType

condition.

Depends on D10588

Test Plan

N/A, trusting flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 11 2024, 8:54 AM
atul added a child revision: D10608: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`.Jan 11 2024, 9:03 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2024, 9:10 AM
Harbormaster failed remote builds in B25700: Diff 35540!
atul mentioned this in D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.Jan 11 2024, 9:19 AM
atul updated this revision to Diff 35550.Jan 11 2024, 9:37 AM

separate out ClientLogInResponse and ServerLogInResponse to address flow issue in keyserver (not sure why it didn't get caught pre-commit)

atul published this revision for review.Jan 11 2024, 9:44 AM
ashoat accepted this revision.Jan 11 2024, 9:49 AM
ashoat added inline comments.
lib/types/account-types.js
158–161

We should make sure cookieChange is read-only

Note: the + shorthand will not work here because of the type spread operator

This revision is now accepted and ready to land.Jan 11 2024, 9:49 AM
Harbormaster completed remote builds in B25709: Diff 35550.Jan 11 2024, 10:03 AM
atul updated this revision to Diff 35588.Jan 14 2024, 3:09 PM

make cookieChange readonly

Harbormaster completed remote builds in B25739: Diff 35588.Jan 14 2024, 3:29 PM
Closed by commit rCOMMc6999dbbc0a7: [lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos` (authored by atul). · Explain WhyJan 14 2024, 4:11 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc6999dbbc0a7: [lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`.
atul mentioned this in rCOMM5da040f1a485: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.Jan 22 2024, 11:49 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
18 lines
updaters/
4 lines
lib/
actions/
30 lines
types/
17 lines

Diff 35550

View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

keyserver/src/updaters/account-updaters.js

Loading...
View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/account-types.js

Loading...