[lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`
ClosedPublic
Actions

Authored by atul on Jan 11 2024, 8:54 AM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMc6999dbbc0a7: [lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`

Summary

Followup to D10588. This is the first step in removing the invariant inside the

action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === registerActionTypes.success ||
action.type === fullStateSyncActionType

condition.

Depends on D10588

Test Plan

N/A, trusting flow

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D10606 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 11 2024, 8:54 AM

atul added a child revision: D10608: [lib] Narrow `Register[Response/Result]` to `MinimallyEncodedRawThreadInfos`.Jan 11 2024, 9:03 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2024, 9:10 AM

Harbormaster failed remote builds in B25700: Diff 35540!

atul mentioned this in D10609: [lib] Narrow `ClientFullStateSync` to `MinimallyEncodedRawThreadInfos`.Jan 11 2024, 9:19 AM

separate out ClientLogInResponse and ServerLogInResponse to address flow issue in keyserver (not sure why it didn't get caught pre-commit)

atul published this revision for review.Jan 11 2024, 9:44 AM

ashoat accepted this revision.Jan 11 2024, 9:49 AM

ashoat added inline comments.

lib/types/account-types.js
158–161 ↗	(On Diff #35550)	We should make sure `cookieChange` is read-only Note: the `+` shorthand will not work here because of the type spread operator