Use [[ ]] instead of [ ]

Of course, that makes sense.

Accepting, because the scope of this diff is to remove references to create-db.js. But in the process of reviewing, saw some minor minor wording changes that could be made. Up to you and rest of reviewers.

Nice, thanks for addressing my inline feedback in D4364. This change looks good and addresses the potential bug.

Address feedback. No longer uses position: absolute and actually addresses the cause of the bug instead of repositioning other elements.

Abandoning this, per @ashoat on this Linear task:

We can just delete backup-phabricator.sh… we're using Amazon RDS for the Phabricator database now, which guarantees data integrity out-of-the-box. If we ever find a need for backup-phabricator.sh again we can always just bring it back

No, it shouldn't. I'm not sure why double quotes would mess it up, was there a reason you thought it could?

If the file in the inline comment cannot be seen.

Why have we decided to use lossy here and lossless in the previous diff?

I think there should be a newline at the end of this file. Every other package.json in the codebase ends with a newline, and it is the POSIX standard for lines.

Dang, I thought I could do more code review but I'm the placeholder guy they put on diffs to ignore! 😂😂 carry on 😑

Nice! Some minor inline feedback, but looks good to me.

However, recent versions of Safari display favicons for tabs across the board (it's no longer even possible to disable them), and including safari-pinned-tab.svg is no longer necessary... but Safari will still use it if it's provided. Based on what I've read, it seems like the only reason to specify safari-pinned-tab.svg is if you want something other than the default favicon to be displayed on just Safari. I don't think that's something we care about.

That's correct!

I agree. Having some sort of git issue, so abandoning this revision, but the new revision with the renamed font-stack is here: D4356.

Are you suggesting that we should include the names of non-primitive types in variable names?

FYI, I can't see the images in this inline comment. I ran into a similar issue when reviewing another diff, so maybe this is an issue where images don't show up on inline comments.

The sidebar title should flow the same as normal titles. I'm glad you added an ellipsis here, but the title still seems to be limited to half of the width of the containing component

Yup, this makes sense to me. I think the difference in border size was overlooked in D3057, but nice catch!

Looks even better now!

The fact that this function requires the input to be sorted is critical and should be made exceedingly explicit at the callsite, so the verbosity is worth it.

Good catch!

Agree with this. threadIsWatched-type boolean names feel like they imply a value of true, since it sounds like "The thread is watched" versus "Is the thread watched?"

I'm okay with this revision as it improves code comprehension, but neither threadsToMessageIDsFromMessageInfos nor mapThreadsToMessageIDsFromOrderedMessageInfos are readable. That is, once read, it makes sense, but names shouldn't need to be that long to begin with.

Yup, that is confusing. Luckily, just did a quick check throughout the codebase and there are no calls to trimText with a maxLength argument of less than 30. So for now, this should be fine.

Looks good! Appreciate the explanation for erring on the side of redundancy for unit tests, I wholeheartedly agree with that. With that in mind, these tests look good!

Oh, okay my bad! I only made those suggestions since if this is part of the CI build we want it to run as fast as possible so we should eliminate redundant tests.

Tests look good but there's some redundancy that can be removed.

You're right, I should have been more thoughtful. Just updated the Test Plan.

Looks good to me. Nice catch!