Looks good, let's remove the pull_request trigger though
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jan 3 2023
Jan 3 2023
atul published D6150: [GH Actions] Remove `pull_request` trigger for Android/iOS workflows for review.
rebase before landing
Jan 2 2023
Jan 2 2023
Jan 1 2023
Jan 1 2023
atul retitled D6135: [keyserver] Increase `social_proof` column of `cookies` table from `varchar(255)` to `varchar(4096)` from [keyserver] Increase `social_proof` column of `cookies` table from `varchar(255)` to `varchar(1024)`
atul updated the diff for D6135: [keyserver] Increase `social_proof` column of `cookies` table from `varchar(255)` to `varchar(4096)`.
1024->4096
atul updated the diff for D6134: [keyserver] Store `primaryIdentityPublicKey` in `public_key` column of `cookies` table.
fix
Dec 31 2022
Dec 31 2022
atul updated the diff for D6133: [keyserver] Pull `primaryIdentityPublicKey` out of SIWE statement and pass to `siweAccountCreationRequest`.
resolve flow issue
atul updated the diff for D6126: [keyserver] Include `siwePrimaryIdentityPublicKey` in `landingResponder` response.
rebase before landing
rebase before landing
atul updated the diff for D6124: [native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE`.
anonymous -> PLACEHOLDER
atul added inline comments to D6124: [native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE`.
atul updated the summary of D6124: [native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE`.
atul published D6124: [native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE` for review.
Dec 30 2022
Dec 30 2022
atul published D6115: [native] Modify `getUserPublicKey()` JSI function to return `ClientPublicKeys` for review.
atul added a reverting change for rCOMM81108a361ec2: Temporary changes for staff release: rCOMM6c717dd0c384: Revert "Temporary changes for staff release".
Very limited experience with webpack, but the changes make sense + look reasonable.
Little hesitant about this approach where the key is hardcoded in (even if obfuscated)... but if it's solely for rate limiting and doesn't grant any additional permissions or anything I guess it's fine
atul updated the test plan for D6109: [keyserver] Block usernames that could be valid ethereum addresses from being registered.
Dec 29 2022
Dec 29 2022
atul updated the diff for D6086: [lib] Add `siweAuthActionTypes.success` check everywhere there's a `logInActionTypes.success` check.
rebase before landing
atul added a comment to D6086: [lib] Add `siweAuthActionTypes.success` check everywhere there's a `logInActionTypes.success` check.
In D6086#182693, @tomek wrote:Sounds reasonable. But now I'm wondering if introducing new action was a good idea. Maybe dispatching the old action (possibly with a new field e.g. type) might be easier? I don't think we should change it now, though.
atul added inline comments to D6085: [lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult`.
atul updated the diff for D6085: [lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult`.
address feedback from @tomek
atul updated the diff for D6085: [lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult`.
rebase before landing
atul updated the diff for D6077: [keyserver] Introduce `createSIWEAccount` and use in `siweAuthResponder`.
rebase before landing
Resigning to unblock since accepted by @tomek.
Resigning to unblock, but I think master is working for now
I think this was resolved with https://github.com/CommE2E/comm/commit/e0cc8c5343edbcf933e5dcb0e96c4dadaa338d04? (kept landing and reverting that commit last night until it worked... the first attempts didn't)
Looks good, one question inline
Resigning to unblock since this was approved by @ashoat.
atul resigned from D6054: [lib/native] move useCanCreateReactionFromMessage hook from native to lib.
Resigning to unblock since this was reviewed by @tomek.
atul resigned from D6005: [lib/keyserver/native] move all the reaction message types into its own file.
Resigning to unblock since this was reviewed by @tomek.
atul updated the diff for D6077: [keyserver] Introduce `createSIWEAccount` and use in `siweAuthResponder`.
rebase around D6078
prepend sudo
Still failed, suspect it may be a permissions issue. Going to try one more time prefixing sudo and then will reevaluate (probably makes sense to iterate on a forked repo instead of reverting/reopening again and again)
atul resigned from D6004: [lib/keyserver] add check to make sure users cannot send reactions from the source message of a sidebar.
Removing myself to unblock since @ashoat accepted.
atul updated the diff for D6078: [keyserver] Pass `calendarQuery` to `processSuccessfulLogin` in `siweAuthResponder`.
rebase around D6077 before landing
fix path
It should be /native/android/scripts not /scripts