Add failing test case
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jun 7 2023
Jun 7 2023
ashoat requested review of D8146: [lib] Use RegExp.source instead of RegExp.toString() in emojis.js.
I think we need some way to authenticate this request. We can't use the access token until keyservers are able to register with the identity service, which is still several weeks away. In yesterday's 1:1, you and I had talked about using a signed message for this, similar to how RegisterReservedPasswordUserStart works. To make that work we'd have to change the .proto here, though. What do you think?
ashoat requested changes to D8126: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.
Jun 6 2023
Jun 6 2023
ashoat added inline comments to D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
ashoat added a comment to D8068: [native] Refactor the members list to support any variety of role labels.
(should we "singularize" "Members" and "Admins" so it appears as "Member" and "Admin"?)
ashoat added a comment to D8070: Implement CommConstants HostObject with `NATIVE_MESSAGE_TYPES` property in C++.
This is cool – our first HostObject!
ashoat accepted D8072: [lib] Remove parent admin from members list if they are not part of the thread.
Okay, cool. I'm a bit worried that in the future we might introduce an "admin" role for a channel in a community, and in that scenario this code would break ThreadSettingsLeaveThread's usage of otherUsersButNoOtherAdmins. But I guess we can address that when we get there...
ashoat added inline comments to D7943: [landing] introduce logo svg assets for competitor comparison.
ashoat requested review of D8110: [native] Dispatch SET_DATA_LOADED action after registration completes.
Ping on this review
Jun 5 2023
Jun 5 2023
@inka heads-up, your upload doesn't appear to have attached
ashoat added inline comments to D8052: [Keyserver] Use olm identity key for tunnelbroker connection.
ashoat added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
Jun 4 2023
Jun 4 2023
ashoat requested review of D8084: [native] Disable PasswordSelection "next" button when passwords are empty.
ashoat requested review of D8085: [native] Change AvatarSelection button to say "Submit" instead of "Next".
Jun 2 2023
Jun 2 2023
ashoat requested changes to D8072: [lib] Remove parent admin from members list if they are not part of the thread.
This diff makes sense, but from a code search it looks like it might impact ThreadSettingsLeaveThread and its use of otherUsersButNoOtherAdmins.
ashoat added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
Jun 1 2023
Jun 1 2023
In D8056#239034, @atul wrote:I can try to pull something generic out of CommunityCreationMembers and see if it can be used in other components where we have TagInput and UserList (ComposeSubchannel, AddUsersModal, etc) later in this stack.
Back to you with questions:
Tablet / mobile screenshots have buttons with text that doesn't appear vertically centered. Can we look into that and ideally resolve it before landing?
Makes sense to me, but would be great to get @kuba to take a look and test it to make sure it doesn't break the edit message use case focus-trap was introduced to handle!
Just some nits, not a full review. This one is pretty complicated, so would appreciate a detailed review by one of the listed reviewers!
Ah – makes sense, thanks for explaining @inka!
Curious for your thoughts on the inline comments. I think it might be good to move await getDeviceID out so it's not called on every Websocket initialization