Not a fan of ReportInput::time handling with serde, but I don't think we can do much better...
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 28 2023
Aug 25 2023
Could we generalise this so it can also DeleteRequest?
Rebase, update lockfiles
Regenerate backup lockfile because of issues with resolving deps. Also updated lockfile of feature flags from anyhow in lib.
Add logging on auth errors
Rebase
Aug 23 2023
Respond to review
Update http port to the previous gRPC port, similar to the planned blob service changes
Thank you for all links for the invariants!
Aug 22 2023
LGTM, depending on how it is used / if there are going to be non-const-creatable fields in the config in the future, we could consider adding a const default:
impl ExponentialBackoffConfig { const DEFAULT: Self = Self { max_attempts: 8, base_duration: std::time::Duration::from_millis(25), retry_on_provisioned_capacity_exceeded: true, }; } impl Default for ExponentialBackoffConfig { fn default() -> Self { Self::DEFAULT } }
so e.g. a service can just create a global const instead of passing the config in some other way.
Add qrCode
Revert the blob client port change
Cool, changed approach to just ignoring the examples
LGTM on the rust side
Aug 21 2023
Rebase
Rebase
Rebase
Removed await. I think I just experimented with a few different solutions and this got left behind.
Rebase
Fix
Remove unrelated changes
I agree with @jon, this was slightly confusing to me at the beginning when I started working on the services.
Aug 18 2023
Aug 17 2023
Aug 16 2023
Accepting although I wonder how hard it would be to put this into the keyserverStore (during backup creation we want to save all keyserver-related information and now instead of having it all in one places it's split between two fields in redux)
Aug 11 2023
Potential ideas: (both of them are kinda iffy so up to you!)
- Merge datetime and timestamp parsing logic and use the attribute type (String/Number) to differentiate between the two
- We could do something like this for numbers (the dummy trait is required so there are conflicting implementations for FromStr types)
This will be very useful! I would prefer to have multiple packages in comm-services-lib/ (comm-services-lib/database-utils/, comm-services-lib/blob-client), but I don't really have strong argument against using features for this.
Aug 7 2023
Aug 4 2023
Fixed the readonly types. Amended the test plan for versions with and without conversion, and for rescinds where the notification was send to an older version/ from the older version of the keyserver.
Added util functions for encoding the version key. Amended the test plan.
Aug 3 2023
Changed approach, more explanation in the updated description. Also updated the test plan.
Aug 2 2023
Aug 1 2023
Rebase
Checked the showCopyLink. showLearnSpelling is enabled by default but spellcheck in browser window is off by default so it doesn't show up.
Added showSaveImageAs and showSaveVideoAs.