rebase and land
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Sep 17 2023
Sep 17 2023
rebase and land
Sep 15 2023
Sep 15 2023
atul updated subscribers of D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
In D9215#271132, @rohan wrote:Accepting since it seems reasonable to me, but not super familiar with why we introduced it here in the first place so letting others take a look
In D9214#271139, @rohan wrote:If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?
atul requested review of D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
Sep 14 2023
Sep 14 2023
atul published D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch` for review.
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
some memoization
atul published D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch` for review.
atul requested changes to D9095: [native] Block editing messages on search and pinned messages screens, and of the first message in a thread.
Requesting changes for feedback above
Fact that we have unit test coverage here makes this super easy to accept
Generally looks good, would be good for @kamil to take a final pass. Only thing that I'd change before landing is early returning in handleSensitiveData.
Thanks for cleaning this up
Seems reasonable. In the future it might be helpful to provide link to corresponding GitHub repo in description.
Sep 13 2023
Sep 13 2023
atul updated the diff for D9190: [native] Replace `componentDidUpdate` with `useEffect`s in `ConnectedChatThreadList`.
address @ashoat's feedback
address @ginsu's feedback
Awesome
atul updated the diff for D9189: [native] Lift `component[DidMount/WillUnmount]` lifecycle methods to `useEffect` in `ConnectedChatThreadList`.
address @ashoat's feedback: split into three separate useEffects
rebase and land
atul retitled D9189: [native] Lift `component[DidMount/WillUnmount]` lifecycle methods to `useEffect` in `ConnectedChatThreadList` from [native] Lift `component[DidMount/WillUnmount]` lifestyle methods to `useEffect` in `ConnectedChatThreadList`
Is this config auto generated by nix somehow? Should mariadb-up-mac.nix be updated as well?
resolve merge conflicts
resolve merge conflicts and rebase
atul added inline comments to D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.
atul updated the diff for D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.
address @ginsu's feedback
atul added inline comments to D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.
atul updated the diff for D9164: [native] Lift `onSwipeableWillOpen` and `composeThread` to `ConnectedChatThreadList`.
rebase and land
atul updated the summary of D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.
Another example w/ doubleTapUpdate:
https://chat.openai.com/share/285de214-0e3f-4753-96b5-d7870e7c0c11
EG
In D9166#269944, @ashoat wrote:I agree that it would be good to migrate away from the Reanimated 1 API... given it's deprecated in Reanimated 3, we'll eventually need to migrate there anyways. Looking at animateTowards though, it seems fairly complicated... I don't think it makes sense to block @atul's work here on transforming that to the new Reanimated API. We'll probably need to have the Reanimated conversion be a monthly goal for someone...
atul added inline comments to D9164: [native] Lift `onSwipeableWillOpen` and `composeThread` to `ConnectedChatThreadList`.
atul added inline comments to D9134: [native] Lift `searchUsers` and `onChangeSearchText` to `ConnectedChatThreadList`.
atul published D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList` for review.
Sep 12 2023
Sep 12 2023
atul updated the diff for D9171: [native] Lift `onPressItem` and `onPressSeeMoreSidebars` to `ConnectedChatThreadList`.
stage all