land

rebase and resolve merge conflicts

Looks good, including suggestion from ChatGPT with simpler syntax inline that you can choose to adopt/ignore depending on what you prefer

land

land

fix import

fix query

update

Updated return type of fetchRoles(...) to Promise<ServerLegacyRoleInfo[]>.

update

fix name

In D10967#316438, @ashoat wrote:

Can you wait on ENG-6685 being resolved before landing? I think it should be simple... can take a look in the next hour

I modified this diff before landing to only modify RoleInfo (formerly MinimallyEncodedRoleInfo) since I figured we could ignore LegacyRoleInfo going forward...

update before landing

Seems reasonable, but I don't have a ton of context. Adding @ashoat as blocking since he's reviewing D10956 as well.

Thanks for fixing that capitalization issue

Looks like straightforward rename

Actually, requesting changes. I think we can avoid using setState in useEffect

Thanks for addressing feedback!

Didn't read too carefully, but looks like straightforward refactor.

Didn't read too carefully, but looks like straightforward move.

Makes sense, but can't we ensure that the members are sorted by the time we "get here"?

I would guess that a function named useMembersGroupedByRole would return something like Map<string, $ReadOnlyArray<RelativeMemberInfo>>

The implementation of MemberListSidebarProvider looks correct and makes sense for now.

Thanks for addressing feedback, could we use if statement instead of invariant where I annotated?

Thanks @kamil for clarifying those details. I think it's reasonable to abandon this diff and mark migration task as canceled.

rebase and land