Page MenuHomePhabricator
Feed All Stories

Apr 2 2024

michal requested changes to D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.
Apr 2 2024, 2:31 AM
michal accepted D11448: [native] update `decrypt` method use `EncryptedData`.
Apr 2 2024, 2:31 AM
tomek accepted D11499: [lib] Factor out innerPerformAuth for use in keyserver session recovery.
Apr 2 2024, 2:29 AM
michal accepted D11446: [native] update `encrypt` method to return `EncryptedData`.
Apr 2 2024, 2:26 AM
marcin accepted D11445: [web] update `encrypt` method to return `EncryptedData`.
Apr 2 2024, 2:15 AM
tomek accepted D11498: [lib] Expose callKeyserverEndpoint in CallKeyserverEndpointContext.
Apr 2 2024, 2:15 AM
tomek accepted D11497: [lib] Don't invalidate a session if the recovery is cancelled.
Apr 2 2024, 2:10 AM
kamil accepted D11467: [commtest] Add helpers for ED25519 signing messages.
Apr 2 2024, 1:38 AM
kamil accepted D11511: [sqlite] implement processing aux user store ops on worker.
Apr 2 2024, 1:35 AM
kamil accepted D11422: [lib/native/web] introduce synced metadata reducer.
Apr 2 2024, 1:34 AM
kamil accepted D11415: [lib] introduce SyncedMetadata store spec.
Apr 2 2024, 1:30 AM

Apr 1 2024

varun accepted D11469: [native] Add LogInExistingDevice to native_rust_library.
Apr 1 2024, 9:42 PM
varun accepted D11470: [native] Add JSI bindings for LogInExistingDevice RPC.
Apr 1 2024, 9:35 PM
varun accepted D11466: [identity] Implement LogInExistingDevice RPC.
Apr 1 2024, 9:28 PM
will accepted D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.
Apr 1 2024, 9:14 PM
Harbormaster failed remote builds in B27900: Diff 38644 for D11480: [native] Turn migration 64 into noop!
Apr 1 2024, 8:54 PM
atul updated the diff for D11480: [native] Turn migration 64 into noop.

add explanation

Apr 1 2024, 8:51 PM
varun accepted D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.
Apr 1 2024, 8:42 PM
varun accepted D11495: [lib][native] Pass FID from useRegistrationServerCall to identity service during registration.
Apr 1 2024, 8:32 PM
atul accepted D11510: [sqlite] Implement C++ for native to get all aux user infos.
Apr 1 2024, 8:28 PM
atul accepted D11515: [keyserver] expose getFarcasterUsers client method to JS on keyserver.
Apr 1 2024, 8:21 PM
ashoat closed D11496: [lib] Fix keyserver sending updated RoleInfos to old clients.
Apr 1 2024, 5:55 PM
ashoat committed rCOMMfe3428384c93: [lib] Fix keyserver sending updated RoleInfos to old clients (authored by ashoat).
[lib] Fix keyserver sending updated RoleInfos to old clients
Apr 1 2024, 5:55 PM
ashoat closed D11494: [lib][native] Update useRegistrationServerCall to set FID in FIDContext.
Apr 1 2024, 5:55 PM
ashoat committed rCOMM631f31484198: [lib][native] Update useRegistrationServerCall to set FID in FIDContext (authored by ashoat).
[lib][native] Update useRegistrationServerCall to set FID in FIDContext
Apr 1 2024, 5:55 PM
varun requested review of D11515: [keyserver] expose getFarcasterUsers client method to JS on keyserver.
Apr 1 2024, 3:15 PM
atul accepted D11509: [sqlite] implement C++ aux user store ops.

Did not read through createOperations super carefully, so please double check that everything seems correct there.

Apr 1 2024, 1:53 PM
atul accepted D11508: [sqlite] introduce aux user store C++ methods.

This looks correct, but would be great to have more thorough Test Plan. The aux-user-queries.tests are great though!

Apr 1 2024, 1:44 PM
atul accepted D11507: [sqlite] add aux users table for aux user store data.

Actually will accept, but please go through create_schema flow. Should be as easy as installing on new Simulator target

Apr 1 2024, 1:40 PM
atul requested changes to D11507: [sqlite] add aux users table for aux user store data.

Can we update the test plan to include the create_schema scenario as well.

Apr 1 2024, 1:37 PM
atul accepted D11506: [lib] introduce the aux user store ops.
Apr 1 2024, 1:33 PM
atul accepted D11505: [lib] introduce aux user types.
Apr 1 2024, 1:17 PM
atul accepted D11422: [lib/native/web] introduce synced metadata reducer.
Apr 1 2024, 1:15 PM
atul accepted D11512: [native] build out UI for farcaster account settings screen.
Apr 1 2024, 1:12 PM
atul accepted D11415: [lib] introduce SyncedMetadata store spec.
Apr 1 2024, 12:58 PM
varun requested review of D11514: [native] fix regression in error handling.
Apr 1 2024, 12:56 PM
atul accepted D11513: [native] unauth from farcaster.
Apr 1 2024, 12:53 PM
ginsu requested review of D11512: [native] build out UI for farcaster account settings screen.
Apr 1 2024, 12:52 PM
atul accepted D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Looks fine outside of copy being signed off on

Apr 1 2024, 12:51 PM
ginsu requested review of D11513: [native] unauth from farcaster.
Apr 1 2024, 12:47 PM
atul accepted D11483: [native] introduce farcaster account settings profile row.
Apr 1 2024, 12:46 PM
atul accepted D11496: [lib] Fix keyserver sending updated RoleInfos to old clients.

Thanks for catching and resolving this.

Apr 1 2024, 12:43 PM
ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.
Apr 1 2024, 12:28 PM
ginsu updated the diff for D11483: [native] introduce farcaster account settings profile row.

fix eslint ci issue

Apr 1 2024, 12:27 PM
ginsu requested review of D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Making @ashoat blocking reviewer since this diff does have copy changes

Apr 1 2024, 12:10 PM
ginsu attached a referenced file: F1452474: IMG_6793.PNG.
Apr 1 2024, 12:09 PM
ginsu attached a referenced file: F1452475: IMG_6792.PNG.
Apr 1 2024, 12:09 PM
ginsu attached a referenced file: F1452477: RPReplay_Final1711998516.MP4.
Apr 1 2024, 12:09 PM
Harbormaster failed remote builds in B27892: Diff 38634 for D11483: [native] introduce farcaster account settings profile row!
Apr 1 2024, 12:09 PM
ginsu updated the summary of D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Apr 1 2024, 12:09 PM
ginsu added a comment to D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Will this affect the experience when FarcasterPrompt is used from the registration flow?

Apr 1 2024, 12:01 PM
ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.
Apr 1 2024, 11:58 AM
ginsu updated the diff for D11483: [native] introduce farcaster account settings profile row.

update farcaster account gate logic

Apr 1 2024, 11:57 AM
ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.
Apr 1 2024, 11:56 AM
ginsu accepted D11494: [lib][native] Update useRegistrationServerCall to set FID in FIDContext.
Apr 1 2024, 11:38 AM
ashoat closed D11492: [lib] Add Coinbase Wallet support.
Apr 1 2024, 10:15 AM
ashoat committed rCOMM1005cb0dac2a: [lib] Add Coinbase Wallet support (authored by ashoat).
[lib] Add Coinbase Wallet support
Apr 1 2024, 10:15 AM
ashoat closed D11491: [native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates.
Apr 1 2024, 10:15 AM
ashoat closed D11490: [lib][web][landing] Don't include injectedWallet in mobile experience.
Apr 1 2024, 10:15 AM
ashoat committed rCOMMdb17bccf5316: [lib][web][landing] Don't include injectedWallet in mobile experience (authored by ashoat).
[lib][web][landing] Don't include injectedWallet in mobile experience
Apr 1 2024, 10:15 AM
ashoat committed rCOMM2c2854e1b25a: [native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates (authored by ashoat).
[native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates
Apr 1 2024, 10:15 AM
ashoat closed D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.
Apr 1 2024, 10:15 AM
ashoat closed D11493: [buildkite] Update image used in Buildkite JS workflows to Node 20.
Apr 1 2024, 10:15 AM
ashoat committed rCOMM57ece87920b0: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem (authored by ashoat).
[lib][landing][web] Update Rainbowkit, Wagmi, and Viem
Apr 1 2024, 10:15 AM
ashoat committed rCOMM6f0998ca2e86: [buildkite] Update image used in Buildkite JS workflows to Node 20 (authored by ashoat).
[buildkite] Update image used in Buildkite JS workflows to Node 20
Apr 1 2024, 10:15 AM
ashoat closed D11488: [native] Allow us to open a bunch of other wallets.
Apr 1 2024, 10:15 AM
ashoat committed rCOMMe424a719919b: [native] Allow us to open a bunch of other wallets (authored by ashoat).
[native] Allow us to open a bunch of other wallets
Apr 1 2024, 10:15 AM
ashoat closed D11486: [lib] Switch to Sepolia for ENSCache unit tests.
Apr 1 2024, 10:10 AM
ashoat committed rCOMM856a13b2cca4: [lib] Switch to Sepolia for ENSCache unit tests (authored by ashoat).
[lib] Switch to Sepolia for ENSCache unit tests
Apr 1 2024, 10:10 AM
ashoat closed D11487: [lib] Allow getNamesForAddresses to be called without ReverseRecords smart contract.
Apr 1 2024, 10:10 AM
ashoat committed rCOMM585f50d2cc96: [lib] Allow getNamesForAddresses to be called without ReverseRecords smart… (authored by ashoat).
[lib] Allow getNamesForAddresses to be called without ReverseRecords smart…
Apr 1 2024, 10:10 AM
ashoat closed D11485: [lib][native][web][keyserver][landing] Update to Ethers.js 6.
Apr 1 2024, 10:09 AM
ashoat committed rCOMMd543b135adef: [lib][native][web][keyserver][landing] Update to Ethers.js 6 (authored by ashoat).
[lib][native][web][keyserver][landing] Update to Ethers.js 6
Apr 1 2024, 10:09 AM
ginsu accepted D11492: [lib] Add Coinbase Wallet support.
Apr 1 2024, 9:28 AM
ginsu accepted D11491: [native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates.
Apr 1 2024, 9:26 AM
ginsu accepted D11490: [lib][web][landing] Don't include injectedWallet in mobile experience.
Apr 1 2024, 9:25 AM
ginsu accepted D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.
Apr 1 2024, 9:24 AM
ginsu accepted D11493: [buildkite] Update image used in Buildkite JS workflows to Node 20.
Apr 1 2024, 9:19 AM
ginsu accepted D11488: [native] Allow us to open a bunch of other wallets.
Apr 1 2024, 9:18 AM
ginsu accepted D11487: [lib] Allow getNamesForAddresses to be called without ReverseRecords smart contract.
Apr 1 2024, 9:17 AM
ginsu accepted D11486: [lib] Switch to Sepolia for ENSCache unit tests.
Apr 1 2024, 9:14 AM
ginsu accepted D11485: [lib][native][web][keyserver][landing] Update to Ethers.js 6.
Apr 1 2024, 9:13 AM
ashoat added inline comments to D11505: [lib] introduce aux user types.
Apr 1 2024, 9:00 AM

Mar 31 2024

will requested review of D11511: [sqlite] implement processing aux user store ops on worker.
Mar 31 2024, 11:52 PM
will requested review of D11510: [sqlite] Implement C++ for native to get all aux user infos.
Mar 31 2024, 11:20 PM
will requested review of D11509: [sqlite] implement C++ aux user store ops.
Mar 31 2024, 10:54 PM
will requested review of D11508: [sqlite] introduce aux user store C++ methods.
Mar 31 2024, 10:30 PM
will requested review of D11507: [sqlite] add aux users table for aux user store data.
Mar 31 2024, 10:26 PM
will requested review of D11506: [lib] introduce the aux user store ops.
Mar 31 2024, 9:56 PM
will requested review of D11505: [lib] introduce aux user types.
Mar 31 2024, 9:50 PM
ashoat requested review of D11504: [lib] Allow keyserverAuth to update currentAsOf.
Mar 31 2024, 8:16 PM
ashoat requested review of D11503: [web] Add invalidSessionRecovery checks for web.
Mar 31 2024, 8:12 PM
ashoat requested review of D11502: [lib] Make invalidSessionRecovery work with all recoveryActionSources handled by KeyserverConnectionHandler.
Mar 31 2024, 8:07 PM
ashoat requested review of D11501: [keyserver] Don't block innerPerformAuth return on sleep.
Mar 31 2024, 8:03 PM
ashoat requested review of D11500: [lib] Use identity service for keyserver session recovery.
Mar 31 2024, 7:59 PM
ashoat requested review of D11499: [lib] Factor out innerPerformAuth for use in keyserver session recovery.
Mar 31 2024, 7:59 PM
ashoat requested review of D11498: [lib] Expose callKeyserverEndpoint in CallKeyserverEndpointContext.
Mar 31 2024, 7:57 PM
ashoat requested review of D11497: [lib] Don't invalidate a session if the recovery is cancelled.
Mar 31 2024, 7:56 PM
ashoat published D11496: [lib] Fix keyserver sending updated RoleInfos to old clients for review.
Mar 31 2024, 7:15 PM
ashoat added a comment to D11253: [lib] Remove `isDefault` field from `RoleInfo`.

This diff appears to have changed the behavior of rawThreadInfoFromServerThreadInfo even when !shouldIncludeSpecialRoleFieldInRoles... all clients that support minimally-encoded RawThreadInfos (basically all modern clients) are now getting the new format of RoleInfo, which they definitely don't support

Mar 31 2024, 6:33 PM