LGTM but @bartek should review this too
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Fri, Nov 15
Fri, Nov 15
kamil published D13928: [backup-client] avoid adding `attachments` when uploading User Keys for review.
Wed, Nov 13
Wed, Nov 13
[terraform] deploy backup 0.5.0 to prod
Tue, Nov 12
Tue, Nov 12
kamil committed rCOMMa2b0d2a52444: [CommCoreModule] make sure `backupID` is URL-safe string (authored by kamil).
[CommCoreModule] make sure `backupID` is URL-safe string
Thu, Nov 7
Thu, Nov 7
kamil committed rCOMMd8b209715799: [backup] add code comment to `UserKeys` definition explaining Olm account might… (authored by kamil).
[backup] add code comment to `UserKeys` definition explaining Olm account might…
[terraform] deploy backup 0.5.0 to staging
kamil updated the diff for D13857: [backup] add code comment to `UserKeys` definition explaining Olm account might be out of date.
remove extra line
kamil committed rCOMM82729d054cba: [backup-service][commtest] implement integration tests for uploading User Keys… (authored by kamil).
[backup-service][commtest] implement integration tests for uploading User Keys…
kamil committed rCOMM8561f8e86b3e: [backup-service] make `user_data` and `user_keys` optional in `BackupData` (authored by kamil).
[backup-service] make `user_data` and `user_keys` optional in `BackupData`
kamil committed rCOMM556469ea7e45: [backup-service] implement endpoint to upload User Data (authored by kamil).
[backup-service] implement endpoint to upload User Data
kamil committed rCOMM3eeef1e77029: [backup-service] implement endpoint to upload User Keys (authored by kamil).
[backup-service] implement endpoint to upload User Keys
kamil committed rCOMMe8f80a8bdb8c: [backup-service] make `user_data` optional in `BackupItem` (authored by kamil).
[backup-service] make `user_data` optional in `BackupItem`
kamil committed rCOMMb8c417d81cec: [backup-service] refactor uploading function in `/backups` endpoint (authored by kamil).
[backup-service] refactor uploading function in `/backups` endpoint
kamil committed rCOMM045eb2371305: [commtest] refactor backup service integration tests (authored by kamil).
[commtest] refactor backup service integration tests
kamil committed rCOMMd629425cb3f3: [native_rust_library] remove `backupID` from `SIWEBackupData` (authored by kamil).
[native_rust_library] remove `backupID` from `SIWEBackupData`
kamil committed rCOMM0cdb17b3921e: [CommCoreModule][native_rust_library] update downloading User Keys to support… (authored by kamil).
[CommCoreModule][native_rust_library] update downloading User Keys to support…
kamil committed rCOMM1960a4d944f8: [native] update Secondary Device Auth flow to support SIWE users (authored by kamil).
[native] update Secondary Device Auth flow to support SIWE users
kamil committed rCOMM0504d518f7f1: [CommCoreModule][native_rust_library] deprecate SIWE related backup code (authored by kamil).
[CommCoreModule][native_rust_library] deprecate SIWE related backup code
kamil committed rCOMM5a8e0d6d32c6: [native] unify username and wallet backup restore (authored by kamil).
[native] unify username and wallet backup restore
kamil committed rCOMM955ec0a26dea: [backup-client] make `backupID` mandatory when restoring backup (authored by kamil).
[backup-client] make `backupID` mandatory when restoring backup
kamil committed rCOMM98b8c540afcb: [native] make it possible to test retrieving latest backup info (authored by kamil).
[native] make it possible to test retrieving latest backup info
kamil committed rCOMMa32506b148da: [CommCoreModule] expose method to retrieve latest backup info (authored by kamil).
[CommCoreModule] expose method to retrieve latest backup info
kamil committed rCOMM532c51fae374: [native_rust_library] implement method to retrieve latest backup info (authored by kamil).
[native_rust_library] implement method to retrieve latest backup info
kamil committed rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type (authored by kamil).
[backup-client] refactor `SIWEBackupData` type
kamil committed rCOMM8f72e02e2b90: [backup-service][backup-client] update `/latest` endpoint to return both… (authored by kamil).
[backup-service][backup-client] update `/latest` endpoint to return both…
kamil committed rCOMMa966b4320fa6: [backup-service][backup-client] rename `username` -> `user_identifier` (authored by kamil).
[backup-service][backup-client] rename `username` -> `user_identifier`
kamil committed rCOMMf10da684e155: [backup-service] use `username` instead of `userID` when downloading backup (authored by kamil).
[backup-service] use `username` instead of `userID` when downloading backup
kamil committed rCOMM0422e7595594: [docker-compose] configure Identity endpoint for backup in commtest (authored by kamil).
[docker-compose] configure Identity endpoint for backup in commtest
kamil committed rCOMMe7b7c5923a85: [backup-service] implement calling `FindUserID` RPC from Backup (authored by kamil).
[backup-service] implement calling `FindUserID` RPC from Backup
kamil committed rCOMMc44768a780d3: [commtest] use registered `UserIdentity` in backup tests (authored by kamil).
[commtest] use registered `UserIdentity` in backup tests
kamil committed rCOMMaa69c9069ff7: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib` (authored by kamil).
[identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`
kamil updated the diff for D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately.
rebase before landing
kamil added inline comments to D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
kamil updated the diff for D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
address review
kamil added a comment to D13849: [CommCoreModule][native_rust_library] update downloading User Keys to support user identifier.
In D13849#387643, @bartek wrote:Alternatively, we can download only backupID and read backupDataKey and backupLogDataKey (it should exist on primary always) to avoid downloading User Keys - but curious about @bartek's perspective as I don't fully remember why it was implemented that way,
I don't remember either. Your changes make sense though
address nit
Wed, Nov 6
Wed, Nov 6
kamil published D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately for review.
Adding more reviewers here - maybe there is more edge-cases that worth testing too
kamil published D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData` for review.
Tue, Nov 5
Tue, Nov 5
kamil published D13873: [backup-service] refactor uploading function in `/backups` endpoint for review.
kamil updated the diff for D13809: [backup-service][backup-client] update `/latest` endpoint to return both `backupID` and `userID`.
rebase
kamil updated the diff for D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.
rebase
kamil updated the diff for D13807: [backup-service] use `username` instead of `userID` when downloading backup.
fix typo
rename
I like this new approach 👌