Page MenuHomePhorge
Feed All Stories

Mar 29 2023

ginsu closed D7242: [landing] add ted to team page.
Mar 29 2023, 7:20 PM
ginsu committed rCOMM81338ec0e683: [landing] add ted to team page.
Mar 29 2023, 7:20 PM
varun added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 29 2023, 7:11 PM
atul accepted D7242: [landing] add ted to team page.
Mar 29 2023, 7:10 PM
atul accepted D7233: [lib][native] Add function to encrypt files.

Some questions inline

Mar 29 2023, 7:09 PM
ginsu requested review of D7242: [landing] add ted to team page.
Mar 29 2023, 7:03 PM
atul accepted D7232: [native] Extract LoadableImage component.
Mar 29 2023, 7:01 PM
ashoat added a comment to D7232: [native] Extract LoadableImage component.

Just a question. Will leave it on others' queue in case they have review comments

Mar 29 2023, 6:45 PM
inka requested review of D7077: [keyserver] Process new messages for search.
Mar 29 2023, 6:43 PM
ashoat added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 29 2023, 6:35 PM
jon requested review of D7241: [Identity] Add opaque2 users table.
Mar 29 2023, 6:35 PM
ashoat accepted D7223: [lib] Add utilities for Uint8Array data.
Mar 29 2023, 6:32 PM
ashoat requested changes to D7225: [native] Add component to display encrypted images.

Sorry for requesting changes again, but I have a couple of questions. If you don't think any changes are necessary, please feel free to respond to my questions and re-request review!

Mar 29 2023, 5:16 PM
ashoat added inline comments to D7193: Save message instantly to redux for both foregrounded and backgrounded app.
Mar 29 2023, 5:05 PM
ashoat accepted D7227: [native] Add encrypted source support in <Multimedia>.
Mar 29 2023, 5:04 PM
tomek requested review of D7240: [keyserver] Redirect to the right store depending on the user agent.
Mar 29 2023, 5:03 PM
ashoat requested review of D7239: [keyserver] Don't swallow identity service exceptions in logInResponder.
Mar 29 2023, 5:02 PM
ashoat added inline comments to D7117: [keyserver] Add migration - process messages in our db for search.
Mar 29 2023, 5:01 PM
ashoat added a comment to D7117: [keyserver] Add migration - process messages in our db for search.

s/down/done corrects a typo of "down" with "done". It's using SED syntax for find-replace

Mar 29 2023, 5:00 PM
ashoat added inline comments to D7117: [keyserver] Add migration - process messages in our db for search.
Mar 29 2023, 5:00 PM
inka requested review of D7238: [keyserver] Add type workaround for Intl.Segmenter.
Mar 29 2023, 4:43 PM
inka added a comment to D7077: [keyserver] Process new messages for search.

I added D7238 to type Intl to have the Segmenter field.

Mar 29 2023, 4:28 PM
kuba planned changes to D7066: [native] Displaying 'Edit' labels next to edited messages.

Update test plan: https://phab.comm.dev/D7066#214478

Mar 29 2023, 4:15 PM
kuba added a comment to D7066: [native] Displaying 'Edit' labels next to edited messages.
In D7066#214942, @inka wrote:

Thank you for adding the link to the task. The DES task you linked is for Desktop though, and this is Native. Was it decided anywhere that we should use Desktop designs for Native?

Mar 29 2023, 4:14 PM
rohan updated the diff for D7220: [keyserver] Update pinnedCount when a message is pinned and unpinned.

Fix formatting

Mar 29 2023, 3:44 PM
rohan requested review of D7237: [keyserver/lib] Optimistically create the toggle pin message.
Mar 29 2023, 3:16 PM
bartek published D7235: [lib] Support encrypted media types in updateMultimediaMessageMediaAction for review.
Mar 29 2023, 2:21 PM
bartek published D7234: [native] Add function to encrypt media during media mission for review.
Mar 29 2023, 2:20 PM
bartek published D7233: [lib][native] Add function to encrypt files for review.
Mar 29 2023, 2:20 PM
jon accepted D7229: [native] more one-time setup for rust-C++ integration.
Mar 29 2023, 2:15 PM
bartek published D7232: [native] Extract LoadableImage component for review.
Mar 29 2023, 2:12 PM
bartek updated the summary of D7225: [native] Add component to display encrypted images.
Mar 29 2023, 1:43 PM
bartek updated the diff for D7225: [native] Add component to display encrypted images.
  • Replaced prevConnectionStatus state with ref. Kept attempt as state, because it needs to trigger hook and re-render when changed.
  • Extracted common logic to LoadableImage component - separate diff D7232
Mar 29 2023, 1:42 PM
tomek closed D7217: [keyserver] Introduce endpoint for deep linking.
Mar 29 2023, 1:12 PM
tomek closed D7219: [keyserver] Include debug fingerprint.
Mar 29 2023, 1:12 PM
tomek committed rCOMMc32938d893dc: [keyserver] Introduce endpoint for deep linking.
Mar 29 2023, 1:12 PM
tomek committed rCOMM6d0809489023: [keyserver] Include debug fingerprint.
Mar 29 2023, 1:12 PM
tomek closed D7231: [native] Ignore landing in Flow config.
Mar 29 2023, 1:12 PM
tomek committed rCOMM9f5324bb1836: [native] Ignore landing in Flow config.
Mar 29 2023, 1:12 PM
marcin accepted D7231: [native] Ignore landing in Flow config.
Mar 29 2023, 1:08 PM
bartek accepted D7231: [native] Ignore landing in Flow config.
Mar 29 2023, 1:06 PM
tomek requested review of D7231: [native] Ignore landing in Flow config.
Mar 29 2023, 1:03 PM
marcin added inline comments to D7193: Save message instantly to redux for both foregrounded and backgrounded app.
Mar 29 2023, 12:40 PM
tomek updated the summary of D7217: [keyserver] Introduce endpoint for deep linking.
Mar 29 2023, 12:38 PM
inka added a comment to D7077: [keyserver] Process new messages for search.

I don't think we want to strip all non-letter characters, because then we loose the emojis again.
Here is punctuation regex defined by wikipedia:

[][!"#$%&'()*+,./:;<=>?@\^_`{|}~-]

maybe we could use that?

Mar 29 2023, 12:16 PM
bartek added inline comments to D7227: [native] Add encrypted source support in <Multimedia>.
Mar 29 2023, 12:14 PM
tomek closed D7216: [native] Add boilerplate for deep links on iOS.
Mar 29 2023, 12:12 PM
tomek committed rCOMM6807fedbc1bb: [native] Add boilerplate for deep links on iOS.
Mar 29 2023, 12:12 PM
tomek updated the diff for D7217: [keyserver] Introduce endpoint for deep linking.

Move import

Mar 29 2023, 11:24 AM
kuba updated the diff for D7141: [keyserver] Display edited message in the sidebar if the source message is edited.

Removed redundant SQL query, used fetchLatestEditMessageContentByIDs in fetchLatestEditMessageContentByID

Mar 29 2023, 11:13 AM
kuba updated the test plan for D7141: [keyserver] Display edited message in the sidebar if the source message is edited.
Mar 29 2023, 11:11 AM
kuba added a comment to D7066: [native] Displaying 'Edit' labels next to edited messages.
In D7066#214942, @inka wrote:

Thank you for adding the link to the task. The DES task you linked is for Desktop though, and this is Native. Was it decided anywhere that we should use Desktop designs for Native?

Mar 29 2023, 10:19 AM
inka updated the diff for D7117: [keyserver] Add migration - process messages in our db for search.

Simplify logic

Mar 29 2023, 9:42 AM
inka added inline comments to D7117: [keyserver] Add migration - process messages in our db for search.
Mar 29 2023, 9:40 AM
bartek updated the diff for D7227: [native] Add encrypted source support in <Multimedia>.
  • Made type read-only
  • Replaced custom compare fn with _isEqual
  • Stopped reporting holders as URIs
Mar 29 2023, 9:25 AM
kuba added a comment to D7128: [lib][keyserver] Added new edit_message endpoint.
In D7128#214943, @inka wrote:

What about the test plan?

Mar 29 2023, 9:11 AM
kuba updated the test plan for D7128: [lib][keyserver] Added new edit_message endpoint.
Mar 29 2023, 9:10 AM
bartek updated the diff for D7226: [native] VideoPlaybackModal support for encrypted video.

Address feedback - move logic out of JSX tree

Mar 29 2023, 8:36 AM
inka added a comment to D7128: [lib][keyserver] Added new edit_message endpoint.

What about the test plan?

Mar 29 2023, 8:12 AM
inka added a comment to D7066: [native] Displaying 'Edit' labels next to edited messages.

Thank you for adding the link to the task. The DES task you linked is for Desktop though, and this is Native. Was it decided anywhere that we should use Desktop designs for Native?

Mar 29 2023, 7:59 AM
inka accepted D7063: [native] Move 'InlineEngagement' styling from 'ComposedMessage' to component.
Mar 29 2023, 7:41 AM
bartek updated the diff for D7224: [native] Add function to decrypt media file.

Made input type read-only.

Mar 29 2023, 7:28 AM
bartek updated the diff for D7223: [lib] Add utilities for Uint8Array data.

Moved the 3rd-party function to a separate file and attached license. I'll also create a task to replace this with native code

Mar 29 2023, 7:24 AM
bartek added inline comments to D7223: [lib] Add utilities for Uint8Array data.
Mar 29 2023, 7:17 AM
bartek added inline comments to D7226: [native] VideoPlaybackModal support for encrypted video.
Mar 29 2023, 6:14 AM
bartek added inline comments to D7225: [native] Add component to display encrypted images.
Mar 29 2023, 6:07 AM
ashoat added inline comments to D7222: [lib] Add function to calculate padding size.
Mar 29 2023, 1:25 AM

Mar 28 2023

atul accepted D7211: [keyserver/lib/native] Store the number of pinned messages in ThreadInfo.

Please address @ashoat's feedback before landing.

Mar 28 2023, 11:47 PM
atul accepted D7226: [native] VideoPlaybackModal support for encrypted video.

Provided a fake encrypted mediaInfo prop, opened the modal and ensured that a spinner is displayed while decryption is in progress and controls are hidded. After successful decryption, the video starts playing.

Mar 28 2023, 11:30 PM
atul accepted D7202: [native] Add pinned_count column to SQLite threads table.

Thanks @kamil for taking a thorough look at this diff!

Mar 28 2023, 11:23 PM
atul accepted D7228: [native] Fixes for handling encrypted media messages.
Mar 28 2023, 11:18 PM
atul accepted D7224: [native] Add function to decrypt media file.
Mar 28 2023, 11:17 PM
atul accepted D7170: [lib] Store encrypted messages in Client DB.

Thanks for including aunt sets

Mar 28 2023, 11:14 PM
atul accepted D7222: [lib] Add function to calculate padding size.

Thanks for including a test (and adding a comment explaining what's happening)

Mar 28 2023, 10:54 PM
jon accepted D7215: [native] make generateNonce callable from js.

rust looks okay to me. Just don't like that the callee has to have awareness of the promise ID.

Mar 28 2023, 10:10 PM
ashoat accepted D7215: [native] make generateNonce callable from js.
Mar 28 2023, 8:46 PM
ashoat accepted D7230: [lib] Add option to force-create multimedia-type message.
Mar 28 2023, 8:46 PM
atul added a comment to D7212: [lib][web][native] Introduce commServicesAccessToken to Redux state.

True that makes sense

Mar 28 2023, 8:42 PM
ashoat closed D7201: [web][keyserver] Webpack config and client logic to access opaque-ke2 WASM bindings.
Mar 28 2023, 8:41 PM
ashoat committed rCOMM506aacc7ccc0: [web][keyserver] Webpack config and client logic to access opaque-ke2 WASM….
Mar 28 2023, 8:41 PM
atul accepted D7193: Save message instantly to redux for both foregrounded and backgrounded app.

This looks good to me, but full disclosure I have limited familiarity with this side of the codebase... so please keep that in mind before landing (aka maybe consider having someone else take a final look)

Mar 28 2023, 8:35 PM
ashoat added a comment to D7212: [lib][web][native] Introduce commServicesAccessToken to Redux state.
In D7212#214878, @atul wrote:

Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?

Mar 28 2023, 8:34 PM
atul accepted D7210: [web] render thread avatars on chat screen.
Mar 28 2023, 8:34 PM
atul accepted D7208: [web] render user avatars in typeahead tooltip.
Mar 28 2023, 8:33 PM
varun added 2 blocking reviewer(s) for D7215: [native] make generateNonce callable from js: ashoat, jon.
Mar 28 2023, 8:33 PM
varun added 1 blocking reviewer(s) for D7229: [native] more one-time setup for rust-C++ integration: jon.
Mar 28 2023, 8:32 PM
atul accepted D7212: [lib][web][native] Introduce commServicesAccessToken to Redux state.

Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?

Mar 28 2023, 8:27 PM
bartek published D7230: [lib] Add option to force-create multimedia-type message for review.
Mar 28 2023, 8:25 PM
atul accepted D7201: [web][keyserver] Webpack config and client logic to access opaque-ke2 WASM bindings.

Thanks for annotating the changes with explanations

Mar 28 2023, 8:25 PM
ashoat requested changes to D7223: [lib] Add utilities for Uint8Array data.

Requesting changes to either "rewrite with inspiration" or to move copy-pasted code to a third-party folder with the license

Mar 28 2023, 8:24 PM
atul accepted D7209: [web] render thread avatars in the community drawer.
Mar 28 2023, 8:22 PM
atul added a comment to D7208: [web] render user avatars in typeahead tooltip.

(Please address @ashoat's feedback before landing)

Mar 28 2023, 8:22 PM
atul accepted D7207: [web] render user avatars in thread memebers modal.

(Please address @ashoat's feedback before landing)

Mar 28 2023, 8:21 PM
atul accepted D7206: [web] render user avatars in chat thread composer.

(Please address @ashoat's feedback before landing)

Mar 28 2023, 8:20 PM
atul accepted D7205: [web] render user avatars in account relationship lists.

(Please address @ashoat's feedback before landing)

Mar 28 2023, 8:20 PM
bartek added inline comments to D7226: [native] VideoPlaybackModal support for encrypted video.
Mar 28 2023, 8:11 PM
ashoat added inline comments to D7225: [native] Add component to display encrypted images.
Mar 28 2023, 8:10 PM
atul accepted D7196: [web] render user avatars in message reactions modal.
Mar 28 2023, 8:09 PM
ashoat added inline comments to D7226: [native] VideoPlaybackModal support for encrypted video.
Mar 28 2023, 8:07 PM
ashoat requested changes to D7227: [native] Add encrypted source support in <Multimedia>.

Minor comments

Mar 28 2023, 8:00 PM