Some questions inline
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Mar 29 2023
Just a question. Will leave it on others' queue in case they have review comments
Sorry for requesting changes again, but I have a couple of questions. If you don't think any changes are necessary, please feel free to respond to my questions and re-request review!
s/down/done corrects a typo of "down" with "done". It's using SED syntax for find-replace
I added D7238 to type Intl to have the Segmenter field.
Update test plan: https://phab.comm.dev/D7066#214478
In D7066#214942, @inka wrote:Thank you for adding the link to the task. The DES task you linked is for Desktop though, and this is Native. Was it decided anywhere that we should use Desktop designs for Native?
Fix formatting
- Replaced prevConnectionStatus state with ref. Kept attempt as state, because it needs to trigger hook and re-render when changed.
- Extracted common logic to LoadableImage component - separate diff D7232
I don't think we want to strip all non-letter characters, because then we loose the emojis again.
Here is punctuation regex defined by wikipedia:
[][!"#$%&'()*+,./:;<=>?@\^_`{|}~-]maybe we could use that?
Move import
Removed redundant SQL query, used fetchLatestEditMessageContentByIDs in fetchLatestEditMessageContentByID
In D7066#214942, @inka wrote:Thank you for adding the link to the task. The DES task you linked is for Desktop though, and this is Native. Was it decided anywhere that we should use Desktop designs for Native?
Simplify logic
- Made type read-only
- Replaced custom compare fn with _isEqual
- Stopped reporting holders as URIs
In D7128#214943, @inka wrote:What about the test plan?
Address feedback - move logic out of JSX tree
What about the test plan?
Thank you for adding the link to the task. The DES task you linked is for Desktop though, and this is Native. Was it decided anywhere that we should use Desktop designs for Native?
Made input type read-only.
Moved the 3rd-party function to a separate file and attached license. I'll also create a task to replace this with native code
Mar 28 2023
Please address @ashoat's feedback before landing.
Provided a fake encrypted mediaInfo prop, opened the modal and ensured that a spinner is displayed while decryption is in progress and controls are hidded. After successful decryption, the video starts playing.
Thanks @kamil for taking a thorough look at this diff!
Thanks for including aunt sets
Thanks for including a test (and adding a comment explaining what's happening)
rust looks okay to me. Just don't like that the callee has to have awareness of the promise ID.
True that makes sense
This looks good to me, but full disclosure I have limited familiarity with this side of the codebase... so please keep that in mind before landing (aka maybe consider having someone else take a final look)
In D7212#214878, @atul wrote:Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?
Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?
Thanks for annotating the changes with explanations
Requesting changes to either "rewrite with inspiration" or to move copy-pasted code to a third-party folder with the license
(Please address @ashoat's feedback before landing)
(Please address @ashoat's feedback before landing)
(Please address @ashoat's feedback before landing)
(Please address @ashoat's feedback before landing)
Minor comments