Await for processMessagesForSearch promise, Use Intl for tokenizing, add tests
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Mar 30 2023
Split this diff into two
Have you tried the code snippet I suggested in my first review on Tuesday? Does it work or no?
Don't have much more to say
Planning changes to spend some more time testing before I land the stack + to address feedback
Re-requesting review to verify my point of view
"Add useMemo" isn't a good follow-up task, please respond to the diff comments here directly
Matched editedLabelHeight with new fontSize
Looks good to me
separate code for two diffs
Add explicitly fontSize for label to prevent messageHeight error
Created new color in theme for messageLabel
fix query format
fix type and query format
fix query formatting
address nit
remove unused dependency
found an easier way without adding a custom service wrapper
Mar 29 2023
have Avatar component use Multimedia instead of RemoteImage
rebase and land
Address more feedback
What happens if you deploy a debug build to an iOS device that previously had a release build? It would be able to keep using the previously determined encryptionKey, right? (And vice versa, going from debug to release?)
What happens if you deploy a debug build to an iOS device that previously had a release build? It would be able to keep using the previously determined encryptionKey, right? (And vice versa, going from debug to release?)
I'm also wondering if we should remove the punctuation from inside of words. Maybe only strip the punctuation at the beginning and at the end? Since it makes sense to leave o'clock and 100,000 and such.
Looks good, minor note about swapping out Lodash
Add device type
Just a question:
Looks good!
Accepting, but noted concerns about filename potentially leaking information in "Cryptography discussion" if you could take a look