Page MenuHomePhorge
Feed All Stories

Mar 30 2023

ashoat closed D7239: [keyserver] Don't swallow identity service exceptions in logInResponder.
Mar 30 2023, 1:15 PM
ashoat committed rCOMM0f09a5ec2291: [keyserver] Don't swallow identity service exceptions in logInResponder.
Mar 30 2023, 1:15 PM
ashoat accepted D7246: [native] introduce user avatar component.
Mar 30 2023, 1:14 PM
inka updated the test plan for D7077: [keyserver] Process new messages for search.
Mar 30 2023, 1:13 PM
atul accepted D7249: [keyserver] Allow localhost CORS origin in development.
Mar 30 2023, 1:11 PM
inka updated the diff for D7077: [keyserver] Process new messages for search.

Await for processMessagesForSearch promise, Use Intl for tokenizing, add tests

Mar 30 2023, 1:11 PM
michal retitled D7218: [desktop] Modify the generated native windows notifs module from [desktop] Native module for windows notifications
Mar 30 2023, 1:11 PM
michal updated the summary of D7218: [desktop] Modify the generated native windows notifs module.
Mar 30 2023, 1:10 PM
michal updated the diff for D7218: [desktop] Modify the generated native windows notifs module.

Split this diff into two

Mar 30 2023, 1:09 PM
ashoat accepted D7232: [native] Extract LoadableImage component.
Mar 30 2023, 1:09 PM
ashoat added inline comments to D7232: [native] Extract LoadableImage component.
Mar 30 2023, 1:09 PM
michal requested review of D7250: [desktop] Include generated native windows notifs.
Mar 30 2023, 1:04 PM
bartek added inline comments to D7235: [lib] Support encrypted media types in updateMultimediaMessageMediaAction.
Mar 30 2023, 12:53 PM
ashoat requested changes to D7225: [native] Add component to display encrypted images.

Have you tried the code snippet I suggested in my first review on Tuesday? Does it work or no?

Mar 30 2023, 12:46 PM
ashoat resigned from D7241: [Identity] Add opaque2 users table.

Don't have much more to say

Mar 30 2023, 12:41 PM
ashoat added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 30 2023, 12:41 PM
bartek requested review of D7249: [keyserver] Allow localhost CORS origin in development.
Mar 30 2023, 12:34 PM
bartek accepted D7244: [identity] enable grpc-web on identity service.
Mar 30 2023, 12:20 PM
bartek accepted D7187: [native] extend avatar component to handle images.

This looks good. It is compatible with my changes in D7227 and D7232

Mar 30 2023, 12:11 PM
rohan planned changes to D7211: [keyserver/lib/native] Store the number of pinned messages in ThreadInfo.

Planning changes to spend some more time testing before I land the stack + to address feedback

Mar 30 2023, 12:04 PM
tomek requested changes to D7191: [web-db] implement clearing sensitive data.
Mar 30 2023, 11:58 AM
tomek requested changes to D7189: [web-db] add database module provider.
Mar 30 2023, 11:54 AM
bartek published D7236: [native] Encrypt files during media mission for review.
Mar 30 2023, 11:51 AM
tomek accepted D7186: [web-db] start persisting SQLite content.
Mar 30 2023, 11:48 AM
bartek requested review of D7225: [native] Add component to display encrypted images.

Re-requesting review to verify my point of view

Mar 30 2023, 11:44 AM
ashoat requested changes to D7140: [lib] Displaying edited content in a pending thread.

"Add useMemo" isn't a good follow-up task, please respond to the diff comments here directly

Mar 30 2023, 11:43 AM
bartek added inline comments to D7232: [native] Extract LoadableImage component.
Mar 30 2023, 11:42 AM
tomek accepted D7185: [web-db] process redux-persist operations in SQLite.
Mar 30 2023, 10:24 AM
kuba added inline comments to D7140: [lib] Displaying edited content in a pending thread.
Mar 30 2023, 9:59 AM
kuba updated the diff for D7066: [native] Displaying 'Edit' labels next to edited messages.

Matched editedLabelHeight with new fontSize

Mar 30 2023, 9:56 AM
michal accepted D7142: [lib] Checking if the user can edit the message.
Mar 30 2023, 9:55 AM
michal accepted D7128: [lib][keyserver] Added new edit_message endpoint.

Looks good to me

Mar 30 2023, 9:54 AM
inka added inline comments to D7077: [keyserver] Process new messages for search.
Mar 30 2023, 9:39 AM
kamil added inline comments to D7185: [web-db] process redux-persist operations in SQLite.
Mar 30 2023, 9:26 AM
kamil updated the diff for D7185: [web-db] process redux-persist operations in SQLite.

separate code for two diffs

Mar 30 2023, 9:21 AM
kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Add explicitly fontSize for label to prevent messageHeight error

Mar 30 2023, 8:52 AM
kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Created new color in theme for messageLabel

Mar 30 2023, 8:27 AM
kamil closed D7183: [web-db] add table and operations for redux-persist engine.
Mar 30 2023, 8:24 AM
kamil closed D7184: [web-db] add unit tests for redux-persist engine operations.
Mar 30 2023, 8:24 AM
kamil closed D7182: [web-db] implement setting/getting `currentUserID` on worker.
Mar 30 2023, 8:24 AM
kamil committed rCOMM603ceea40cb4: [web-db] add table and operations for redux-persist engine.
Mar 30 2023, 8:24 AM
kamil committed rCOMMeca70ade03b9: [web-db] add unit tests for redux-persist engine operations.
Mar 30 2023, 8:24 AM
kamil closed D7181: [web-db] add unit tests for metadata operations.
Mar 30 2023, 8:24 AM
kamil committed rCOMMc37fdc73806b: [web-db] implement setting/getting `currentUserID` on worker.
Mar 30 2023, 8:24 AM
kamil closed D7180: [web-db] add metadata table operations.
Mar 30 2023, 8:24 AM
kamil committed rCOMM1120f89ed7bb: [web-db] add unit tests for metadata operations.
Mar 30 2023, 8:24 AM
kamil committed rCOMM005ff6a137c5: [web-db] add metadata table operations.
Mar 30 2023, 8:24 AM
kamil closed D7154: [web-db] get client database store from SQLite.
Mar 30 2023, 8:24 AM
kamil committed rCOMMf643d8fcd460: [web-db] get client database store from SQLite.
Mar 30 2023, 8:24 AM
kamil closed D7153: [web-db] process Draft Store Operations on worker.
Mar 30 2023, 8:24 AM
kamil committed rCOMMefff9422557b: [web-db] process Draft Store Operations on worker.
Mar 30 2023, 8:24 AM
kamil closed D7124: [web-db] add unit tests for draft store queries.
Mar 30 2023, 8:24 AM
kamil closed D7123: [web-db] implement function get all drafts from SQLite.
Mar 30 2023, 8:24 AM
kamil committed rCOMMceff50b57731: [web-db] add unit tests for draft store queries.
Mar 30 2023, 8:24 AM
kamil closed D7122: [web-db] implement Draft Store Operations.
Mar 30 2023, 8:24 AM
kamil committed rCOMM85b420a7217c: [web-db] implement function get all drafts from SQLite.
Mar 30 2023, 8:24 AM
kamil committed rCOMM640ebb7a374d: [web-db] implement Draft Store Operations.
Mar 30 2023, 8:24 AM
kamil closed D7121: [web-db] create drafts table in SQLite database.
Mar 30 2023, 8:24 AM
kamil committed rCOMM5dea58c20130: [web-db] create drafts table in SQLite database.
Mar 30 2023, 8:24 AM
kamil added inline comments to D7180: [web-db] add metadata table operations.
Mar 30 2023, 8:19 AM
kamil updated the diff for D7183: [web-db] add table and operations for redux-persist engine.

fix query format

Mar 30 2023, 8:01 AM
kamil updated the diff for D7180: [web-db] add metadata table operations.

fix type and query format

Mar 30 2023, 7:58 AM
kamil updated the diff for D7124: [web-db] add unit tests for draft store queries.

fix query formatting

Mar 30 2023, 7:20 AM
kamil updated the diff for D7123: [web-db] implement function get all drafts from SQLite.

address nit

Mar 30 2023, 7:17 AM
atul accepted D7245: [native] update Image import to use expo-image in Multimedia component.
Mar 30 2023, 4:00 AM
varun requested review of D7247: [nix] add tool to identify unused dependencies in Cargo projects.
Mar 30 2023, 3:50 AM
varun updated the diff for D7244: [identity] enable grpc-web on identity service.

remove unused dependency

Mar 30 2023, 3:26 AM
varun accepted D7239: [keyserver] Don't swallow identity service exceptions in logInResponder.
Mar 30 2023, 3:19 AM
varun updated the diff for D7244: [identity] enable grpc-web on identity service.

found an easier way without adding a custom service wrapper

Mar 30 2023, 3:18 AM

Mar 29 2023

ginsu added reviewers for D7246: [native] introduce user avatar component: ashoat, atul.
Mar 29 2023, 11:49 PM
ginsu added inline comments to D7246: [native] introduce user avatar component.
Mar 29 2023, 11:49 PM
ginsu requested review of D7246: [native] introduce user avatar component.
Mar 29 2023, 11:42 PM
ginsu accepted D7017: [web] Added displaying 'Labels' to InlineEngagment.
Mar 29 2023, 11:07 PM
ginsu requested review of D7245: [native] update Image import to use expo-image in Multimedia component.
Mar 29 2023, 11:03 PM
ginsu retitled D7187: [native] extend avatar component to handle images from [draft][native] extend avatar component to handle images
Mar 29 2023, 11:02 PM
ginsu updated the diff for D7187: [native] extend avatar component to handle images.

have Avatar component use Multimedia instead of RemoteImage

Mar 29 2023, 10:55 PM
atul closed D7243: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds.
Mar 29 2023, 10:51 PM
atul committed rCOMM4118e62b12af: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds.
Mar 29 2023, 10:51 PM
atul updated the diff for D7243: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds.

rebase and land

Mar 29 2023, 10:51 PM
varun requested review of D7244: [identity] enable grpc-web on identity service.
Mar 29 2023, 10:26 PM
jon updated the diff for D7241: [Identity] Add opaque2 users table.

Address more feedback

Mar 29 2023, 10:06 PM
jon added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 29 2023, 10:06 PM
atul added a comment to D7243: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds.

What happens if you deploy a debug build to an iOS device that previously had a release build? It would be able to keep using the previously determined encryptionKey, right? (And vice versa, going from debug to release?)

Mar 29 2023, 10:01 PM
ashoat accepted D7243: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds.

What happens if you deploy a debug build to an iOS device that previously had a release build? It would be able to keep using the previously determined encryptionKey, right? (And vice versa, going from debug to release?)

Mar 29 2023, 9:31 PM
atul published D7243: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds for review.
Mar 29 2023, 8:50 PM
ashoat added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 29 2023, 8:12 PM
varun added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 29 2023, 8:11 PM
ashoat requested changes to D7077: [keyserver] Process new messages for search.

I'm also wondering if we should remove the punctuation from inside of words. Maybe only strip the punctuation at the beginning and at the end? Since it makes sense to leave o'clock and 100,000 and such.

Mar 29 2023, 8:09 PM
ashoat accepted D7240: [keyserver] Redirect to the right store depending on the user agent.
Mar 29 2023, 8:07 PM
atul accepted D7235: [lib] Support encrypted media types in updateMultimediaMessageMediaAction.

Looks good, minor note about swapping out Lodash

Mar 29 2023, 8:03 PM
ashoat requested changes to D7238: [keyserver] Add type workaround for Intl.Segmenter.
Mar 29 2023, 8:03 PM
jon updated the diff for D7241: [Identity] Add opaque2 users table.

Add device type

Mar 29 2023, 8:00 PM
ashoat added inline comments to D7235: [lib] Support encrypted media types in updateMultimediaMessageMediaAction.
Mar 29 2023, 7:59 PM
ashoat added a comment to D7235: [lib] Support encrypted media types in updateMultimediaMessageMediaAction.

Just a question:

Mar 29 2023, 7:58 PM
varun closed D7215: [native] make generateNonce callable from js.
Mar 29 2023, 7:57 PM
varun committed rCOMM34449495726c: [native] make generateNonce callable from js.
Mar 29 2023, 7:57 PM
varun closed D7229: [native] more one-time setup for rust-C++ integration.
Mar 29 2023, 7:56 PM
varun committed rCOMM3a6124060767: [native] more one-time setup for rust-C++ integration.
Mar 29 2023, 7:56 PM
atul accepted D7237: [keyserver/lib] Optimistically create the toggle pin message.

Looks good!

Mar 29 2023, 7:42 PM
atul accepted D7234: [native] Add function to encrypt media during media mission.

Accepting, but noted concerns about filename potentially leaking information in "Cryptography discussion" if you could take a look

Mar 29 2023, 7:29 PM