Feed Search

Search
Use Results
Edit Query
Hide Query

Feb 15 2024

ginsu updated the diff for D10315: [web] cleanup thread notifications modal.

rebase before landing

Feb 15 2024, 8:26 AM

ginsu updated the diff for D10282: [web] cleanup thread notifications modal rendering logic.

rebase before landing

Feb 15 2024, 8:25 AM

ginsu updated the diff for D10279: [web] cleanup confirm leave thread modal.

rebase before landing

Feb 15 2024, 8:24 AM

ginsu updated the diff for D10276: [web] cleanup sidebar promote modal.

rebase before landing

Feb 15 2024, 8:22 AM

ginsu updated the diff for D10273: [web] cleanup message reactions modal.

rebase before landing

Feb 15 2024, 8:19 AM

ginsu updated the diff for D10269: [web] cleanup toggle pin modal.

rebase before landing

Feb 15 2024, 8:18 AM

ginsu updated the diff for D10267: [web] cleanup push notif modal.

rebase before landing

Feb 15 2024, 8:17 AM

ginsu closed D10266: [web] introduce secondary button prop to modal component.

Feb 15 2024, 8:10 AM

ginsu closed D10242: [web] update password change modal css to use camalcase.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM87547ad343a8: [web] update password change modal css to use camalcase.

Feb 15 2024, 8:10 AM

ginsu committed rCOMMdee71a4f63b6: [web] introduce secondary button prop to modal component.

Feb 15 2024, 8:10 AM

ginsu closed D10241: [web] cleanup apps modal.

Feb 15 2024, 8:10 AM

ginsu closed D10240: [web] cleanup view invite link modal.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM8575cbe405be: [web] cleanup apps modal.

Feb 15 2024, 8:10 AM

ginsu closed D10238: [web] cleanup manage invite links empty link modal.

Feb 15 2024, 8:10 AM

ginsu closed D10239: [web] cleanup manage invite links existing link modal.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM1aaa922d9bf8: [web] cleanup view invite link modal.

Feb 15 2024, 8:10 AM

ginsu committed rCOMMa22c689a83f1: [web] cleanup manage invite links existing link modal.

Feb 15 2024, 8:10 AM

ginsu closed D10237: [web] match the veritcal padding for modals with no button containers.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM4456fd205c4b: [web] cleanup manage invite links empty link modal.

Feb 15 2024, 8:10 AM

ginsu committed rCOMMb7dcd3f40bdb: [web] match the veritcal padding for modals with no button containers.

Feb 15 2024, 8:10 AM

ginsu closed D10236: [web] cleanup community creation modal.

Feb 15 2024, 8:10 AM

ginsu closed D10234: [web] introduce subheader prop to modal component.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM8cc7bcccd127: [web] introduce subheader prop to modal component.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM7d9860b5542f: [web] cleanup community creation modal.

Feb 15 2024, 8:10 AM

ginsu closed D10230: [web] cleanup community roles modal.

Feb 15 2024, 8:10 AM

ginsu closed D10232: [web] cleanup password change modal.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM29e38b3829a3: [web] cleanup community roles modal.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM9dd68c7c57e0: [web] cleanup password change modal.

Feb 15 2024, 8:10 AM

ginsu closed D10228: [web] introduce new redesigned modal component.

Feb 15 2024, 8:10 AM

ginsu committed rCOMM121f30b84070: [web] introduce new redesigned modal component.

Feb 15 2024, 8:10 AM

ginsu updated the diff for D10266: [web] introduce secondary button prop to modal component.

rebase before landing

Feb 15 2024, 8:06 AM

ginsu updated the diff for D10242: [web] update password change modal css to use camalcase.

rebase before landing

Feb 15 2024, 8:04 AM

ginsu updated the diff for D10241: [web] cleanup apps modal.

rebase before landing

Feb 15 2024, 8:03 AM

ginsu updated the diff for D10240: [web] cleanup view invite link modal.

rebase before landing

Feb 15 2024, 8:02 AM

ginsu updated the diff for D10239: [web] cleanup manage invite links existing link modal.

rebase before landing

Feb 15 2024, 8:01 AM

ginsu updated the diff for D10238: [web] cleanup manage invite links empty link modal.

rebase before landing

Feb 15 2024, 7:59 AM

ginsu updated the diff for D10237: [web] match the veritcal padding for modals with no button containers.

rebase before landing

Feb 15 2024, 7:58 AM

ginsu updated the diff for D10236: [web] cleanup community creation modal.

rebase before landing

Feb 15 2024, 7:58 AM

ginsu updated the diff for D10234: [web] introduce subheader prop to modal component.

rebase before landing

Feb 15 2024, 7:57 AM

ginsu added a comment to D10232: [web] cleanup password change modal.

Does it make sense to define the error placeholder in the Modal component directly as an optional prop if we're going to need it in multiple places? Just an idea to enforce consistency

Feb 15 2024, 7:56 AM

ginsu updated the diff for D10232: [web] cleanup password change modal.

rebase before landing

Feb 15 2024, 7:55 AM

ginsu updated the diff for D10230: [web] cleanup community roles modal.

rebase before landing

Feb 15 2024, 7:47 AM

ginsu updated the diff for D10228: [web] introduce new redesigned modal component.

rebase before landing

Feb 15 2024, 7:46 AM

Feb 14 2024

ginsu closed D11070: [lib] introduce CommunityStore spec.

Feb 14 2024, 10:07 PM

ginsu committed rCOMM4ff8492e42c9: [lib] introduce CommunityStore spec.

Feb 14 2024, 10:07 PM

ginsu updated the diff for D11070: [lib] introduce CommunityStore spec.

rebase before landing

Feb 14 2024, 10:06 PM

ginsu requested review of D11031: [web] introduce thread settings utils.

updated test plan

Feb 14 2024, 8:21 PM

ginsu attached a referenced file: F1153445: Screen Recording 2024-02-14 at 3.17.13 PM.mov.

Feb 14 2024, 8:21 PM

ginsu updated the test plan for D11031: [web] introduce thread settings utils.

Feb 14 2024, 8:21 PM

ginsu added a comment to D10994: [web] cleanup change member role modal.

test plan has been updated to reflect the new changes

Feb 14 2024, 8:14 PM

ginsu attached a referenced file: F1153405: Screen Recording 2024-02-14 at 3.11.33 PM.mov.

Feb 14 2024, 8:12 PM

ginsu updated the test plan for D10994: [web] cleanup change member role modal.

Feb 14 2024, 8:12 PM

ginsu updated the diff for D10994: [web] cleanup change member role modal.

address feedback

Feb 14 2024, 8:10 PM

ginsu requested review of D11070: [lib] introduce CommunityStore spec.

Feb 14 2024, 8:28 AM

ginsu requested review of D11069: [web] cleanup members modal.

Feb 14 2024, 8:23 AM

ginsu requested review of D11067: [web] remove deprecated members modals code.

Feb 14 2024, 8:19 AM

ginsu requested review of D11068: [web] cleanup user list modals.

Feb 14 2024, 8:18 AM

ginsu requested review of D11066: [web] cleanup compose subchannel modal.

Feb 14 2024, 8:12 AM

ginsu requested review of D11065: [web] use AddUsersList in SubchannelMembers.

Feb 14 2024, 7:54 AM

ginsu updated the summary of D10994: [web] cleanup change member role modal.

Feb 14 2024, 7:32 AM

ginsu requested review of D11064: [web] cleanup create roles modal.

Feb 14 2024, 7:28 AM

ginsu requested review of D11063: [web] cleanup enum option component when there is no icon.

Feb 14 2024, 7:22 AM

Feb 13 2024

ginsu accepted D11055: [lib] Introduce `patchRoleInfoWithSpecialRole(RoleInfo): RoleInfo`.

seems reasonable

Feb 13 2024, 8:55 PM

ginsu closed D11036: [lib] introduce barebones community types.

Feb 13 2024, 7:20 PM

ginsu committed rCOMM787d2ea5043e: [lib] introduce barebones community types.

Feb 13 2024, 7:20 PM

ginsu updated the diff for D11036: [lib] introduce barebones community types.

address feedback

Feb 13 2024, 7:19 PM

Feb 12 2024

ginsu requested review of D11036: [lib] introduce barebones community types.

Feb 12 2024, 10:40 AM

ginsu requested review of D11035: [web] reintroduce error message to thread settings modal.

Feb 12 2024, 10:27 AM

ginsu requested review of D11034: [web] cleanup thread settings general + privacy tabs.

Feb 12 2024, 10:17 AM

ginsu requested review of D11033: [web] cleanup thread settings relationship tab.

Feb 12 2024, 10:12 AM

ginsu requested review of D11030: [web] cleanup keyserver selection modal.

Feb 12 2024, 10:07 AM

ginsu requested review of D11032: [web] cleanup thread settings modal delete tab.

Feb 12 2024, 10:02 AM

ginsu requested review of D11031: [web] introduce thread settings utils.

Feb 12 2024, 9:57 AM

ginsu requested review of D11029: [web] cleanup add keyserver modal.

Feb 12 2024, 9:50 AM

ginsu requested review of D11027: [web] clean up user profiles modal.

Feb 12 2024, 7:22 AM

ginsu requested review of D11026: [web] cleanup alert modal.

Feb 12 2024, 7:02 AM

ginsu requested review of D11025: [web] cleanup UnsavedChangesModal.

Feb 12 2024, 6:58 AM

ginsu attached a referenced file: F1144059: Screen Recording 2024-02-12 at 1.18.31 AM.mov.

Feb 12 2024, 6:37 AM

ginsu attached a referenced file: F1144075: Screen Recording 2024-02-12 at 1.36.04 AM.mov.

Feb 12 2024, 6:37 AM

ginsu updated the summary of D11024: [web] cleanup community creation members modal.

Feb 12 2024, 6:37 AM

ginsu requested review of D11024: [web] cleanup community creation members modal.

Feb 12 2024, 6:31 AM

ginsu requested review of D11023: [web] cleanup add members modal.

Feb 12 2024, 6:20 AM

ginsu added inline comments to D10944: [web] lift primary button logic from AddMembersModalContent into AddMembersModal.

Feb 12 2024, 6:06 AM

Feb 9 2024

ginsu closed D11014: [web] fix reaction tooltip not showing the correct number of users.

Feb 9 2024, 9:03 PM

ginsu committed rCOMMdc735eeee8c0: [web] fix reaction tooltip not showing the correct number of users.

Feb 9 2024, 9:03 PM

ginsu closed D10999: [native] fix change role modal border radius style.

Feb 9 2024, 8:52 PM

ginsu committed rCOMMee64c3efb470: [native] fix change role modal border radius style.

Feb 9 2024, 8:52 PM

ginsu closed D11002: [native] move transitionPreset into shared navigation options file.

Feb 9 2024, 8:52 PM

ginsu committed rCOMM1fff1eebc97d: [native] move transitionPreset into shared navigation options file.

Feb 9 2024, 8:52 PM

ginsu requested review of D10944: [web] lift primary button logic from AddMembersModalContent into AddMembersModal.

Feb 9 2024, 7:21 PM

ginsu requested review of D10820: [web] introduce previouslySelectedUsers map to add users list.

rerequesting review after discussing with @atul IRL

Feb 9 2024, 6:59 PM

ginsu added inline comments to D11002: [native] move transitionPreset into shared navigation options file.

Feb 9 2024, 6:48 PM

ginsu updated the diff for D10999: [native] fix change role modal border radius style.

rebase with ci fix

Feb 9 2024, 5:00 PM

ginsu updated the diff for D11002: [native] move transitionPreset into shared navigation options file.

rebase with ci fix

Feb 9 2024, 5:00 PM

ginsu requested review of D11014: [web] fix reaction tooltip not showing the correct number of users.

Feb 9 2024, 4:46 PM

Feb 8 2024

ginsu accepted D10995: [lib] Include `specialRole` field in `RoleInfo` for future clients.

few nit stuff inline, feel free to adopt or ignore

Feb 8 2024, 9:11 PM

ginsu requested review of D10999: [native] fix change role modal border radius style.

will make sure ci passes before landing

Feb 8 2024, 8:05 PM

ginsu published D11002: [native] move transitionPreset into shared navigation options file for review.

will make sure ci passes before landing

Feb 8 2024, 8:00 PM

ginsu requested review of D10994: [web] cleanup change member role modal.

will make sure ci passes before landing

Feb 8 2024, 5:45 PM