Page MenuHomePhorge
Feed Search

Feb 27 2024

tomek requested review of D11182: [lib] Add keyserverID to processServerRequestsActionType.
Feb 27 2024, 10:27 AM
tomek requested review of D11181: [lib] Use keyserverID when generating initial message using socket.
Feb 27 2024, 9:53 AM
tomek closed D11177: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.
Feb 27 2024, 9:41 AM
tomek closed D11176: [lib] Add keyserverID param to getClientResponsesSelector.
Feb 27 2024, 9:41 AM
tomek committed rCOMM1d74ee4f6ed5: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.
Feb 27 2024, 9:41 AM
tomek committed rCOMMc34612666172: [lib] Add keyserverID param to getClientResponsesSelector.
Feb 27 2024, 9:41 AM
tomek closed D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 27 2024, 9:41 AM
tomek committed rCOMM62ffb3166fda: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 27 2024, 9:41 AM
tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Rebase

Feb 27 2024, 9:19 AM
tomek accepted D11149: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`.
Feb 27 2024, 8:45 AM
tomek accepted D11148: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`.
Feb 27 2024, 8:44 AM
tomek accepted D11099: [native] Redux migration to patch in `specialRole` field.
Feb 27 2024, 8:43 AM
tomek added a comment to D11177: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.
In D11177#323033, @atul wrote:

Looks good, just want to make sure that this won't break any older clients? I see the following in Test Plan:

Run an older native client and check if it works with new keyserver.

so I'm assuming this table and functionality was never used?

Feb 27 2024, 8:33 AM

Feb 26 2024

tomek requested review of D11177: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.
Feb 26 2024, 4:58 PM
tomek requested review of D11176: [lib] Add keyserverID param to getClientResponsesSelector.
Feb 26 2024, 4:21 PM
tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Tested native migration and deleted web migration - we aren't persisting actualizedCalendarQuery on web
and we don't need to migrate it - default state contains a new value.

Feb 26 2024, 1:51 PM
tomek accepted D11155: [web] use default keyserverStore state if there are no entries in SQLite.
Feb 26 2024, 1:01 PM
tomek accepted D11154: [crypto] implement prekey rotation in `OlmAPI`.
Feb 26 2024, 12:59 PM

Feb 23 2024

tomek accepted D11157: [native] Fix hermes throwing on nonexistant files.
Feb 23 2024, 3:17 PM
tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Fix top-level default keyserver info - the app was crashing because config isn't registered when executing
top-level

Feb 23 2024, 2:10 PM
tomek planned changes to D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 23 2024, 1:51 PM
tomek added inline comments to D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 23 2024, 1:49 PM
tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Update native state type
Use defaultCalendarQuery function in the default keyserver store
Handle actualizedCalendarQuery from an initial state in the reducer

Feb 23 2024, 1:49 PM
tomek accepted D11110: [web] implementing publishing prekeys to Identity.
Feb 23 2024, 12:01 PM
tomek accepted D11146: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat.
Feb 23 2024, 11:50 AM
tomek added inline comments to D11140: [lib] reduce currentUserInfo on identity login/register.
Feb 23 2024, 11:17 AM
tomek added inline comments to D11100: [native] call identity wallet login from ExistingEthereumAccount.
Feb 23 2024, 11:13 AM
tomek added a comment to D11099: [native] Redux migration to patch in `specialRole` field.
In D11099#321944, @atul wrote:

What is the downside of making this diff a draft instead of marking its title with a label?

Would that still make the diff viewable to reviewers?

Feb 23 2024, 11:11 AM

Feb 22 2024

tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Fix tests by introducing a jest mock

Feb 22 2024, 2:35 PM
tomek updated the test plan for D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 22 2024, 2:12 PM
tomek published D11144: [lib] Move actualizedCalendarQuery into keyserver store for review.
Feb 22 2024, 2:08 PM
tomek closed D11135: [lib] Add a keyserverID to an action payload.
Feb 22 2024, 11:08 AM
tomek committed rCOMM2dbf61f82bd9: [lib] Add a keyserverID to an action payload.
Feb 22 2024, 11:08 AM
tomek closed D11133: [lib] Filter out calendar filters that use threads from a different keyserver.
Feb 22 2024, 11:08 AM
tomek committed rCOMMd4354fe394cb: [lib] Filter out calendar filters that use threads from a different keyserver.
Feb 22 2024, 11:08 AM
tomek closed D11130: [lib] Modify update calendar query so that it can update a subset of keyservers.
Feb 22 2024, 11:08 AM
tomek closed D11131: [lib] Add a keyserverID prop to calendar-query-handler.
Feb 22 2024, 11:08 AM
tomek committed rCOMMa113da46cf5b: [lib] Add a keyserverID prop to calendar-query-handler.
Feb 22 2024, 11:08 AM
tomek committed rCOMMe7e0ab0d4326: [lib] Modify update calendar query so that it can update a subset of keyservers.
Feb 22 2024, 11:08 AM
tomek closed D11094: [lib] Make update-handler keyserver-specific.
Feb 22 2024, 11:08 AM
tomek committed rCOMM923b18209893: [lib] Make update-handler keyserver-specific.
Feb 22 2024, 11:08 AM
tomek closed D11092: [lib] Make activity-handler keyserver-specific.
Feb 22 2024, 11:08 AM
tomek committed rCOMM96972d4180cf: [lib] Make activity-handler keyserver-specific.
Feb 22 2024, 11:08 AM
tomek closed D11089: [lib] Make api-request-handler keyserver-specific.
Feb 22 2024, 11:08 AM
tomek committed rCOMMf5e11bdfcd79: [lib] Make api-request-handler keyserver-specific.
Feb 22 2024, 11:08 AM
tomek accepted D11140: [lib] reduce currentUserInfo on identity login/register.
Feb 22 2024, 10:35 AM

Feb 21 2024

tomek closed D11128: [native] Don't dispatch an undefined token.
Feb 21 2024, 4:08 PM
tomek committed rCOMM50d8fe4a69f2: [native] Don't dispatch an undefined token.
Feb 21 2024, 4:08 PM
tomek requested review of D11135: [lib] Add a keyserverID to an action payload.
Feb 21 2024, 3:53 PM
tomek requested review of D11133: [lib] Filter out calendar filters that use threads from a different keyserver.
Feb 21 2024, 3:42 PM
tomek requested review of D11131: [lib] Add a keyserverID prop to calendar-query-handler.
Feb 21 2024, 3:06 PM
tomek requested review of D11130: [lib] Modify update calendar query so that it can update a subset of keyservers.
Feb 21 2024, 2:47 PM
tomek requested review of D11128: [native] Don't dispatch an undefined token.
Feb 21 2024, 12:55 PM
tomek accepted D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().
Feb 21 2024, 12:23 PM
tomek accepted D11120: [lib] implementing handling peer-to-peer messages.
Feb 21 2024, 12:20 PM
tomek accepted D11119: [crypto] implement getting one-time keys in `OlmAPI`.
Feb 21 2024, 12:02 PM
tomek accepted D11112: [crypto] implement creating `olm` inbound session.
Feb 21 2024, 10:58 AM
tomek requested changes to D11110: [web] implementing publishing prekeys to Identity.

I think that keeping the solution as symmetrical as possible is a good idea. In this case, we should probably add it to IdentityServiceClient. If we can expose it also on native, it would be even better. And we should determine why there's an asymmetry of how the keys are uploaded and ideally make it consistent.

Feb 21 2024, 10:56 AM
tomek accepted D11109: [native][web] implementing uploading one-time keys in `IdentityServiceClient`.
Feb 21 2024, 9:57 AM
tomek accepted D11108: [native] implementing getting inbound user keys in `IdentityServiceClient`.
Feb 21 2024, 9:55 AM
tomek accepted D11107: [web] implementing getting inbound user keys in `IdentityServiceClient`.
Feb 21 2024, 9:52 AM
tomek accepted D11106: [crypto] unify key types and introduce type for Inbound Keys.
Feb 21 2024, 9:48 AM
tomek added inline comments to D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 21 2024, 9:41 AM
tomek accepted D11011: [lib] Update genesis.id to use authoritativeKeyserverID.
Feb 21 2024, 9:37 AM
tomek accepted D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 21 2024, 9:34 AM
tomek added inline comments to D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 21 2024, 9:33 AM
tomek accepted D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 21 2024, 9:32 AM
tomek accepted D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 21 2024, 9:30 AM
tomek accepted D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 21 2024, 9:26 AM
tomek accepted D11104: [keyserver][lib] Make updates code aware that ids are strings, not numbers.
Feb 21 2024, 9:03 AM

Feb 20 2024

tomek updated the diff for D11089: [lib] Make api-request-handler keyserver-specific.

Move map to a context

Feb 20 2024, 3:06 PM
tomek accepted D11117: Fix broken clang formatting.
Feb 20 2024, 11:52 AM
tomek accepted D11116: [scripts] Remove flow annotation.
Feb 20 2024, 11:31 AM
tomek accepted D11105: [keyserver] Replace ashoat with admin.
Feb 20 2024, 11:22 AM
tomek accepted D11111: [lib] introduce stateless `olm` API.
Feb 20 2024, 11:10 AM

Feb 19 2024

tomek accepted D11075: [scripts] Create a script for configuring user credentials.
Feb 19 2024, 12:14 PM
tomek requested changes to D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().
Feb 19 2024, 11:49 AM
tomek closed D11102: Add an ESLint rule that check filename format.
Feb 19 2024, 11:25 AM
tomek committed rCOMM139f31894526: Add an ESLint rule that check filename format.
Feb 19 2024, 11:25 AM
tomek accepted D11103: [services] update `Cargo.lock`.
Feb 19 2024, 10:55 AM
tomek updated the diff for D11102: Add an ESLint rule that check filename format.

Rebase

Feb 19 2024, 9:38 AM

Feb 16 2024

tomek added a reviewer for D11102: Add an ESLint rule that check filename format: ashoat.
Feb 16 2024, 1:10 PM
tomek added a comment to D11099: [native] Redux migration to patch in `specialRole` field.

What is the downside of making this diff a draft instead of marking its title with a label?

Feb 16 2024, 10:29 AM
tomek accepted D11097: [native] Reintroduce `updateClientDBThreadStoreThreadInfos`.

Could you link to the code that you're reintroducing?

Feb 16 2024, 10:27 AM
tomek accepted D11095: [native] Reintroduce `createUpdateDBOpsForThreadStoreThreadInfos` for new `RawThreadInfo` encoding.
Feb 16 2024, 10:24 AM
tomek accepted D11100: [native] call identity wallet login from ExistingEthereumAccount.
Feb 16 2024, 10:18 AM
tomek requested review of D11102: Add an ESLint rule that check filename format.
Feb 16 2024, 10:12 AM

Feb 15 2024

tomek requested review of D11094: [lib] Make update-handler keyserver-specific.
Feb 15 2024, 5:56 PM
tomek added a comment to D11088: [keyserver] Log the exception when failing to synchronize links with blobs.

The synchronizeInviteLinksWithBlobs.js filename does not follow conventions in our codebase. We should maintain consistent file naming conventions. @tomek, can you do an audit of the invite links code to make sure we match file naming conventions with the rest of the codebase? Would be great if you could create a task to track

Feb 15 2024, 3:51 PM
tomek requested review of D11092: [lib] Make activity-handler keyserver-specific.
Feb 15 2024, 2:30 PM
tomek requested review of D11089: [lib] Make api-request-handler keyserver-specific.
Feb 15 2024, 12:27 PM
tomek added inline comments to D11075: [scripts] Create a script for configuring user credentials.
Feb 15 2024, 11:43 AM
tomek accepted D11054: [lib] Include KeyserverAuthResult payload for KEYSERVER_AUTH_SUCCESS.

It wasn't intentional. Thanks for fixing it!

Feb 15 2024, 11:36 AM
tomek closed D11088: [keyserver] Log the exception when failing to synchronize links with blobs.
Feb 15 2024, 11:22 AM
tomek committed rCOMMe3478a83cfbb: [keyserver] Log the exception when failing to synchronize links with blobs.
Feb 15 2024, 11:22 AM
tomek requested review of D11088: [keyserver] Log the exception when failing to synchronize links with blobs.
Feb 15 2024, 10:47 AM
tomek added inline comments to D11059: [native] Utilize identity search on native.
Feb 15 2024, 10:47 AM

Feb 14 2024

tomek accepted D11056: [lib] Introduce `patchRawThreadInfosWithSpecialRole()`.
Feb 14 2024, 5:08 PM
tomek accepted D11071: Implement JSI to handle unread count from JS.
Feb 14 2024, 5:04 PM
tomek accepted D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.
Feb 14 2024, 4:55 PM