Page MenuHomePhabricator
Feed All Stories

Dec 5 2024

tomek requested review of D14085: [native] Render SIWE restore panel.
Dec 5 2024, 9:26 AM
tomek requested review of D14084: [native] Create a restore backup screen.
Dec 5 2024, 7:55 AM
tomek updated the summary of D14038: [native] Navigate from the QR screen to the restore screen.
Dec 5 2024, 4:41 AM
tomek updated the diff for D14038: [native] Navigate from the QR screen to the restore screen.

Update the design

Dec 5 2024, 4:40 AM
kamil published D14079: [identity] fix `lastPrimarySignature` attribute for review.
Dec 5 2024, 4:01 AM
tomek updated the summary of D14038: [native] Navigate from the QR screen to the restore screen.
Dec 5 2024, 3:01 AM
tomek updated the summary of D14067: [native] Introduce a password account restore screen.
Dec 5 2024, 2:46 AM
tomek updated the diff for D14067: [native] Introduce a password account restore screen.

Use the registration flow design

Dec 5 2024, 2:45 AM
tomek updated the diff for D14066: [native] Extract the buttons from the logged out modal.

Specify the keys

Dec 5 2024, 1:38 AM

Dec 4 2024

tomek added a comment to D13907: [native] Introduce a restore screen.

A new revision with a couple of changes:

  1. Added a placeholder icon. Will update the diff after https://linear.app/comm/issue/OPS-305/mockup-icon-for-restore-account-screen finalizes the design.
  2. Made sure the margin isn't that big. This issue was caused by the SafeAreaView being rendered twice.
  3. Updated the copy with the text proposed by @ashoat . The first two paragraphs are almost exactly the same - the only difference is the usage of sign. The third paragraph is a little different - I'm not sure but I think that Note that after completing the recovery flow, you will logged out of all of your other devices. was a bit incorrect.
  4. Used the updated PromptButton that follows a design from the registration screen, e.g. in terms of the font.
Dec 4 2024, 9:53 AM
tomek updated the summary of D13907: [native] Introduce a restore screen.
Dec 4 2024, 9:48 AM
tomek updated the diff for D13907: [native] Introduce a restore screen.

Update the design

Dec 4 2024, 9:47 AM
tomek added inline comments to D14064: [native] Make QR screen style consistent with the registration flow.
Dec 4 2024, 9:16 AM
tomek updated the diff for D14064: [native] Make QR screen style consistent with the registration flow.

Don't specify the safe area twice

Dec 4 2024, 9:16 AM
ashoat accepted D14078: [native] Memoize logOutOptions.
Dec 4 2024, 8:54 AM
bartek published D14078: [native] Memoize logOutOptions for review.
Dec 4 2024, 8:09 AM
tomek added inline comments to D14066: [native] Extract the buttons from the logged out modal.
Dec 4 2024, 7:26 AM
tomek requested review of D14066: [native] Extract the buttons from the logged out modal.
Dec 4 2024, 7:23 AM
tomek added inline comments to D14066: [native] Extract the buttons from the logged out modal.
Dec 4 2024, 7:23 AM
tomek updated the summary of D14066: [native] Extract the buttons from the logged out modal.
Dec 4 2024, 7:21 AM
tomek updated the diff for D14066: [native] Extract the buttons from the logged out modal.

Use the primary button

Dec 4 2024, 7:19 AM
tomek updated the summary of D14064: [native] Make QR screen style consistent with the registration flow.
Dec 4 2024, 6:16 AM
tomek requested review of D14064: [native] Make QR screen style consistent with the registration flow.
Dec 4 2024, 6:15 AM
tomek updated the summary of D14064: [native] Make QR screen style consistent with the registration flow.
Dec 4 2024, 6:15 AM
tomek updated the diff for D14064: [native] Make QR screen style consistent with the registration flow.

Update the design

Dec 4 2024, 6:14 AM
kamil accepted D14076: [identity] Update V1 logout to handle new flow users.
Dec 4 2024, 4:49 AM
kamil accepted D14075: [identity] Return use_v1_flow in new-flow-only RPCs.
Dec 4 2024, 4:39 AM
kamil closed D14077: [native] remove comment from `BackupHandler`.
Dec 4 2024, 4:38 AM
kamil committed rCOMM066e576587e0: [native] remove comment from `BackupHandler` (authored by kamil).
[native] remove comment from `BackupHandler`
Dec 4 2024, 4:38 AM
kamil accepted D14074: [identity] Return use_new_flow in V1 login RPCs.
Dec 4 2024, 1:34 AM
kamil accepted D14073: [identity] Add function to check user login flow.
Dec 4 2024, 1:32 AM
kamil accepted D14072: [identity] Add function to check if user has backup.
Dec 4 2024, 1:28 AM

Dec 3 2024

bartek published D14076: [identity] Update V1 logout to handle new flow users for review.
Dec 3 2024, 9:53 AM
bartek accepted D14077: [native] remove comment from `BackupHandler`.
Dec 3 2024, 9:47 AM
bartek published D14075: [identity] Return use_v1_flow in new-flow-only RPCs for review.
Dec 3 2024, 9:47 AM
bartek published D14074: [identity] Return use_new_flow in V1 login RPCs for review.
Dec 3 2024, 9:47 AM
tomek added a comment to D14067: [native] Introduce a password account restore screen.

The design here doesn't look great to me... it feels like we're taking the "design language" of LoggedOutModal and applying it in a place where we're mostly using the RegistrationNavigator "design language".

Can we instead try to base the design on RegistrationNavigator? I think we can keep the general structure here (one username field, one password field, and a button), but instead:

  1. Look at UsernameSelection to get an idea of how to style the username input field.
  2. Look at PasswordSelection to get an idea of how to style the password input field.
  3. Use PrimaryButton for the sign-in button.

If we do this, then after launching signed device lists we can probably totally deprecate LogInPanel. What do you think?

Dec 3 2024, 8:39 AM
kamil published D14077: [native] remove comment from `BackupHandler` for review.
Dec 3 2024, 6:34 AM
kamil closed D14065: [native] regenerate backup on every password change.
Dec 3 2024, 6:28 AM
kamil committed rCOMM863c17c11b6c: [native] regenerate backup on every password change (authored by kamil).
[native] regenerate backup on every password change
Dec 3 2024, 6:28 AM
kamil closed D14062: [web] remove password change feature.
Dec 3 2024, 6:28 AM
kamil closed D14063: [native] allow password change only on primary device.
Dec 3 2024, 6:28 AM
kamil committed rCOMMff76ebb3f095: [web] remove password change feature (authored by kamil).
[web] remove password change feature
Dec 3 2024, 6:28 AM
kamil committed rCOMM99f4e4a6ccef: [native] allow password change only on primary device (authored by kamil).
[native] allow password change only on primary device
Dec 3 2024, 6:28 AM
kamil closed D14061: [native] handle invalid CSAT in Backup authenticated API.
Dec 3 2024, 6:28 AM
kamil committed rCOMM12c361f274a5: [native] handle invalid CSAT in Backup authenticated API (authored by kamil).
[native] handle invalid CSAT in Backup authenticated API
Dec 3 2024, 6:28 AM
kamil closed D14060: [native] add handler for staff to attempt backup restore.
Dec 3 2024, 6:28 AM
kamil committed rCOMM618bdb01cda6: [native] add handler for staff to attempt backup restore (authored by kamil).
[native] add handler for staff to attempt backup restore
Dec 3 2024, 6:28 AM
kamil closed D14056: [native] enable backup handler for staff.
Dec 3 2024, 6:28 AM
kamil closed D14059: [native] upload User Keys backup when user is staff.
Dec 3 2024, 6:28 AM
kamil committed rCOMM9778c7490289: [native] enable backup handler for staff (authored by kamil).
[native] enable backup handler for staff
Dec 3 2024, 6:28 AM
kamil committed rCOMM6340aabf2ad2: [native] upload User Keys backup when user is staff (authored by kamil).
[native] upload User Keys backup when user is staff
Dec 3 2024, 6:28 AM
kamil closed D14050: [lib][native] create action to set latest `backupID` on User Keys upload.
Dec 3 2024, 6:28 AM
kamil committed rCOMMaac38bd895c8: [lib][native] create action to set latest `backupID` on User Keys upload (authored by kamil).
[lib][native] create action to set latest `backupID` on User Keys upload
Dec 3 2024, 6:28 AM
kamil closed D14049: [lib][web][native] Redux store to persist latest backup info.
Dec 3 2024, 6:28 AM
kamil closed D14048: [CommCoreModule] deprecate `computeBackupKey`.
Dec 3 2024, 6:28 AM
kamil committed rCOMMa4bd9d515d2a: [lib][web][native] Redux store to persist latest backup info (authored by kamil).
[lib][web][native] Redux store to persist latest backup info
Dec 3 2024, 6:28 AM
kamil committed rCOMM60ab6d1f5f4d: [CommCoreModule] deprecate `computeBackupKey` (authored by kamil).
[CommCoreModule] deprecate `computeBackupKey`
Dec 3 2024, 6:28 AM
kamil closed D14047: [native] make it possible to test signing using Olm Account from User Keys.
Dec 3 2024, 6:28 AM
kamil committed rCOMMc93bd7a55df0: [native] make it possible to test signing using Olm Account from User Keys (authored by kamil).
[native] make it possible to test signing using Olm Account from User Keys
Dec 3 2024, 6:28 AM
kamil closed D14046: [CommCoreModule] sign message with custom Olm Account.
Dec 3 2024, 6:28 AM
kamil closed D14045: [CryptoModule] remove `CryptoAccountID`.
Dec 3 2024, 6:28 AM
kamil committed rCOMM45130c2f0341: [CommCoreModule] sign message with custom Olm Account (authored by kamil).
[CommCoreModule] sign message with custom Olm Account
Dec 3 2024, 6:28 AM
kamil committed rCOMMa40a133a87b5: [CryptoModule] remove `CryptoAccountID` (authored by kamil).
[CryptoModule] remove `CryptoAccountID`
Dec 3 2024, 6:28 AM
kamil closed D14044: [CryptoModule] store only pickled Olm Account in User Keys Backup.
Dec 3 2024, 6:28 AM
kamil closed D14005: [CommCoreModule][native] expose getting User Keys.
Dec 3 2024, 6:28 AM
kamil committed rCOMM0f805007b641: [CryptoModule] store only pickled Olm Account in User Keys Backup (authored by kamil).
[CryptoModule] store only pickled Olm Account in User Keys Backup
Dec 3 2024, 6:28 AM
kamil committed rCOMMb2bdaac880f7: [CommCoreModule][native] expose getting User Keys (authored by kamil).
[CommCoreModule][native] expose getting User Keys
Dec 3 2024, 6:28 AM
kamil closed D14004: [backup-client][native] refactor restoring logic and deprecate `restoreBackup`.
Dec 3 2024, 6:28 AM
kamil committed rCOMMfcfa8331011f: [backup-client][native] refactor restoring logic and deprecate `restoreBackup` (authored by kamil).
[backup-client][native] refactor restoring logic and deprecate `restoreBackup`
Dec 3 2024, 6:28 AM
kamil closed D14003: [native] remove `BackupKeys` and use `QRAuthBackupData`.
Dec 3 2024, 6:28 AM
kamil closed D14002: [CommCoreModule] avoid calling Backup Service to get backup secrets.
Dec 3 2024, 6:28 AM
kamil committed rCOMM9518c5eb72a4: [native] remove `BackupKeys` and use `QRAuthBackupData` (authored by kamil).
[native] remove `BackupKeys` and use `QRAuthBackupData`
Dec 3 2024, 6:28 AM
kamil committed rCOMMf209543987d5: [CommCoreModule] avoid calling Backup Service to get backup secrets (authored by kamil).
[CommCoreModule] avoid calling Backup Service to get backup secrets
Dec 3 2024, 6:28 AM
kamil closed D14001: [backup-client] set `backupID` after uploading User Keys.
Dec 3 2024, 6:28 AM
kamil committed rCOMM80e355759ad2: [backup-client] set `backupID` after uploading User Keys (authored by kamil).
[backup-client] set `backupID` after uploading User Keys
Dec 3 2024, 6:28 AM
kamil updated the diff for D14065: [native] regenerate backup on every password change.

rebase before landing v2

Dec 3 2024, 5:31 AM
kamil updated the diff for D14062: [web] remove password change feature.

rebase

Dec 3 2024, 5:30 AM
tomek closed D13946: [native] Update the QR login screen to mention the primary device.
Dec 3 2024, 5:20 AM
tomek closed D14052: [native] Move QR and sign-in files around.
Dec 3 2024, 5:20 AM
tomek committed rCOMM31912d3b3ebe: [native] Update the QR login screen to mention the primary device (authored by tomek).
[native] Update the QR login screen to mention the primary device
Dec 3 2024, 5:20 AM
tomek committed rCOMMd495f2356014: [native] Move QR and sign-in files around (authored by tomek).
[native] Move QR and sign-in files around
Dec 3 2024, 5:20 AM
tomek closed D14051: [native] Rename the QR sign-in navigator.
Dec 3 2024, 5:20 AM
tomek committed rCOMM39eccd8276bd: [native] Rename the QR sign-in navigator (authored by tomek).
[native] Rename the QR sign-in navigator
Dec 3 2024, 5:20 AM
Harbormaster failed remote builds in B32920: Diff 46181 for D14065: [native] regenerate backup on every password change!
Dec 3 2024, 4:38 AM
kamil accepted D14071: [identity] Remove outdated comment from constants.
Dec 3 2024, 4:26 AM
kamil updated the diff for D14065: [native] regenerate backup on every password change.

rebase before landing

Dec 3 2024, 4:24 AM
kamil updated the diff for D14060: [native] add handler for staff to attempt backup restore.

address notes

Dec 3 2024, 4:22 AM
kamil updated the diff for D14059: [native] upload User Keys backup when user is staff.
  • rebase
  • use useStaffAlert
Dec 3 2024, 4:17 AM
kamil updated the diff for D14056: [native] enable backup handler for staff.

use useStaffAlert

Dec 3 2024, 4:08 AM
kamil updated the diff for D14050: [lib][native] create action to set latest `backupID` on User Keys upload.

make reducer pure

Dec 3 2024, 4:07 AM
kamil updated the diff for D14049: [lib][web][native] Redux store to persist latest backup info.
  • fix typo
  • remove migration
  • make prop read-only
Dec 3 2024, 4:06 AM
bartek published D14073: [identity] Add function to check user login flow for review.
Dec 3 2024, 3:58 AM
bartek published D14072: [identity] Add function to check if user has backup for review.
Dec 3 2024, 3:55 AM
bartek published D14071: [identity] Remove outdated comment from constants for review.
Dec 3 2024, 3:51 AM
kamil added inline comments to D14050: [lib][native] create action to set latest `backupID` on User Keys upload.
Dec 3 2024, 3:50 AM
bartek accepted D14065: [native] regenerate backup on every password change.
Dec 3 2024, 12:29 AM

Dec 2 2024

varun closed D14070: [terraform] identity 0.46 staging deployment.
Dec 2 2024, 7:17 PM
varun committed rCOMM8a57c1cde452: [terraform] identity 0.46 staging deployment (authored by varun).
[terraform] identity 0.46 staging deployment
Dec 2 2024, 7:17 PM
ashoat accepted D14070: [terraform] identity 0.46 staging deployment.
Dec 2 2024, 4:35 PM