In D14079#392809, @kamil wrote:In D14079#392786, @ashoat wrote:How serious is this issue? Wondering what the product impact was, if any
I think there wasn't any product impact, the first time we used this was during restore protocol, and I added it later in this stack (D14083), I don't think any existing logic depends on this, but perhaps @bartek has a better view on this.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Dec 9 2024
Dec 9 2024
will added inline comments to D13985: [keyserver/lib] Change frame image from hello world to channel image.
will added inline comments to D13985: [keyserver/lib] Change frame image from hello world to channel image.
In D14079#392786, @ashoat wrote:How serious is this issue? Wondering what the product impact was, if any
Dec 8 2024
Dec 8 2024
ashoat added inline comments to D13985: [keyserver/lib] Change frame image from hello world to channel image.
Dec 7 2024
Dec 7 2024
I think the consistency is improved, but three notes:
ashoat added a comment to D14064: [native] Make QR screen style consistent with the registration flow.
One other thing is that it would be good to have bullet points for the three lines of instructions for finding the scanner.
ashoat added a comment to D14064: [native] Make QR screen style consistent with the registration flow.
I think these two options were the best:
will committed rCOMM379d8575a713: [identity] use identitySearchSocket instead of socket.current (authored by will).
[identity] use identitySearchSocket instead of socket.current
How serious is this issue? Wondering what the product impact was, if any
Dec 6 2024
Dec 6 2024
will committed rCOMMb1a937ba765c: [keyserver] remove duplicate content-type application/json header in call to… (authored by will).
[keyserver] remove duplicate content-type application/json header in call to…
will updated the diff for D13999: [keyserver] use default channel cover image stored on in keyserver/images in frame.
feedback
will added inline comments to D13999: [keyserver] use default channel cover image stored on in keyserver/images in frame.
feedback
will updated the diff for D13985: [keyserver/lib] Change frame image from hello world to channel image.
feedback
feedback
will updated the diff for D13926: [keyserver] add frog, hono, @hono/node-server as keyserver dependencies.
rebase
will updated the summary of D13926: [keyserver] add frog, hono, @hono/node-server as keyserver dependencies.
will updated the summary of D13926: [keyserver] add frog, hono, @hono/node-server as keyserver dependencies.
Delete unused styles
Use the button's loading state
Tested how the alternative approach looks like:
I think it looks OK and we can keep it.
bartek committed rCOMMcedacdf005d4: [identity] Reset device list and services data during password reset (authored by bartek).
[identity] Reset device list and services data during password reset
bartek committed rCOMM312165799170: [identity] Update V1 logout to handle new flow users (authored by bartek).
[identity] Update V1 logout to handle new flow users
bartek committed rCOMMd91394b8f101: [identity] Return use_v1_flow in new-flow-only RPCs (authored by bartek).
[identity] Return use_v1_flow in new-flow-only RPCs
bartek committed rCOMM8944ea4f6bfa: [identity] Add function to check user login flow (authored by bartek).
[identity] Add function to check user login flow
bartek committed rCOMMa8129cf7fd19: [identity] Return use_new_flow in V1 login RPCs (authored by bartek).
[identity] Return use_new_flow in V1 login RPCs
bartek committed rCOMM7877d5b11018: [identity] Remove outdated comment from constants (authored by bartek).
[identity] Remove outdated comment from constants
bartek committed rCOMM88f7830fc53e: [identity] Add function to check if user has backup (authored by bartek).
[identity] Add function to check if user has backup
[native] Memoize logOutOptions
In D14085#392504, @ashoat wrote:Can you explain why you implemented this backdrop approach, instead of the approach we're using in ConnectEthereum?
Rebase
Rebase
Rebase
Add missing changes, apply suggestion
In D14084#392499, @ashoat wrote:Accepting to unblock, but the style of the box looks a bit inconsistent with the design language we're using here.
It's left-aligned, so it's maybe a bit less awkward than the box in D14064. But overall, these boxes with curved borders feel a little out-of-place.
Generally I think this is not perfect and we could create a dedicated backup service endpoint for this which would query directly by user_id and be callable only by other services
bartek updated the summary of D14087: [identity] Reset device list and services data during password reset.
tomek added a reviewer for D14038: [native] Navigate from the QR screen to the restore screen: ashoat.
kamil committed rCOMM115a3a39c385: [terraform] identity 0.47 staging deployment (authored by kamil).
[terraform] identity 0.47 staging deployment
tomek added a comment to D14064: [native] Make QR screen style consistent with the registration flow.
In D14064#392498, @ashoat wrote:It looks weird that we're left-aligning the header and body, but the QR code and the graphic below it are centered. Do you think we can make it more consistent?
In this revision, styles are updated, so leaving this @ashoat for review
kamil committed rCOMM57275f883c1d: [identity] fix `lastPrimarySignature` attribute (authored by kamil).
[identity] fix `lastPrimarySignature` attribute
tomek retitled D13906: [native] Update the logged out modal from [native] Introduce a restore button to [native] Update the logged out modal.
bartek published D14087: [identity] Reset device list and services data during password reset for review.
kamil published D14080: [lib] refactor `useClientBackup` to not use user identifier from the store for review.
Dec 5 2024
Dec 5 2024
will requested review of D14086: [keyserver] setup reverse proxy from keyserver router to frog hono server.
Can you explain why you implemented this backdrop approach, instead of the approach we're using in ConnectEthereum?
Accepting to unblock, but the style of the box looks a bit inconsistent with the design language we're using here.
ashoat added a comment to D14064: [native] Make QR screen style consistent with the registration flow.
It looks weird that we're left-aligning the header and body, but the QR code and the graphic below it are centered. Do you think we can make it more consistent?
Looks great!