Page MenuHomePhabricator
Feed Advanced Search

Dec 5 2023

rohan accepted D10195: [lib] Update `threadInfoFromRawThreadInfo` to return `MinimallyEncodedThreadInfo`.
Dec 5 2023, 8:26 AM
rohan accepted D10150: [keyserver] Introduce a function that allows fetching all the primary links.
Dec 5 2023, 8:24 AM
rohan closed D10172: [lib] Fix pinned messages not working.
Dec 5 2023, 7:46 AM
rohan committed rCOMM63656c7ad703: [lib] Fix pinned messages not working (authored by rohan).
[lib] Fix pinned messages not working
Dec 5 2023, 7:46 AM
rohan accepted D10145: [web] introduce light mode to create/edit role modal.
Dec 5 2023, 7:43 AM

Dec 4 2023

rohan requested review of D10172: [lib] Fix pinned messages not working.
Dec 4 2023, 9:30 PM
rohan accepted D10159: [lib] Get rid of switchMemberAdminRoleInThread.
Dec 4 2023, 7:26 PM
rohan added a comment to D10144: [web] introduce light mode to community creation modal.

I think the selected checkboxes in light mode are really difficult to see personally, but maybe others disagree?

Dec 4 2023, 5:53 AM
rohan requested changes to D10145: [web] introduce light mode to create/edit role modal.

Requesting changes just for a question. The screenshots look fine, but for consistency do we need to add a --link-background-primary-disabled to the light mode variables?

Dec 4 2023, 5:50 AM
rohan accepted D10149: [web] introduce light mode to app directory modal.
Dec 4 2023, 5:45 AM
rohan accepted D10146: [web] introduce light to delete role modal.
Dec 4 2023, 5:44 AM

Dec 1 2023

rohan added inline comments to D10105: [lib] Add optional specialRole field to RoleInfo.
Dec 1 2023, 11:56 AM
rohan accepted D10141: [web] introduce light mode to roles modal.
Dec 1 2023, 11:52 AM
rohan updated the diff for D10115: [native] Update update-roles-and-permissions-test-data.js to include specialRole field.

Use constant for specialRole

Dec 1 2023, 11:51 AM
rohan updated the diff for D10114: [lib] Update thread-ops-utils.test.js to include specialRole field.

Use constant for specialRole

Dec 1 2023, 11:46 AM
rohan updated the diff for D10113: [lib] Update validation.test.js to include specialRole field.

Use constant for specialRole

Dec 1 2023, 11:44 AM
rohan updated the diff for D10112: [lib] Update minimally-encoded-thread-permissions-test-data.js to include specialRole field.

Use constant for specialRole

Dec 1 2023, 11:43 AM
rohan updated the diff for D10111: [lib] Update minimally-encoded-thread-permissions.test.js to include specialRole field.

Use constant for specialRole

Dec 1 2023, 11:42 AM
rohan updated the diff for D10110: [keyserver] Update responder-validators.test.js to include specialRole field.

Use constant for specialRole

Dec 1 2023, 11:40 AM
rohan added inline comments to D10110: [keyserver] Update responder-validators.test.js to include specialRole field.
Dec 1 2023, 9:42 AM
rohan accepted D10133: [lib] `ResolvedThreadInfo` -> `LegacyResolvedThreadInfo`.

Looks like it's only a name change

Dec 1 2023, 7:07 AM
rohan closed D10132: [keyserver] Add special_role column in migration 52.
Dec 1 2023, 6:54 AM
rohan committed rCOMM366695fb3e06: [keyserver] Add special_role column in migration 52 (authored by rohan).
[keyserver] Add special_role column in migration 52
Dec 1 2023, 6:53 AM
rohan published D10132: [keyserver] Add special_role column in migration 52 for review.

Requesting review in case there's anything I need to address since CI is taking some time.

Dec 1 2023, 6:34 AM
rohan accepted D10128: [web] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.
Dec 1 2023, 6:19 AM
rohan accepted D10127: [native] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.

Looks good, just a question inline

Dec 1 2023, 6:17 AM
rohan closed D10100: [native] Use consistent panel colors in QR code screens.
Dec 1 2023, 6:13 AM
rohan committed rCOMMb540065304f7: [native] Use consistent panel colors in QR code screens (authored by rohan).
[native] Use consistent panel colors in QR code screens
Dec 1 2023, 6:12 AM
rohan added inline comments to D10110: [keyserver] Update responder-validators.test.js to include specialRole field.
Dec 1 2023, 6:11 AM
rohan added inline comments to D10116: [lib] Update existing checks on isDefault in thread-utils.js.
Dec 1 2023, 6:07 AM
rohan updated the diff for D10105: [lib] Add optional specialRole field to RoleInfo.

Use more specific type for specialRole field

Dec 1 2023, 6:04 AM

Nov 30 2023

rohan planned changes to D10105: [lib] Add optional specialRole field to RoleInfo.
Nov 30 2023, 1:58 PM
rohan accepted D10103: [web] introduce light mode to view invite link modal.
Nov 30 2023, 1:37 PM
rohan accepted D10101: [web] introduce light mode to manage invite link modal.
Nov 30 2023, 1:37 PM
rohan published D10119: [web] Update existing checks on isDefault in role-actions-menu.reactjs for review.
Nov 30 2023, 1:34 PM
rohan published D10118: [native] Update existing checks on isDefault in role-panel-entry.react.js for review.
Nov 30 2023, 1:34 PM
rohan published D10117: [keyserver] Update existing checks on isDefault in invite-link-creator.js for review.
Nov 30 2023, 1:34 PM
rohan published D10116: [lib] Update existing checks on isDefault in thread-utils.js for review.
Nov 30 2023, 1:34 PM
rohan published D10115: [native] Update update-roles-and-permissions-test-data.js to include specialRole field for review.
Nov 30 2023, 1:33 PM
rohan published D10114: [lib] Update thread-ops-utils.test.js to include specialRole field for review.
Nov 30 2023, 1:33 PM
rohan published D10113: [lib] Update validation.test.js to include specialRole field for review.
Nov 30 2023, 1:33 PM
rohan published D10112: [lib] Update minimally-encoded-thread-permissions-test-data.js to include specialRole field for review.
Nov 30 2023, 1:33 PM
rohan published D10111: [lib] Update minimally-encoded-thread-permissions.test.js to include specialRole field for review.
Nov 30 2023, 1:33 PM
rohan published D10110: [keyserver] Update responder-validators.test.js to include specialRole field for review.
Nov 30 2023, 1:33 PM
rohan published D10109: [lib] Update thread-utils to include specialRole field for review.
Nov 30 2023, 1:33 PM
rohan published D10108: [keyserver] Update role-creator to include specialRole field for review.
Nov 30 2023, 1:33 PM
rohan published D10107: [keyserver] Update `fetchServerThreadInfos(filter?: FetchThreadInfosFilter)` to fetch special_role for review.
Nov 30 2023, 1:33 PM
rohan published D10106: [keyserver] Update `fetchRoles(threadID: string)` to fetch special_role for review.
Nov 30 2023, 1:33 PM
rohan published D10105: [lib] Add optional specialRole field to RoleInfo for review.
Nov 30 2023, 1:32 PM
rohan requested review of D10100: [native] Use consistent panel colors in QR code screens.
Nov 30 2023, 8:50 AM
rohan accepted D10099: [keyserver] Introduce a util function that generates invite link blob hash.
Nov 30 2023, 8:41 AM
rohan accepted D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.
Nov 30 2023, 8:40 AM

Nov 29 2023

rohan resigned from D10094: [web] implement onClickAddKeyserver callback.
Nov 29 2023, 6:20 PM
rohan accepted D10094: [web] implement onClickAddKeyserver callback.

Looks good to me. Would be nice if someone else can take a look at the newKeyserverInfo though since I'm not really familiar with what the default values should be

Nov 29 2023, 6:20 PM
rohan accepted D10093: [web] save the recently deleted server url to customServer redux state.
Nov 29 2023, 6:18 PM
rohan accepted D10079: [web] update the keyserver selection modal based on the connection status.
Nov 29 2023, 6:18 PM
rohan closed D10076: [keyserver] Run migration to populate special_role column for Admins.
Nov 29 2023, 6:06 PM
rohan committed rCOMM11ae2a8c39ac: [keyserver] Run migration to populate special_role column for Admins (authored by rohan).
[keyserver] Run migration to populate special_role column for Admins
Nov 29 2023, 6:06 PM
rohan closed D10075: [lib] Introduce a special role for Admins.
Nov 29 2023, 6:06 PM
rohan committed rCOMMa011993dc8a0: [lib] Introduce a special role for Admins (authored by rohan).
[lib] Introduce a special role for Admins
Nov 29 2023, 6:06 PM
rohan closed D9885: [lib] Detect a valid ENS name in search experiences.
Nov 29 2023, 6:02 PM
rohan closed D9884: [web/native] Use useSearchUsers for the friends list.
Nov 29 2023, 6:02 PM
rohan committed rCOMMd87df9dd068e: [web/native] Use useSearchUsers for the friends list (authored by rohan).
[web/native] Use useSearchUsers for the friends list
Nov 29 2023, 6:02 PM
rohan committed rCOMM87830f574812: [lib] Detect a valid ENS name in search experiences (authored by rohan).
[lib] Detect a valid ENS name in search experiences
Nov 29 2023, 6:02 PM
rohan closed D9883: [lib] Define a function that detects when an ENS name is typed.
Nov 29 2023, 6:02 PM
rohan committed rCOMMbde3c9cb9049: [lib] Define a function that detects when an ENS name is typed (authored by rohan).
[lib] Define a function that detects when an ENS name is typed
Nov 29 2023, 6:02 PM
rohan added a comment to D9885: [lib] Detect a valid ENS name in search experiences.
In D9885#293489, @ginsu wrote:

This is probs outside the scope of this diff, but I wonder if we should add some debouncing in useForwardLookupSearchText (or somewhere else better in the search logic) so that we are making calls to the server immediately every time text input is changed

Nov 29 2023, 5:05 PM
rohan added inline comments to D10079: [web] update the keyserver selection modal based on the connection status.
Nov 29 2023, 4:14 AM
rohan resigned from D10092: [lib/native/web] lift customServer redux state into lib.
Nov 29 2023, 4:09 AM
rohan accepted D10092: [lib/native/web] lift customServer redux state into lib.

Looks good to me - just would prefer if someone else could take a look though regarding the redux setup

Nov 29 2023, 4:09 AM
rohan accepted D10090: [lib/native] lift set custom server action type into lib.
Nov 29 2023, 4:07 AM
rohan accepted D10089: [web] introduce on click remove keyserver functionality.
Nov 29 2023, 4:05 AM
rohan accepted D10081: [web] introduce confirmation alert component.

Thanks for doing this! Could you share a screenshot for what the delete roles modal looks like now please?

Nov 29 2023, 3:59 AM
rohan accepted D10080: [web] introduce temp onClickDisconnectKeyserver.
Nov 29 2023, 3:50 AM

Nov 28 2023

rohan added inline comments to D9916: [web] introduce add keyserver modal.
Nov 28 2023, 4:21 PM
rohan accepted D9916: [web] introduce add keyserver modal.

Accepting since the code looks good (and colors look consistent)!

Nov 28 2023, 4:20 PM
rohan requested review of D10076: [keyserver] Run migration to populate special_role column for Admins.
Nov 28 2023, 11:55 AM
rohan requested review of D10075: [lib] Introduce a special role for Admins.
Nov 28 2023, 10:59 AM
rohan updated the diff for D9885: [lib] Detect a valid ENS name in search experiences.

Attempt rebase after Flow stack

Nov 28 2023, 8:45 AM
rohan updated the diff for D9884: [web/native] Use useSearchUsers for the friends list.

Attempt rebase after Flow stack

Nov 28 2023, 8:42 AM

Nov 27 2023

rohan closed D9982: [keyserver] Drop the default_role column from threads.
Nov 27 2023, 10:36 AM
rohan committed rCOMM33c67f896a0d: [keyserver] Drop the default_role column from threads (authored by rohan).
[keyserver] Drop the default_role column from threads
Nov 27 2023, 10:36 AM
rohan closed D9981: [keyserver] Update usage of threads.default_role in thread-creator.js.
Nov 27 2023, 10:36 AM
rohan closed D9980: [keyserver] Update usage of threads.default_role in thread-fetchers.js.
Nov 27 2023, 10:36 AM
rohan closed D9979: [keyserver] Update usage of threads.default_role in thread-permission-updaters.js.
Nov 27 2023, 10:36 AM
rohan committed rCOMM6f6bf02f683d: [keyserver] Update usage of threads.default_role in thread-creator.js (authored by rohan).
[keyserver] Update usage of threads.default_role in thread-creator.js
Nov 27 2023, 10:36 AM
rohan committed rCOMM885c505d6759: [keyserver] Update usage of threads.default_role in thread-permission-updaters. (authored by rohan).
[keyserver] Update usage of threads.default_role in thread-permission-updaters.
Nov 27 2023, 10:36 AM
rohan committed rCOMM72efa94f5c70: [keyserver] Update usage of threads.default_role in thread-fetchers.js (authored by rohan).
[keyserver] Update usage of threads.default_role in thread-fetchers.js
Nov 27 2023, 10:36 AM
rohan closed D9978: [keyserver] Update usage of threads.default_role in validate-role-permissions.js.
Nov 27 2023, 10:36 AM
rohan closed D9977: [keyserver] Update usage of threads.default_role in thread-updaters.js.
Nov 27 2023, 10:36 AM
rohan closed D9976: [keyserver] Update usage of threads.default_role in role-fetchers.js.
Nov 27 2023, 10:36 AM
rohan committed rCOMM89c9f7376830: [keyserver] Update usage of threads.default_role in validate-role-permissions.js (authored by rohan).
[keyserver] Update usage of threads.default_role in validate-role-permissions.js
Nov 27 2023, 10:36 AM
rohan committed rCOMMe83074e9bf06: [keyserver] Update usage of threads.default_role in thread-updaters.js (authored by rohan).
[keyserver] Update usage of threads.default_role in thread-updaters.js
Nov 27 2023, 10:36 AM
rohan committed rCOMMa6d08459bd31: [keyserver] Update usage of threads.default_role in role-fetchers.js (authored by rohan).
[keyserver] Update usage of threads.default_role in role-fetchers.js
Nov 27 2023, 10:36 AM
rohan closed D9975: [keyserver] Update usage of threads.default_role in role-deleters.js.
Nov 27 2023, 10:36 AM
rohan closed D9974: [keyserver/lib] Populate special_role field when initial roles are created.
Nov 27 2023, 10:36 AM
rohan committed rCOMMfc278672de72: [keyserver] Update usage of threads.default_role in role-deleters.js (authored by rohan).
[keyserver] Update usage of threads.default_role in role-deleters.js
Nov 27 2023, 10:36 AM
rohan committed rCOMM4948dcde64ba: [keyserver/lib] Populate special_role field when initial roles are created (authored by rohan).
[keyserver/lib] Populate special_role field when initial roles are created
Nov 27 2023, 10:36 AM
rohan closed D9961: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB.
Nov 27 2023, 10:36 AM
rohan committed rCOMM15c203dd660f: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB (authored by rohan).
[keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB
Nov 27 2023, 10:35 AM