- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 5 2023
Dec 4 2023
I think the selected checkboxes in light mode are really difficult to see personally, but maybe others disagree?
Requesting changes just for a question. The screenshots look fine, but for consistency do we need to add a --link-background-primary-disabled to the light mode variables?
Dec 1 2023
Use constant for specialRole
Use constant for specialRole
Use constant for specialRole
Use constant for specialRole
Use constant for specialRole
Use constant for specialRole
Looks like it's only a name change
Requesting review in case there's anything I need to address since CI is taking some time.
Looks good, just a question inline
Use more specific type for specialRole field
Nov 30 2023
Nov 29 2023
Looks good to me. Would be nice if someone else can take a look at the newKeyserverInfo though since I'm not really familiar with what the default values should be
In D9885#293489, @ginsu wrote:This is probs outside the scope of this diff, but I wonder if we should add some debouncing in useForwardLookupSearchText (or somewhere else better in the search logic) so that we are making calls to the server immediately every time text input is changed
Looks good to me - just would prefer if someone else could take a look though regarding the redux setup
Thanks for doing this! Could you share a screenshot for what the delete roles modal looks like now please?
Nov 28 2023
Accepting since the code looks good (and colors look consistent)!
Attempt rebase after Flow stack
Attempt rebase after Flow stack