- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 10 2024
Apr 10 2024
Apr 9 2024
Apr 9 2024
atul requested review of D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.
atul requested review of D11603: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.
atul requested review of D11602: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`.
atul committed rCOMMbff93822188e: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests (authored by atul).
[lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests
atul added inline comments to D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.
atul updated the diff for D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.
make RelationshipRequest and FarcasterRelationshipRequest readonly
atul added inline comments to D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.
atul committed rCOMM0ea301c36f48: [lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster` (authored by atul).
[lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster`
atul updated the diff for D11592: [lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster`.
land
atul planned changes to D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.
read only
Apr 8 2024
Apr 8 2024
atul published D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests for review.
atul requested review of D11592: [lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster`.
Looks good, thanks for adding unit tests... definitely improves confidence in changes
Would be good to include both create_schema and migration flow in Test Plan
atul committed rCOMM88077c9da4b0: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo` (authored by atul).
[lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`
atul updated the diff for D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.
land
Apr 5 2024
Apr 5 2024
atul updated the diff for D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.
address feedback + land
atul committed rCOMM444cce2542c3: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts` (authored by atul).
[lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`
atul updated the diff for D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`.
address feedback
Apr 4 2024
Apr 4 2024
atul committed rCOMM66a4e39bb7bf: [lib] Fix `UpdateRelationshipMessageSpec.validator` (authored by atul).
[lib] Fix `UpdateRelationshipMessageSpec.validator`
atul committed rCOMMc9b68963398a: [lib] Update `rawMessageInfoFromClientDB` to support… (authored by atul).
[lib] Update `rawMessageInfoFromClientDB` to support…
atul committed rCOMM99c020412fb6: [lib] Partially update `UpdateRelationshipMessageSpec` to support updated… (authored by atul).
[lib] Partially update `UpdateRelationshipMessageSpec` to support updated…
atul committed rCOMM6c7bca7377b6: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship` (authored by atul).
[lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`
atul committed rCOMMc3e31c9faffb: [lib] Update union types in `message-types` to include `UpdateRelationship`… (authored by atul).
[lib] Update union types in `message-types` to include `UpdateRelationship`…
land
atul updated the diff for D11455: [lib] Update `rawMessageInfoFromClientDB` to support `RawUpdateRelationshipMessageInfo`.
land
atul updated the diff for D11452: [lib] Partially update `UpdateRelationshipMessageSpec` to support updated `UpdateRelationship` message type.
land
atul updated the diff for D11443: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`.
land
atul updated the diff for D11439: [lib] Update union types in `message-types` to include `UpdateRelationship` types.
land
atul committed rCOMM27b1b15230d2: [lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP` (authored by atul).
[lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP`
atul retitled D11545: [web/native/lib] Use message pruner on web from [web/native/lib] Use message prunner on web to [web/native/lib] Use message pruner on web.
Back to your queue to replace .map with either for-of loop or forEach
land
Rather than rebasing and updating stack, it should be fine to land as-is and make modifications in follow-up diffs since this message type is not yet available to prod clients.
Apr 3 2024
Apr 3 2024
just rebase
atul committed rCOMM400d44d483a7: [lib] Add "Legacy" to types in `update-relationship` (authored by atul).
[lib] Add "Legacy" to types in `update-relationship`
Apr 2 2024
Apr 2 2024
land
[native] Turn migration 64 into noop
Apr 1 2024
Apr 1 2024
add explanation
Did not read through createOperations super carefully, so please double check that everything seems correct there.
This looks correct, but would be great to have more thorough Test Plan. The aux-user-queries.tests are great though!
Actually will accept, but please go through create_schema flow. Should be as easy as installing on new Simulator target
Can we update the test plan to include the create_schema scenario as well.
Looks fine outside of copy being signed off on
Thanks for catching and resolving this.
Mar 29 2024
Mar 29 2024
atul committed rCOMM2d22d1e42168: [GH Actions] Include `actions/setup-python` action when using `pip` (authored by atul).
[GH Actions] Include `actions/setup-python` action when using `pip`
atul published D11478: [GH Actions] Include `actions/setup-python` action when using `pip` for review.