Page MenuHomePhorge
Feed All Stories

Mar 11 2023

ashoat closed D7026: [keyserver][web] Add types for @matrix-org/olm.
Mar 11 2023, 6:50 PM
ashoat committed rCOMMeb898443e91e: [keyserver][web] Add types for @matrix-org/olm.
Mar 11 2023, 6:50 PM
ashoat committed rCOMM5426f346f672: [web] Introduce Jest tests for Olm.
Mar 11 2023, 6:50 PM
ashoat closed D7038: Update Olm.
Mar 11 2023, 6:50 PM
ashoat committed rCOMM7c2dcceb55b3: Update Olm.
Mar 11 2023, 6:49 PM
atul added inline comments to D7034: [lib] Modify `getClientResponsesSelector` to return `Promise`.
Mar 11 2023, 6:38 PM
atul accepted D7038: Update Olm.
Mar 11 2023, 6:33 PM
atul accepted D7026: [keyserver][web] Add types for @matrix-org/olm.
Mar 11 2023, 6:32 PM
ashoat accepted D7037: [web] Pull `signedIdentityKeysBlobSelector` out of `getSignedIdentityKeysBlobSelector`.
Mar 11 2023, 2:12 PM
ashoat accepted D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.
Mar 11 2023, 1:32 PM
ashoat accepted D7035: [native] Implement `getSignedIdentityKeysBlob(...)` for `native`.
Mar 11 2023, 1:26 PM
ashoat accepted D7034: [lib] Modify `getClientResponsesSelector` to return `Promise`.
Mar 11 2023, 1:25 PM
ashoat requested review of D7038: Update Olm.
Mar 11 2023, 1:23 PM
ashoat updated the diff for D7026: [keyserver][web] Add types for @matrix-org/olm.

Update to 3.2.14; respond to review

Mar 11 2023, 1:17 PM
atul published D7037: [web] Pull `signedIdentityKeysBlobSelector` out of `getSignedIdentityKeysBlobSelector` for review.
Mar 11 2023, 2:24 AM
atul published D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)` for review.
Mar 11 2023, 1:33 AM
atul published D7035: [native] Implement `getSignedIdentityKeysBlob(...)` for `native` for review.
Mar 11 2023, 12:58 AM
atul published D7034: [lib] Modify `getClientResponsesSelector` to return `Promise` for review.
Mar 11 2023, 12:57 AM

Mar 10 2023

atul requested changes to D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.

Are we still waiting on D6924 before the rest of the stack is ready for review? Back to your queue for now, feel free to re-request review as-is if I should be reviewing it.

Mar 10 2023, 11:43 PM
atul requested changes to D6929: [keyserver] Add a function to toggle the pin status of a message.

Are we still waiting on D6924 before the rest of the stack is ready for review? Back to your queue for now, feel free to re-request review as-is if I should be reviewing it.

Mar 10 2023, 11:42 PM
atul requested changes to D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.

I'm going to wait until the architecture of pinned_messages is decided in D6924 before requesting review, I just put this up so I could continue working locally.

Mar 10 2023, 11:40 PM
atul accepted D7024: [web] Implement AES encryption functions.

Unit tests will be added in next diff.

Mar 10 2023, 11:29 PM
atul accepted D7008: [native][AES] Implement decrypt function on Android.
Mar 10 2023, 11:06 PM
atul accepted D7007: [native][AES] Implement encrypt function on Android.

Accepting since a lot of the feedback was captured in the iOS diffs.

Mar 10 2023, 10:22 PM
ashoat closed D7033: [keyserver] Give all members permissions to add users to a community.
Mar 10 2023, 9:44 PM
ashoat committed rCOMM8f882233d549: [keyserver] Give all members permissions to add users to a community.
Mar 10 2023, 9:44 PM
ginsu accepted D7033: [keyserver] Give all members permissions to add users to a community.
Mar 10 2023, 9:38 PM
atul accepted D7033: [keyserver] Give all members permissions to add users to a community.
Mar 10 2023, 9:33 PM
ashoat added inline comments to D7026: [keyserver][web] Add types for @matrix-org/olm.
Mar 10 2023, 9:26 PM
atul closed D7021: [keyserver] Use `build:debug` instead of `build` in `postinstall`.
Mar 10 2023, 9:09 PM
atul committed rCOMMf3b0df3af4e1: [keyserver] Use `build:debug` instead of `build` in `postinstall`.
Mar 10 2023, 9:09 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 10 2023, 8:56 PM
atul updated the diff for D7021: [keyserver] Use `build:debug` instead of `build` in `postinstall`.

rebase and land

Mar 10 2023, 8:49 PM
ashoat requested review of D7033: [keyserver] Give all members permissions to add users to a community.
Mar 10 2023, 8:31 PM
varun added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 10 2023, 8:21 PM
ashoat added a comment to D7020: [comm-opaque] Add dependencies for client and server logic.

I agree with @varun

Mar 10 2023, 8:09 PM
atul added inline comments to D7005: [native][AES] Implement encrypt function on iOS.
Mar 10 2023, 7:40 PM
atul added a comment to D7020: [comm-opaque] Add dependencies for client and server logic.
In D7020#208568, @varun wrote:

i frankly don't think this adds much clutter at all... also it's more tedious for me to switch between diffs to see how these dependencies are being used. just looking at this diff, i have no idea what any of these dependencies are for besides the one that @jon annotated, and even then i still have to look at another diff to see what handle_pake_to_grpc_err looks like. the lack of context in this diff makes it difficult to determine if a given dependency is appropriate or propose an alternative.

Mar 10 2023, 7:36 PM
varun added a comment to D7020: [comm-opaque] Add dependencies for client and server logic.

i frankly don't think this adds much clutter at all... also it's more tedious for me to switch between diffs to see how these dependencies are being used. just looking at this diff, i have no idea what any of these dependencies are for besides the one that @jon annotated, and even then i still have to look at another diff to see what handle_pake_to_grpc_err looks like. the lack of context in this diff makes it difficult to determine if a given dependency is appropriate or propose an alternative.

Mar 10 2023, 7:35 PM
atul added a comment to D7020: [comm-opaque] Add dependencies for client and server logic.

so that a reviewer can have a more focused context when reviewing

Mar 10 2023, 7:28 PM
ashoat requested changes to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 10 2023, 7:14 PM
ashoat added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 10 2023, 7:01 PM
ashoat updated subscribers of D7030: [web] Use notifPermissionAlertInfo.
Mar 10 2023, 6:55 PM
ashoat accepted D6994: [web-db] implement types for `SubtleCrypto` module.
Mar 10 2023, 6:51 PM
jon added a comment to D7020: [comm-opaque] Add dependencies for client and server logic.

i don't love adding the dependencies in a separate diff, would like to see them added when they're actually being used

Mar 10 2023, 6:42 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 10 2023, 6:26 PM
jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Going to go to a more OOP-like approach instead of some "static methods". Following https://github.com/marucjmar/opaque-wasm as an example of more ergonomic JS bindings.

Mar 10 2023, 6:22 PM
atul accepted D7031: [CI] Fix macos buildkite ci.
Mar 10 2023, 5:55 PM
jon closed D7028: [Identity] Change default port to 50054 to avoid port collision.
Mar 10 2023, 5:22 PM
jon committed rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision.
Mar 10 2023, 5:22 PM
jon updated the diff for D7028: [Identity] Change default port to 50054 to avoid port collision.

Rebase on master

Mar 10 2023, 5:03 PM
jon added inline comments to D7028: [Identity] Change default port to 50054 to avoid port collision.
Mar 10 2023, 5:00 PM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Address feedback:

  • clarify service comment
  • Make LoginPasswordUser into stream, and finalize OPAQUE
  • Remove GetUserID (at least for now, until we have a use case)
  • signingPublicKey -> deviceEd25519PublicKey
  • align opaque message with opaque_ke terms
Mar 10 2023, 4:59 PM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 10 2023, 4:59 PM
michal requested review of D7032: [desktop] Handle autoUpdate errors.
Mar 10 2023, 4:40 PM
jon added a comment to D7031: [CI] Fix macos buildkite ci.

looks fine to me, not going to accept so that atul can take a look as he's probably more familar with mac workflow.

Mar 10 2023, 4:28 PM
jon updated the diff for D7028: [Identity] Change default port to 50054 to avoid port collision.

grpc -> gRPC

Mar 10 2023, 4:27 PM
michal abandoned D6683: [desktop] Continue checking for updates even after an exception.

Abandoned in favour of D7032

Mar 10 2023, 4:26 PM
michal abandoned D6684: [desktop] Ignore exceptions about being offline.

Abandoned in favour of D7032

Mar 10 2023, 4:25 PM
michal requested review of D7031: [CI] Fix macos buildkite ci.
Mar 10 2023, 4:04 PM
michal requested review of D7030: [web] Use notifPermissionAlertInfo.
Mar 10 2023, 3:53 PM
michal requested review of D7029: [native] Move NotifPermissionAlertInfo to lib.
Mar 10 2023, 3:44 PM
kamil added inline comments to D6996: [web-db] generate `CryptoKey` and persist.
Mar 10 2023, 3:19 PM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

rebase, update const

Mar 10 2023, 3:18 PM
kamil added inline comments to D6995: [web-db] implement crypto functions.
Mar 10 2023, 3:15 PM
kamil updated the diff for D6995: [web-db] implement crypto functions.

rebase, make type read-only

Mar 10 2023, 3:14 PM
kamil added reviewers for D6994: [web-db] implement types for `SubtleCrypto` module: bartek, ashoat.

Previous types were too general (string instead of current algorithm names). I've updated this to be more precise (like D7023) but with specific types for the entire module - not only AES algorithms.

Mar 10 2023, 3:11 PM
kamil updated the diff for D6994: [web-db] implement types for `SubtleCrypto` module.

improve types and move to flow-typed

Mar 10 2023, 3:04 PM
bartek planned changes to D7025: [web] Add unit tests for AES functions.

I'll add a test for the correct key, but the malformed ciphertext

Mar 10 2023, 9:05 AM
bartek added inline comments to D7005: [native][AES] Implement encrypt function on iOS.
Mar 10 2023, 9:00 AM
bartek added inline comments to D7004: [native][AES] Implement generateKey function.
Mar 10 2023, 8:51 AM
varun requested changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 10 2023, 8:04 AM
varun accepted D7020: [comm-opaque] Add dependencies for client and server logic.

i don't love adding the dependencies in a separate diff, would like to see them added when they're actually being used

Mar 10 2023, 7:38 AM
varun requested changes to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 10 2023, 7:35 AM
bartek published D7025: [web] Add unit tests for AES functions for review.
Mar 10 2023, 7:11 AM
bartek closed D6558: Added web tests to .lintstagedrc and CI.
Mar 10 2023, 7:08 AM
bartek committed rCOMM96800eb9c03f: Added web tests to .lintstagedrc and CI.
Mar 10 2023, 7:08 AM
bartek closed D7019: [web] Fix missing WebCrypto mock in tests.
Mar 10 2023, 7:08 AM
bartek committed rCOMM961052269b9f: [web] Fix missing WebCrypto mock in tests.
Mar 10 2023, 7:07 AM
bartek updated the diff for D7019: [web] Fix missing WebCrypto mock in tests.

Changed flow-typed -> Flow as suggested

Mar 10 2023, 7:02 AM
varun accepted D7028: [Identity] Change default port to 50054 to avoid port collision.
Mar 10 2023, 6:59 AM
bartek accepted D7028: [Identity] Change default port to 50054 to avoid port collision.
Mar 10 2023, 6:55 AM
ashoat added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 10 2023, 2:05 AM
jon requested review of D7028: [Identity] Change default port to 50054 to avoid port collision.
Mar 10 2023, 12:16 AM

Mar 9 2023

jon closed D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.
Mar 9 2023, 11:27 PM
jon committed rCOMM538ca1cc8b28: [Identity] Rename IdentityService service to IdentityKeyserverService.
Mar 9 2023, 11:27 PM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

UpdateUser -> UpdateUserPassword
Add comment on rpcs
Use a single "Empty" message instead of rpc specific versions

Mar 9 2023, 11:21 PM
atul requested changes to D7006: [native][AES] Implement decrypt function on iOS.

Some questions inline. Definitely feel free to re-request review if there's something I'm missing.

Mar 9 2023, 10:47 PM
ashoat added a comment to D7026: [keyserver][web] Add types for @matrix-org/olm.

I pulled this from the version of the types in node_modules. Will try to make those improvements, with exceptions for any methods that might not exist in this older version of Olm (I think you're looking at master, which I linked above)

Mar 9 2023, 10:39 PM
atul accepted D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..
Mar 9 2023, 10:15 PM
atul attached a referenced file: F419751: 602258.png.
Mar 9 2023, 9:46 PM
atul attached a referenced file: F419756: 6c1aae.png.
Mar 9 2023, 9:46 PM
atul attached a referenced file: F419758: 014c61.png.
Mar 9 2023, 9:46 PM
atul requested changes to D7026: [keyserver][web] Add types for @matrix-org/olm.

Noted some inconsistencies with the TypeScript types. Feel free to re-request review if the omissions were intentional.

Mar 9 2023, 9:46 PM
atul accepted D7027: [web] Introduce Jest tests for Olm.
Mar 9 2023, 9:23 PM
atul requested changes to D7005: [native][AES] Implement encrypt function on iOS.

Some questions inline. Definitely feel free to re-request review if there's something I'm missing.

Mar 9 2023, 8:40 PM
ashoat requested review of D7027: [web] Introduce Jest tests for Olm.
Mar 9 2023, 8:25 PM
ashoat requested review of D7026: [keyserver][web] Add types for @matrix-org/olm.
Mar 9 2023, 8:22 PM
atul added a comment to D7021: [keyserver] Use `build:debug` instead of `build` in `postinstall`.

JK, I shouldn't have just searched yarn build... should've considered that yarn scripts can be invoked via yarn workspace blah command.

Mar 9 2023, 8:16 PM
atul reopened D7021: [keyserver] Use `build:debug` instead of `build` in `postinstall`.
Mar 9 2023, 8:07 PM