I'm missing some test videos here. Will fill this in after I finish testing.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Oct 10 2023
Fix for landing
Oct 9 2023
nice job!
seems reasonable
rebase and land
rebase and land
rebase and land
address comments
Avoiding "request changes" to keep this on other reviewers' queues
rebase before landing
If we're allowing ?UserInfo for userInfo prop, shouldn't we eg render "Copy username" conditionally? Or maybe userInfo can be UserInfo?
rebase before landing
Skimmed this very briefly, counting on CI/flow/etc
Requesting changes for @ashoat's suggestion
Kind of like I mentioned in the previous diff, it might make sense to create some sort of higher level abstraction similar to ModalProvider on web to handle these BottomSheets. Every time a new bottom sheet is added, will we need to add isNewBottomSheetActive to the conditional?
rebase before landing
rebase before landing
address comments
Looks good, haven't worked with these markdown rules before so adding @rohan to take another look
Appears to be some miscommunication between Buildkite and Harbormaster. The iOS build appears to have succeeded in Buildkite, but Harbormaster hasn't gotten the message (yet?)
Here I described how to resolve all the issues: ENG-3944
This is a complicated and complex thing so I broke this into logical parts and created a stack starting with D9419 to make it easier for reviewers.
Added @ashoat as a reviewer since he requested changes here, after that stack is done I will abandon this one.
Rebase