Page MenuHomePhorge
Feed All Stories

Oct 10 2023

bartek accepted D9440: [identity] Make sure username users can't use ETH addresses as usernames on the identity service.
Oct 10 2023, 6:17 AM
varun requested review of D9441: [identity] verify nonce in siwe message.
Oct 10 2023, 4:28 AM
varun requested review of D9440: [identity] Make sure username users can't use ETH addresses as usernames on the identity service.
Oct 10 2023, 4:27 AM
ashoat requested review of D9439: [lib] Fix render of ConnectedWalletInfo on landing.
Oct 10 2023, 1:46 AM
ashoat added a comment to D9438: [landing] Update Lottie packages.

I'm missing some test videos here. Will fill this in after I finish testing.

Oct 10 2023, 1:29 AM
ashoat updated the diff for D9434: [lib][web][landing] Wagmi 1.0.

Fix for landing

Oct 10 2023, 1:25 AM

Oct 9 2023

varun accepted D9384: Implement Display and TryFrom traits for DeviceType.

nice job!

Oct 9 2023, 10:27 PM
ginsu accepted D9438: [landing] Update Lottie packages.
Oct 9 2023, 9:43 PM
ginsu accepted D9437: [native] Update height calculations for SIWEPanel.

seems reasonable

Oct 9 2023, 9:42 PM
ashoat requested review of D9438: [landing] Update Lottie packages.
Oct 9 2023, 9:29 PM
ashoat requested review of D9437: [native] Update height calculations for SIWEPanel.
Oct 9 2023, 9:28 PM
ginsu closed D9285: [native] simplify RelationshipListItem jsx.
Oct 9 2023, 9:18 PM
ginsu closed D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Oct 9 2023, 9:18 PM
ginsu committed rCOMMc610c2ea44ac: [native] simplify RelationshipListItem jsx.
Oct 9 2023, 9:18 PM
ginsu committed rCOMM0d5f115c9322: [native] introduce useNavigateToUserProfileBottomSheet hook.
Oct 9 2023, 9:18 PM
ginsu closed D9383: [native] introduce avatar constants.
Oct 9 2023, 9:18 PM
ginsu committed rCOMM55b9a6cb5077: [native] introduce avatar constants.
Oct 9 2023, 9:18 PM
ginsu closed D9382: [native] introduce UserProfileMenuButton.
Oct 9 2023, 9:18 PM
ginsu committed rCOMM254654f123c1: [native] introduce UserProfileMenuButton.
Oct 9 2023, 9:18 PM
atul closed D9406: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`.
Oct 9 2023, 9:16 PM
atul committed rCOMM37ed3d6636fe: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`.
Oct 9 2023, 9:16 PM
atul closed D9404: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state.
Oct 9 2023, 9:16 PM
atul committed rCOMM8a192aa280f0: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state.
Oct 9 2023, 9:16 PM
atul closed D9402: [lib] Handle `[leave/delete]ThreadActionTypes.success` in `reduceThreadActivity`.
Oct 9 2023, 9:16 PM
atul committed rCOMM7c3352f44588: [lib] Handle `[leave/delete]ThreadActionTypes.success` in `reduceThreadActivity`.
Oct 9 2023, 9:16 PM
atul updated the diff for D9406: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`.

rebase and land

Oct 9 2023, 9:15 PM
atul updated the diff for D9404: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state.

rebase and land

Oct 9 2023, 9:15 PM
atul updated the diff for D9402: [lib] Handle `[leave/delete]ThreadActionTypes.success` in `reduceThreadActivity`.

rebase and land

Oct 9 2023, 9:15 PM
atul accepted D9435: [landing] Update useMonitorForWalletConnectModal for new WalletConnect modal.
Oct 9 2023, 9:09 PM
atul accepted D9436: [landing] Update WalletConnect CSS override.
Oct 9 2023, 9:09 PM
atul accepted D9431: [web] introduce UserProfileActionButtons.
Oct 9 2023, 9:07 PM
atul added inline comments to D9431: [web] introduce UserProfileActionButtons.
Oct 9 2023, 9:07 PM
atul added inline comments to D9388: [native] make user profile accessible from ThreadSettingsMember.
Oct 9 2023, 9:06 PM
ginsu updated the diff for D9389: [lib/native/web] make user profile accessible from a user entity in a robotext.

address comments

Oct 9 2023, 9:05 PM
ashoat accepted D9406: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`.
Oct 9 2023, 9:01 PM
ginsu added inline comments to D9388: [native] make user profile accessible from ThreadSettingsMember.
Oct 9 2023, 9:00 PM
ashoat accepted D9404: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state.
Oct 9 2023, 9:00 PM
ashoat accepted D9402: [lib] Handle `[leave/delete]ThreadActionTypes.success` in `reduceThreadActivity`.
Oct 9 2023, 8:59 PM
atul accepted D9412: [web] introduce UserProfileMessageButton.
Oct 9 2023, 8:58 PM
ashoat added a comment to D9401: Implement stateful and deferrable notification decryption and use it on iOS in NSE.

Avoiding "request changes" to keep this on other reviewers' queues

Oct 9 2023, 8:57 PM
atul accepted D9411: [web] introduce copy username functionality to user profiles.
Oct 9 2023, 8:55 PM
ginsu updated the diff for D9285: [native] simplify RelationshipListItem jsx.

rebase before landing

Oct 9 2023, 8:54 PM
atul accepted D9410: [web] introduce UserProfileModal component.
Oct 9 2023, 8:52 PM
atul requested changes to D9409: [web] introduce UserProfile component.

If we're allowing ?UserInfo for userInfo prop, shouldn't we eg render "Copy username" conditionally? Or maybe userInfo can be UserInfo?

Oct 9 2023, 8:50 PM
ginsu updated the diff for D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.

rebase before landing

Oct 9 2023, 8:49 PM
ginsu added inline comments to D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Oct 9 2023, 8:48 PM
atul accepted D9407: [web] update web avatars to use t shirt sizes.

Skimmed this very briefly, counting on CI/flow/etc

Oct 9 2023, 8:46 PM
atul accepted D9395: [native] fix viewer user profile bototm sheet snap point.
Oct 9 2023, 8:46 PM
atul requested changes to D9394: [native] introduce MarkdownUserMention component.

Requesting changes for @ashoat's suggestion

Oct 9 2023, 8:45 PM
ashoat accepted D9400: Minor improvments to NSE code.
Oct 9 2023, 8:45 PM
atul accepted D9393: [native] introduce userProfileBottomSheetActive state to markdown context.

Kind of like I mentioned in the previous diff, it might make sense to create some sort of higher level abstraction similar to ModalProvider on web to handle these BottomSheets. Every time a new bottom sheet is added, will we need to add isNewBottomSheetActive to the conditional?

Oct 9 2023, 8:44 PM
ginsu updated the diff for D9383: [native] introduce avatar constants.

rebase before landing

Oct 9 2023, 8:44 PM
ashoat added inline comments to D9394: [native] introduce MarkdownUserMention component.
Oct 9 2023, 8:42 PM
ginsu updated the diff for D9382: [native] introduce UserProfileMenuButton.

rebase before landing

Oct 9 2023, 8:41 PM
ginsu updated the diff for D9382: [native] introduce UserProfileMenuButton.

address comments

Oct 9 2023, 8:37 PM
ashoat requested review of D9435: [landing] Update useMonitorForWalletConnectModal for new WalletConnect modal.
Oct 9 2023, 8:30 PM
ashoat requested review of D9436: [landing] Update WalletConnect CSS override.
Oct 9 2023, 8:30 PM
atul accepted D9392: [lib/native] introduce parseUserMentions function.

Looks good, haven't worked with these markdown rules before so adding @rohan to take another look

Oct 9 2023, 8:30 PM
atul accepted D9391: [lib/native/web] introduce createMemberMapForUserMentions function.
Oct 9 2023, 8:26 PM
atul added inline comments to D9390: [native] make user profile accessible from MessageReactionsModal.
Oct 9 2023, 8:20 PM
atul accepted D9390: [native] make user profile accessible from MessageReactionsModal.
Oct 9 2023, 8:19 PM
atul accepted D9389: [lib/native/web] make user profile accessible from a user entity in a robotext.
Oct 9 2023, 7:51 PM
atul accepted D9388: [native] make user profile accessible from ThreadSettingsMember.
Oct 9 2023, 7:49 PM
atul accepted D9385: [native] utilize memoization in the MesssageHeader component.
Oct 9 2023, 7:41 PM
atul accepted D9382: [native] introduce UserProfileMenuButton.
Oct 9 2023, 7:36 PM
atul accepted D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Oct 9 2023, 7:29 PM
varun closed D9367: [identity] implement getOutboundKeysForUser.
Oct 9 2023, 6:39 PM
varun committed rCOMM1e3b4fd0fbc3: [identity] implement getOutboundKeysForUser.
Oct 9 2023, 6:39 PM
atul accepted D9433: [lib] Stop using Ethers.js client from Wagmi.
Oct 9 2023, 6:25 PM
atul accepted D9432: [landing] Reduce code duplication in landing/siwe.react.js.
Oct 9 2023, 6:22 PM
atul accepted D9434: [lib][web][landing] Wagmi 1.0.

Thanks for thorough Test Plan

Oct 9 2023, 6:21 PM
ashoat requested review of D9434: [lib][web][landing] Wagmi 1.0.
Oct 9 2023, 5:34 PM
ashoat requested review of D9433: [lib] Stop using Ethers.js client from Wagmi.
Oct 9 2023, 5:27 PM
ashoat requested review of D9432: [landing] Reduce code duplication in landing/siwe.react.js.
Oct 9 2023, 5:26 PM
ginsu requested review of D9431: [web] introduce UserProfileActionButtons.
Oct 9 2023, 5:23 PM
rohan requested review of D9430: [lib/web/native] Display community role for users in subchannels/sidebars.
Oct 9 2023, 5:09 PM
ashoat closed D9426: [native][web] Convert account deletion components to hooks.
Oct 9 2023, 4:49 PM
ashoat closed D9425: [native][web] Remove UI elements that ask for password when deleting account.
Oct 9 2023, 4:49 PM
ashoat committed rCOMMe8593f27916e: [native][web] Convert account deletion components to hooks.
Oct 9 2023, 4:49 PM
ashoat committed rCOMMba9a43c03a7c: [native][web] Remove UI elements that ask for password when deleting account.
Oct 9 2023, 4:49 PM
ashoat closed D9424: [lib][native][web] Stop passing password up to deleteAccount endpoint.
Oct 9 2023, 4:49 PM
ashoat committed rCOMM1d1e3398754e: [lib][native][web] Stop passing password up to deleteAccount endpoint.
Oct 9 2023, 4:49 PM
ashoat closed D9428: [lib] Remove message spec code for deprecated codeVersions.
Oct 9 2023, 4:42 PM
ashoat committed rCOMMbd81037dce40: [lib] Remove message spec code for deprecated codeVersions.
Oct 9 2023, 4:42 PM
ginsu accepted D9426: [native][web] Convert account deletion components to hooks.
Oct 9 2023, 4:39 PM
marcin requested review of D9429: Send all notifications received by backgrounded app to JS at once.
Oct 9 2023, 4:38 PM
ginsu accepted D9425: [native][web] Remove UI elements that ask for password when deleting account.
Oct 9 2023, 4:37 PM
ashoat published D9426: [native][web] Convert account deletion components to hooks for review.

Appears to be some miscommunication between Buildkite and Harbormaster. The iOS build appears to have succeeded in Buildkite, but Harbormaster hasn't gotten the message (yet?)

Oct 9 2023, 3:58 PM
tomek accepted D9428: [lib] Remove message spec code for deprecated codeVersions.
Oct 9 2023, 3:26 PM
kamil added a comment to D8476: [Keyserver] Publish prekeys to identity service for cron job.

Here I described how to resolve all the issues: ENG-3944
This is a complicated and complex thing so I broke this into logical parts and created a stack starting with D9419 to make it easier for reviewers.
Added @ashoat as a reviewer since he requested changes here, after that stack is done I will abandon this one.

Oct 9 2023, 3:20 PM
kamil published D9427: [keyserver] migration to publish prekeys to identity for review.
Oct 9 2023, 3:20 PM
kamil published D9423: [keyserver] validate prekeys only via cron job for review.
Oct 9 2023, 3:19 PM
kamil published D9422: [keyserver] delete marking prekeys as published each time `olm` account is accessed for review.
Oct 9 2023, 3:19 PM
kamil published D9421: [keyserver] cron job to refresh account prekeys for review.
Oct 9 2023, 3:19 PM
kamil published D9420: [keyserver] implement function to get account prekey and prekey signature for review.
Oct 9 2023, 3:18 PM
kamil published D9419: [keyserver] refactor functions to check rotate/forget prekeys for review.
Oct 9 2023, 3:18 PM
ashoat requested review of D9428: [lib] Remove message spec code for deprecated codeVersions.
Oct 9 2023, 2:52 PM
ashoat requested review of D9425: [native][web] Remove UI elements that ask for password when deleting account.
Oct 9 2023, 2:28 PM
varun accepted D9424: [lib][native][web] Stop passing password up to deleteAccount endpoint.
Oct 9 2023, 2:26 PM
michal updated the diff for D9329: [lib] Remove convertClientToServerInfos from spec.

Rebase

Oct 9 2023, 2:26 PM