rebase
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 18 2023
Sep 18 2023
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
atul added inline comments to D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch`.
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
address feedback: early-return
atul added inline comments to D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
rebase
atul updated the diff for D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.
rebase
atul added inline comments to D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.
rebase after resolve merge conflict
Memoize boundCallServerEndpointSelector per keserverID
In D9211#271261, @tomek wrote:Have you tested if memoizing the list is beneficial? FlatList is already memoized internally (PureComponent) so wrapping it with memo shouldn't improve anything, but maybe I'm missing something.
marcin updated the diff for D8730: Implement displaying error message notification for cases that might cause empty notification on Android.
Set auto cancel property to false only for staff releases
Don't forget to create one for the input validator idea too!
Fix flow
Fix flow bugs
Harbormaster failed remote builds in B22676: Diff 31203 for D9159: [web] Use blobServiceUpload upload action!
Harbormaster failed remote builds in B22675: Diff 31202 for D9163: [native] Use blobServiceUpload upload action!
Rebuild
Rebuild
I created a followup task to update the types: ENG-4968
Failing CI fix
There's code that exists for the search experience that handles finding a thread for a given user if it already exists, OR creating a "pending" thread if that thread doesn't exist yet.
How does the code for search results currently handle this?
ashoat accepted D8730: Implement displaying error message notification for cases that might cause empty notification on Android.
Looks good, but would be great if @tomek could take a look, as he's more familiar with our Android notif code
marcin updated the diff for D8730: Implement displaying error message notification for cases that might cause empty notification on Android.
Refactor using isStaffRelease utility.
Have you tested if memoizing the list is beneficial? FlatList is already memoized internally (PureComponent) so wrapping it with memo shouldn't improve anything, but maybe I'm missing something.
Unfortunate that we can't use ReturnType<T> and Parameters<T> from new versions of flow, might simplify it a little
Harbormaster failed remote builds in B22670: Diff 31197 for D9157: [lib] Add blobServiceUpload upload action!
Harbormaster failed remote builds in B22671: Diff 31198 for D9163: [native] Use blobServiceUpload upload action!
Use new syntax
Destructure options.
Requesting changes to fix failing CI - most likely wrong uuid version is being resolved, try the yarn why uuid command to confirm.
Restricted Repository Identity closed D9110: [web] Migrate drafts to db for everyone.
Restricted Repository Identity closed D9109: [web] Enable db for all users.
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM2ce478126824: [web] Enable db for all users.
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMdd9055f2f3ab: [web] Migrate drafts to db for everyone.
Restricted Repository Identity closed D9108: [web] Initialize database at startup on safari.
Restricted Repository Identity closed D9107: [web] Move safari db key init to database module.
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM5704f7fa8d34: [web] Initialize database at startup on safari.
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM254a9328e508: [web] Move safari db key init to database module.
Restricted Repository Identity closed D9105: [web] Hide databaseModule behind a function.
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMc67113dafe68: [web] Hide databaseModule behind a function.
Sep 17 2023
Sep 17 2023
type fn return values as mixed
rebase and land
rebase and land
rebase and land
Sep 16 2023
Sep 16 2023
Nice thank you!!
ashoat added inline comments to D9206: [native] Move rest of Search views to `ChatThreadListSearch`.
Sep 15 2023
Sep 15 2023
atul updated subscribers of D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
In D9215#271132, @rohan wrote:Accepting since it seems reasonable to me, but not super familiar with why we introduced it here in the first place so letting others take a look
In D9214#271139, @rohan wrote:If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?
Nice to see the code a lot simpler!
If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?
Accepting since it seems reasonable to me, but not super familiar with why we introduced it here in the first place so letting others take a look
Did you test whether the animation still works when user opens tooltip and presses "thread", even if the message has a link?
marcin updated the diff for D9179: Save encrypted payload hash in MariaDB keyserver for iOS notifs..
Rebase before landing
marcin updated the diff for D9178: Enhance error check in CryptoModule decrypt. Add encrypted message hash to error message..
Rebase before landing
Return instead of modifying
Fixes