Rebase before landing

Rebase before landing

1. Don't wait forever
2. Rebase before landing

The diff title here should probably include the word "notification" somewhere :)

Some last changes and rebase before landing

@tomek Sorry, you’re totally right that this is useless. I tested performance with/without this diff in isolation and there was no difference.

We shouldn't use entityTextToRawString directly. I'm not sure what the alternatives are here, and what the added complexity will be. Please investigate and get back to us

In D8944#263772, @rohan wrote:

I think it'll be useful to add some unit tests for this regex, alongside the regex in D8834

Is the performance concern pointed out by @tomek going to lead to additional React render cycles? If yes, we should prioritize addressing it. cc @atul

Adding @atul as a reviewer in case he has any comments about React performance here

I am leaving for vacation so I don't want to block this diff. I am adding two reviewers:

1. @kamil for changes related to data clearance. I didn't add him as a blocking reviewer since he might be absent for a longer time. But if he is back quickly I would appreciate his review on the data clearance.
2. @bartek for changes related to putting entire authentication payload in Secure Store at once.

1. Take advantage of builder mutability.
2. Use streams instead of iteration.
3. Don't iterate twice over notifications id list when removing a notification id

THos should cover all comments from Tomek last review

In D9211#271306, @atul wrote:

In D9211#271261, @tomek wrote:

Have you tested if memoizing the list is beneficial? FlatList is already memoized internally (PureComponent) so wrapping it with memo shouldn't improve anything, but maybe I'm missing something.

Yeah, previously flatList would re-render when fixedSearch changed because it was in the chatThreadList dep list. Separating flatList out into its own useMemo seems to prevent that.

Move isStaffRelease checks to better places

Abandoning this diff since I don't have much time left in Comm.

Abandoning this diff since I don't have much time left in Comm.

Remove unused utilities and introduce renderChatMentionsWithAltText

Use getRawChatMention

Use local notifications for collapsible notifications to achieve previous UX experience.

Remove oldValidUsernameRegexString.

Remove oldValidUsernameRegexString from mention regex

Extract mention text to separate function and apply DRY rule

In D8901#267694, @inka wrote:

D8903 will introduce new regex for detecting when typeahead should be shown (it will catch spaces too). Because of that change, the tooltip would never close.

D8903 was abandoned, does this influence this diff? What does the regex look like now?

Rename addEntryHandler to addAllPrefixes and simplify code

Rebase

Change void to mixed

Rename textPrefix to query

Rebase

Wrap <a> with <strong>

Rebase and early return textMessageRules

Rebase

@tomek's improvement makes sense, but I'm not applying them right now because I don't believe it will bring significant improvements. If there will be any performance issues during testing, it might be worth wrapping default rules with memo.

Early return textMessageRules

Yes, the sidebarAnimationType is set to move_source_message in this case.

Rebase

Move match word

Made a task about validators ENG-4982 because I have more context on them.

Rebase

add capitalization

address comments. (changed log to say "Still waiting for MariaDB socket" in hopes that this is more clear/explicit)

address @atul's feedback

rebase around D9211 to land

rebase around D9211 to land

land

merge conflicts

rebase

rebase

rebase

rebase