Small fixes and early return
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 15 2023
Sep 15 2023
Set DatabaseModule fields to optional and add invariants
Enhance variable naming
marcin updated the diff for D9179: Save encrypted payload hash in MariaDB keyserver for iOS notifs..
- Update typing
- Save device token to hash mapping instead of plain hash list.
Rebase
Looks good but please add the dependency array
Different convention than useDispatchActionPromise, but the reason sounds convincing.
atul requested review of D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
Sep 14 2023
Sep 14 2023
atul published D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch` for review.
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
some memoization
atul published D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch` for review.
accepting, but please take a look at the inline comments
remove oneTimeKey and correct create_inbound_from args
How does the code for search results currently handle this? I think there's a similar need there for getting a "pending or realized" thread for the viewer and a given user. The new selector here makes me wonder if you're reusing as much of that code as possible.
ginsu added inline comments to D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
ginsu updated the test plan for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
ginsu updated the diff for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
address feedback
address feedback
atul requested changes to D9095: [native] Block editing messages on search and pinned messages screens, and of the first message in a thread.
Requesting changes for feedback above
Fact that we have unit test coverage here makes this super easy to accept
Generally looks good, would be good for @kamil to take a final pass. Only thing that I'd change before landing is early returning in handleSensitiveData.
Thanks for cleaning this up
Seems reasonable. In the future it might be helpful to provide link to corresponding GitHub repo in description.
ginsu resigned from D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.
Code looks good to me, but resigning to give others a chance to review
In D9194#270776, @ginsu wrote:Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff
I thought about that but native has it's own version of the useStaffCanSee hook that is slightly different. The native version of useStaffCanSee also considers if the user is using a staff release as well that web does not need to consider. I thought it would make more sense/be less confusing for other devs that use this in the future if the different versions of each hook lived in their own respective platform folders, but if others disagree happy to make the necessary changes
address feedback
Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff
I can confirm that we're looking to do only prefix search for @-mentions of chats. We'll continue to do a "full text search" for in the "Search chats" experience as well as the message search experience. But the typeahead is meant to be prefix-only
Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff
ashoat added a reverting change for rCOMM8428f7fc38ae: Temporary changes for staff release: rCOMM18d58e18f1c4: Revert "Temporary changes for staff release".
Publishing now, but will wait on CI before landing