In D9144#269987, @ashoat wrote:The UX change doesn't seem particularly bad to me, but I'd like to understand if the approach you're using here (deleting the old notif) is similar to the approaches that other encrypted apps take. Is there no way to set a "collapse ID" from the NSE?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 14 2023
Sep 14 2023
This code works properly on iOS, but I need to check if it is working properly on Android.
unwrap -> expect
use error!
address review
rebase before landing
marcin updated the summary of D9199: Encrypt all notifications on the keyserver for Android devices.
marcin updated the test plan for D9198: Enable encrypted notifications coalescing on in Androoid native code..
marcin requested review of D9198: Enable encrypted notifications coalescing on in Androoid native code..
marcin retitled D9149: Encrypt all notifications on the keyserver for iOS devices from Encrypt all notifications on the keyserver
Apply review feedback
Sep 13 2023
Sep 13 2023
atul updated the diff for D9190: [native] Replace `componentDidUpdate` with `useEffect`s in `ConnectedChatThreadList`.
address @ashoat's feedback
address @ginsu's feedback
Awesome
Seems reasonable, but not super familiar with the requirements
One question inline
ashoat accepted D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.
Thanks!!
varun updated the diff for D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.
resolve ESLint/Flow/Jest issues
Harbormaster failed remote builds in B22612: Diff 31091 for D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object!
varun added a comment to D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.
I found it confusing that we were using oneTimeKey instead of oneTimeKeys for arrays of keys so I changed that as well here
varun updated the diff for D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.
address feedback
atul updated the diff for D9189: [native] Lift `component[DidMount/WillUnmount]` lifecycle methods to `useEffect` in `ConnectedChatThreadList`.
address @ashoat's feedback: split into three separate useEffects