rebase and land

Can you decompose into three effects?

Good call

Also update mariadb-up-mac.nix

Is this config auto generated by nix somehow? Should mariadb-up-mac.nix be updated as well?

Successfully tested this:

We actually want a 256-bit key. I think @anunay is in the process of updating that

rebase

Accepting since my comments are minor, but if you disagree feel free to re-request review

resolve merge conflicts

resolve merge conflicts and rebase

address @ginsu's feedback

In D9181#270238, @ashoat wrote:

Can we use any random string as an AES-256 key? Or are there some additional requirements?

Don't have a ton of experience with qr codes, but seems reasonable

Improved error handling in D9141. It will bubble up any errors to the error boundary.

One concern inline

Changed the component to function instead of arrow function. Added the error handling so any errors from the promise will bubble up to ErrorBoundary and display the "Something went wrong, please reload" page. We don't really have a any other good way to handle errors here.

I won't block this diff on it, but I think we should strive to have correct types. invariants can feel messy, but I think they are better than having incorrect types

Can we use any random string as an AES-256 key? Or are there some additional requirements?

thanks for clarifying!

Fixed window.status -> this.status issue

Unfortunately, I don't have time to fix this diff, so I'll have to abandon it because it requires a refactor.

Unfortunately, I don't have time to fix this diff, so I'll have to abandon it because it requires a refactor.

Rebase

Attempt rebase

rebase and land

Remove unused veriable

We already pass all actions to a hook (even in class components, we use useServerCall) so I imagine there is some way to do it. But I won't insist

Another example w/ doubleTapUpdate:
https://chat.openai.com/share/285de214-0e3f-4753-96b5-d7870e7c0c11