Thanks for addressing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 6 2023
Oct 6 2023
Do we also plan to uncheck items in some cases? It looks like we're handling a case where an item wasn't created properly. I think that we also sometimes should look for a case where an item was deleted only partially (e.g. only a holder was left).
kamil accepted D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.
Thanks @varun, looks good
ginsu requested review of D9393: [native] introduce userProfileBottomSheetActive state to markdown context.
ginsu requested review of D9391: [lib/native/web] introduce createMemberMapForUserMentions function.
Requesting changes just to confirm our doubts (one question inline), besides that: LGTM
we need separate functions for creating and storing olm sessions because we may not know the cookie ID at creation time
What is the example of such situation?
address feedback
update
varun updated the test plan for D9236: [keyserver] Update keyserver delete account endpoint to not require password.
varun updated the diff for D9236: [keyserver] Update keyserver delete account endpoint to not require password.
address feedback
ginsu updated the diff for D9381: [native] introduce tooltipButtonIcon to UserRelationshipTooltipModalParams.
rebase before landing
ginsu updated the diff for D9380: [native] make UserRelationshipTooltipButton a functional component.
rebase before landing
ginsu added inline comments to D9380: [native] make UserRelationshipTooltipButton a functional component.
ginsu updated the diff for D9379: [native] rename RelationshipListItemTooltipModal to UserRelationshipTooltipModal.
rebase before landing
ginsu updated the diff for D9378: [native] introduce block action to relationship list item tooltip menu.
rebase before landing
rebase before landing
rebase before landing
rebase one more time before landing (had a phab error when attempted to recently land)
rebase one more time before landing (had a phab error when attempted to recently land)
ginsu updated the diff for D9373: [native] replace out of box BottomSheetModal with basic BottomSheet.
rebase one more time before landing (had a phab error when attempted to recently land)
rebase before landing
rebase before landing
ginsu updated the diff for D9373: [native] replace out of box BottomSheetModal with basic BottomSheet.
address feedback
Oct 5 2023
Oct 5 2023
atul accepted D9379: [native] rename RelationshipListItemTooltipModal to UserRelationshipTooltipModal.
Looks like straightforward find+replace
Very clean
Accepting to unblock, but would prefer if we could avoid passing contentDimensions to FullScreenViewModal
Looks good, let's make sure to fix import before landing
ginsu requested review of D9381: [native] introduce tooltipButtonIcon to UserRelationshipTooltipModalParams.
ginsu requested review of D9380: [native] make UserRelationshipTooltipButton a functional component.
ginsu updated the summary of D9378: [native] introduce block action to relationship list item tooltip menu.
ginsu requested review of D9378: [native] introduce block action to relationship list item tooltip menu.
atul planned changes to D9372: [lib] Handle `send*MessageActionTypes.started` in `reduceThreadActivity`.
varun added a comment to D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.
requesting review again because i have a question inline and also want to make sure i've addressed @kamil 's feedback correctly
varun added inline comments to D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.
varun updated the diff for D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.
address feedback
update