Rebase
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 9 2023
Oct 9 2023
Rebase
ashoat requested review of D9424: [lib][native][web] Stop passing password up to deleteAccount endpoint.
Create a new function in spec that combines fetch and getServerInfosHash so flow doesn't complain
Fixed an issue where the integrity handler would run before the threads were fetched from db.
Rebase
Rebase. Use HashSet instead of Vec to avoid duplicates
Rebase. Fix filter-map condition
Rebase. Add debug derive
Rebase. Fix holders fetch limit
Rebase. Remove unused import
Harbormaster failed remote builds in B23080: Diff 31773 for D9354: [lib] Move inconsistencies finding into specs!
Use read only types in all the specs
In D9354#275224, @kamil wrote:In D9354#275219, @kamil wrote:LGTM, only one nit: you can probably replace Array<> with $ReadOnlyArray.
On the other hand, when you return the result we should allow the caller to do and modify the result, not sure what is better in this use case.
Use read only
In D9352#275828, @tomek wrote:Do we also plan to uncheck items in some cases? It looks like we're handling a case where an item wasn't created properly. I think that we also sometimes should look for a case where an item was deleted only partially (e.g. only a holder was left).
Looks good to me, thanks for addressing all comments
kamil added inline comments to D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.
finish test plan
Oct 7 2023
Oct 7 2023
Good call out, thanks for linking them.
Oct 6 2023
Oct 6 2023
Display and TryFrom unit tests for DeviceType
Export DeviceType in grpc_clients/identity for usage outside of the crate
atul published D9406: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity` for review.
IIRC we were using some CSS selectors from dist that might need to be updated?
ashoat requested review of D9405: [lib][landing][web] Update patch versions of Rainbowkit and Wagmi.
persist olm session
Is it a different case and persistence is not needed?
Convert access of DeviceType from super to crate::identity
ashoat accepted D9236: [keyserver] Update keyserver delete account endpoint to not require password.
Ah, my bad... I expected to see the old validator still there, and was surprised to see ignoredArgumentValidator (which I wasn't familiar with). After examining it more closely, it looks like it does what I probably should've concluded it does from the name – ignores all arguments
Replace placeholder error message formats for grpc_clients
atul published D9404: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state for review.
replace _debounce with _throttle
ashoat requested review of D9403: [keyserver] Modify filename column in MariaDB uploads table to utf8.
atul added inline comments to D9402: [lib] Handle `[leave/delete]ThreadActionTypes.success` in `reduceThreadActivity`.
atul published D9402: [lib] Handle `[leave/delete]ThreadActionTypes.success` in `reduceThreadActivity` for review.
can you elaborate a little on your test plan?
varun requested review of D9236: [keyserver] Update keyserver delete account endpoint to not require password.
From my updated test plan:
incorporate readability suggestion
ashoat requested changes to D9236: [keyserver] Update keyserver delete account endpoint to not require password.
Copy-pasting from my last review:
This is incorrect
address feedback
marcin added inline comments to D8795: Implement synchronization mechanisms to address process, thread and class level concurrency..