Page MenuHomePhabricator
Differential D10805

Rename `MinimallyEncodedThreadCurrentUserInfo` to `ThreadCurrentUserInfo`
ClosedPublic
Actions

Authored by atul on Jan 24 2024, 9:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 11:48 PM
Unknown Object (File)
Mon, Apr 21, 11:48 PM
Unknown Object (File)
Mon, Apr 21, 11:48 PM
Unknown Object (File)
Mon, Apr 21, 11:48 PM
Unknown Object (File)
Sat, Apr 19, 6:18 PM
Unknown Object (File)
Thu, Apr 17, 11:54 AM
Unknown Object (File)
Thu, Apr 17, 10:16 AM
Unknown Object (File)
Thu, Apr 17, 9:11 AM
View All 92 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM00524b1a58c5: Rename `MinimallyEncodedThreadCurrentUserInfo` to `ThreadCurrentUserInfo`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedinfo-to-rawinfo

There are no longer any MinimallyEncoded* types in the codebase.

Depends on D10792

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 24 2024, 9:23 PM
atul added a child revision: D10806: Get rid of `minimallyEncoded*` prefix for validators.Jan 24 2024, 9:37 PM
Harbormaster completed remote builds in B26140: Diff 36116.Jan 24 2024, 9:41 PM
atul requested review of this revision.Jan 24 2024, 9:41 PM
tomek accepted this revision.Jan 25 2024, 2:45 AM
tomek added inline comments.
lib/permissions/minimally-encoded-thread-permissions.test.js
10–11 ↗(On Diff #36116)

There are no longer any MinimallyEncoded* types in the codebase.

Shouldn't we also have no minimallyEncoded* validators in that case?

This revision is now accepted and ready to land.Jan 25 2024, 2:45 AM
atul updated this revision to Diff 36325.Jan 29 2024, 3:13 PM

rebase

Harbormaster completed remote builds in B26285: Diff 36325.Jan 29 2024, 3:41 PM
atul added inline comments.Jan 29 2024, 4:26 PM
lib/permissions/minimally-encoded-thread-permissions.test.js
10–11 ↗(On Diff #36116)

Yup, those get removed in subsequent diff.

Closed by commit rCOMM00524b1a58c5: Rename `MinimallyEncodedThreadCurrentUserInfo` to `ThreadCurrentUserInfo` (authored by atul). · Explain WhyJan 29 2024, 4:32 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM00524b1a58c5: Rename `MinimallyEncodedThreadCurrentUserInfo` to `ThreadCurrentUserInfo`.

Revision Contents
Changeset List

Diff 36325

View Options

lib/permissions/minimally-encoded-thread-permissions-validators.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesif(EXISTS "${_toolchain_path}/${Rust_CARGO_TARGET}-ar")
set(AR "${_toolchain_path}/${Rust_CARGO_TARGET}-ar") set(AR "${_toolchain_path}/${Rust_CARGO_TARGET}-ar")
else() else()
set(AR "${_toolchain_path}/llvm-ar") set(AR "${_toolchain_path}/llvm-ar")
endif() endif()
FetchContent_Declare( FetchContent_Declare(
Corrosion Corrosion
GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git
GIT_TAG v0.2.1 GIT_TAG v0.5.1
) )
FetchContent_MakeAvailable(Corrosion) FetchContent_MakeAvailable(Corrosion)
include(../../../shared/cmake/corrosion-cxx.cmake) include(../../../shared/cmake/corrosion-cxx.cmake)
add_library_rust(PATH ../../native_rust_library NAMESPACE comm) add_library_rust(PATH ../../native_rust_library NAMESPACE comm)
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines
View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesif(EXISTS "${_toolchain_path}/${Rust_CARGO_TARGET}-ar")
set(AR "${_toolchain_path}/${Rust_CARGO_TARGET}-ar") set(AR "${_toolchain_path}/${Rust_CARGO_TARGET}-ar")
else() else()
set(AR "${_toolchain_path}/llvm-ar") set(AR "${_toolchain_path}/llvm-ar")
endif() endif()
FetchContent_Declare( FetchContent_Declare(
Corrosion Corrosion
GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git
GIT_TAG v0.2.1 GIT_TAG v0.5.1
) )
FetchContent_MakeAvailable(Corrosion) FetchContent_MakeAvailable(Corrosion)
include(../../../shared/cmake/corrosion-cxx.cmake) include(../../../shared/cmake/corrosion-cxx.cmake)
add_library_rust(PATH ../../native_rust_library NAMESPACE comm) add_library_rust(PATH ../../native_rust_library NAMESPACE comm)
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesif(EXISTS "${_toolchain_path}/${Rust_CARGO_TARGET}-ar")
set(AR "${_toolchain_path}/${Rust_CARGO_TARGET}-ar") set(AR "${_toolchain_path}/${Rust_CARGO_TARGET}-ar")
else() else()
set(AR "${_toolchain_path}/llvm-ar") set(AR "${_toolchain_path}/llvm-ar")
endif() endif()
FetchContent_Declare( FetchContent_Declare(
Corrosion Corrosion
GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git
GIT_TAG v0.2.1 GIT_TAG v0.5.1
) )
FetchContent_MakeAvailable(Corrosion) FetchContent_MakeAvailable(Corrosion)
include(../../../shared/cmake/corrosion-cxx.cmake) include(../../../shared/cmake/corrosion-cxx.cmake)
add_library_rust(PATH ../../native_rust_library NAMESPACE comm) add_library_rust(PATH ../../native_rust_library NAMESPACE comm)
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesif(EXISTS "${_toolchain_path}/${Rust_CARGO_TARGET}-ar")
set(AR "${_toolchain_path}/${Rust_CARGO_TARGET}-ar") set(AR "${_toolchain_path}/${Rust_CARGO_TARGET}-ar")
else() else()
set(AR "${_toolchain_path}/llvm-ar") set(AR "${_toolchain_path}/llvm-ar")
endif() endif()
FetchContent_Declare( FetchContent_Declare(
Corrosion Corrosion
GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git
GIT_TAG v0.2.1 GIT_TAG v0.5.1
) )
FetchContent_MakeAvailable(Corrosion) FetchContent_MakeAvailable(Corrosion)
include(../../../shared/cmake/corrosion-cxx.cmake) include(../../../shared/cmake/corrosion-cxx.cmake)
add_library_rust(PATH ../../native_rust_library NAMESPACE comm) add_library_rust(PATH ../../native_rust_library NAMESPACE comm)
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines
View Options

lib/utils/thread-ops-utils.js

Loading...