Page MenuHomePhabricator
Differential D5921

[native] [26/40] RN 0.70: Update to react-native-screens@3.18.2
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 4:12 AM
Unknown Object (File)
Thu, Mar 27, 9:51 AM
Unknown Object (File)
Sun, Mar 23, 4:34 PM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM65ccb1207cd9: [native] [26/40] RN 0.70: Update to react-native-screens@3.18.2
Summary

I was seeing Android build errors with this package, which were resolved after updating.

Test Plan
  1. I reviewed the Release Notes and found no breaking changes
  2. Tested along with whole stack: test plan (includes testing React Navigation, which uses this package)

Depends on D5919

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 18 2022, 7:50 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 7:50 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:51 PM
Harbormaster failed remote builds in B14250: Diff 19489!
ashoat added a child revision: D5922: [native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash.Dec 18 2022, 7:53 PM
ashoat retitled this revision from [native] [25/40] RN 0.70: Update to react-native-screens@3.18.2 to [native] [26/40] RN 0.70: Update to react-native-screens@3.18.2.Dec 18 2022, 8:05 PM
ashoat updated this revision to Diff 19510.Dec 18 2022, 8:19 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:31 PM
Harbormaster failed remote builds in B14271: Diff 19510!
ashoat updated this revision to Diff 19537.Dec 18 2022, 8:32 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 9:30 PM
Harbormaster failed remote builds in B14298: Diff 19537!
ashoat updated this revision to Diff 19599.Dec 19 2022, 8:21 AM

Rebase

ashoat updated this revision to Diff 19632.Dec 19 2022, 8:38 AM

Rebase

Harbormaster failed remote builds in B14350: Diff 19599!Dec 19 2022, 9:03 AM
ashoat published this revision for review.Dec 19 2022, 9:11 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14383: Diff 19632!Dec 19 2022, 10:04 AM
ashoat updated this revision to Diff 19705.Dec 19 2022, 12:29 PM

Rebase

Harbormaster completed remote builds in B14450: Diff 19705.Dec 19 2022, 12:49 PM
bartek accepted this revision.Dec 20 2022, 3:21 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:21 AM
tomek accepted this revision.Dec 20 2022, 5:19 AM
ashoat updated this revision to Diff 19763.Dec 20 2022, 6:22 AM

Rebase

Harbormaster failed remote builds in B14506: Diff 19763!Dec 20 2022, 6:26 AM
ashoat updated this revision to Diff 19825.Dec 20 2022, 11:02 AM

Rebase

Harbormaster completed remote builds in B14565: Diff 19825.Dec 20 2022, 11:35 AM
Closed by commit rCOMM65ccb1207cd9: [native] [26/40] RN 0.70: Update to react-native-screens@3.18.2 (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM65ccb1207cd9: [native] [26/40] RN 0.70: Update to react-native-screens@3.18.2.

Revision Contents
Changeset List

PathSize
native/
ios/
4 lines
2 lines
14 lines

Diff 19866

View Options

native/ios/Podfile.lock

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };
View Options

native/package.json

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };
View Options

yarn.lock

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };