Page MenuHomePhabricator
Differential D5934

[native] [33/40] RN 0.70: Replace old AndroidLifecycleModule with new Expo one
ClosedPublic
Actions

Authored by ashoat on Dec 19 2022, 7:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 3:17 PM
Unknown Object (File)
Tue, Mar 18, 3:24 PM
Unknown Object (File)
Sat, Mar 15, 7:07 AM
Unknown Object (File)
Sat, Mar 15, 7:07 AM
Unknown Object (File)
Sat, Mar 15, 7:07 AM
Unknown Object (File)
Sat, Mar 15, 7:07 AM
Unknown Object (File)
Sat, Mar 15, 7:07 AM
Unknown Object (File)
Sat, Mar 15, 7:05 AM
View All Files
Subscribers
atul

Details

Reviewers
bartek
tomek
Commits
rCOMM78223f2dd741: [native] [33/40] RN 0.70: Replace old AndroidLifecycleModule with new Expo one
Summary

Context about this new Expo module in D5932.

Depends on D5933

Test Plan

I patched the following into native/root.react.js:

import * as AndroidLifecycleModule from './lifecycle/lifecycle-module';

if (Platform.OS === 'android') {
  console.log(`androidLifecycle.ACTIVE: ${AndroidLifecycleModule.ACTIVE ?? 'null or undefined'}`);
  console.log(`androidLifecycle.initialStatus: ${AndroidLifecycleModule.initialStatus ?? 'null or undefined'}`);
  addLifecycleListener(status => { console.log(`onChange ${status ?? 'null or undefined'}`) });
}

It resulted in the following output after I started, then backgrounded, and then foregrounded the app:

LOG  androidLifecycle.ACTIVE: active
LOG  androidLifecycle.initialStatus: active
LOG  onChange background
LOG  onChange active

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 19 2022, 7:05 AM
Herald added a subscriber: atul. · View Herald TranscriptDec 19 2022, 7:05 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:06 AM
Harbormaster failed remote builds in B14318: Diff 19561!
ashoat added a child revision: D5935: [native] [34/40] RN 0.70: Update to react-native-gesture-handler@2.8.0.Dec 19 2022, 7:17 AM
ashoat updated this revision to Diff 19606.Dec 19 2022, 8:22 AM

Rebase

ashoat updated this revision to Diff 19639.Dec 19 2022, 8:39 AM

Rebase

Harbormaster failed remote builds in B14357: Diff 19606!Dec 19 2022, 8:43 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:11 AM
Harbormaster failed remote builds in B14390: Diff 19639!
ashoat requested review of this revision.Dec 19 2022, 9:13 AM

Please ignore CI until the end of the stack

ashoat updated this revision to Diff 19663.Dec 19 2022, 10:02 AM

Rebase

Harbormaster failed remote builds in B14412: Diff 19663!Dec 19 2022, 10:03 AM
ashoat updated this revision to Diff 19674.Dec 19 2022, 10:23 AM

Rebase

Harbormaster failed remote builds in B14422: Diff 19674!Dec 19 2022, 11:10 AM
bartek accepted this revision.Dec 19 2022, 12:12 PM
This revision is now accepted and ready to land.Dec 19 2022, 12:12 PM
ashoat updated this revision to Diff 19712.Dec 19 2022, 12:30 PM

Rebase

Harbormaster failed remote builds in B14457: Diff 19712!Dec 19 2022, 12:53 PM
ashoat updated this revision to Diff 19736.Dec 19 2022, 3:36 PM

Rebase

Harbormaster completed remote builds in B14480: Diff 19736.Dec 19 2022, 3:50 PM
ashoat updated this revision to Diff 19770.Dec 20 2022, 6:23 AM

Rebase

Harbormaster completed remote builds in B14513: Diff 19770.Dec 20 2022, 6:50 AM
tomek accepted this revision.Dec 20 2022, 8:48 AM
ashoat updated this revision to Diff 19832.Dec 20 2022, 11:03 AM

Rebase

Harbormaster completed remote builds in B14572: Diff 19832.Dec 20 2022, 11:44 AM
Closed by commit rCOMM78223f2dd741: [native] [33/40] RN 0.70: Replace old AndroidLifecycleModule with new Expo one (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM78223f2dd741: [native] [33/40] RN 0.70: Replace old AndroidLifecycleModule with new Expo one.

Revision Contents
Changeset List

PathSize
native/
android/
app/
3 lines
src/
main/
java/
app/
comm/
android/
1 line
lifecycle/
13 lines

Diff 19663

View Options

native/android/app/build.gradle

  • This file was added.
div.containerViewerLiked {
padding: 4px;
border-radius: 4px;
background-color: var(--shades-black-80);
}
div.container:hover {
cursor: pointer;
}
tomekUnsubmitted
Not Done
Inline Actions

For other tooltip actions we don't need to manually set this style. Can we use the mechanism we already have, or are there any reasons for not doing so?

tomek: For other tooltip actions we don't need to manually set this style. Can we use the mechanism we…
ginsuAuthorUnsubmitted
Done
Inline Actions

I believe the other icons don't need to set this style because it is built into IcomoonReact. When I switched the Like action tooltip button with one of the icons the hover style just works out of the box. Wondering if @atul has more context since he is pretty familiar with the icons stuff

ginsu: I believe the other icons don't need to set this style because it is built into `IcomoonReact`.
tomekUnsubmitted
Not Done
Inline Actions

It wouldn't make too much sense for Icomoon to provide hover effects for icons because they could be used in other places - not only as buttons. It seems like the style on hover is applied in message-tooltip.css

div.messageActionButtons svg:hover {
  cursor: pointer;
  color: var(--fg);
}

so it should be enough to apply this style also to the new button.

tomek: It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they…
ginsuAuthorUnsubmitted
Done
Inline Actions

Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes

ginsu: Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes
View Options

native/android/app/src/main/java/app/comm/android/AndroidLifecycleModule.java

  • This file was added.
div.containerViewerLiked {
padding: 4px;
border-radius: 4px;
background-color: var(--shades-black-80);
}
div.container:hover {
cursor: pointer;
}
tomekUnsubmitted
Not Done
Inline Actions

For other tooltip actions we don't need to manually set this style. Can we use the mechanism we already have, or are there any reasons for not doing so?

tomek: For other tooltip actions we don't need to manually set this style. Can we use the mechanism we…
ginsuAuthorUnsubmitted
Done
Inline Actions

I believe the other icons don't need to set this style because it is built into IcomoonReact. When I switched the Like action tooltip button with one of the icons the hover style just works out of the box. Wondering if @atul has more context since he is pretty familiar with the icons stuff

ginsu: I believe the other icons don't need to set this style because it is built into `IcomoonReact`.
tomekUnsubmitted
Not Done
Inline Actions

It wouldn't make too much sense for Icomoon to provide hover effects for icons because they could be used in other places - not only as buttons. It seems like the style on hover is applied in message-tooltip.css

div.messageActionButtons svg:hover {
  cursor: pointer;
  color: var(--fg);
}

so it should be enough to apply this style also to the new button.

tomek: It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they…
ginsuAuthorUnsubmitted
Done
Inline Actions

Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes

ginsu: Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes
View Options

native/android/app/src/main/java/app/comm/android/CommPackage.java

  • This file was added.
div.containerViewerLiked {
padding: 4px;
border-radius: 4px;
background-color: var(--shades-black-80);
}
div.container:hover {
cursor: pointer;
}
tomekUnsubmitted
Not Done
Inline Actions

For other tooltip actions we don't need to manually set this style. Can we use the mechanism we already have, or are there any reasons for not doing so?

tomek: For other tooltip actions we don't need to manually set this style. Can we use the mechanism we…
ginsuAuthorUnsubmitted
Done
Inline Actions

I believe the other icons don't need to set this style because it is built into IcomoonReact. When I switched the Like action tooltip button with one of the icons the hover style just works out of the box. Wondering if @atul has more context since he is pretty familiar with the icons stuff

ginsu: I believe the other icons don't need to set this style because it is built into `IcomoonReact`.
tomekUnsubmitted
Not Done
Inline Actions

It wouldn't make too much sense for Icomoon to provide hover effects for icons because they could be used in other places - not only as buttons. It seems like the style on hover is applied in message-tooltip.css

div.messageActionButtons svg:hover {
  cursor: pointer;
  color: var(--fg);
}

so it should be enough to apply this style also to the new button.

tomek: It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they…
ginsuAuthorUnsubmitted
Done
Inline Actions

Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes

ginsu: Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes
View Options

native/android/app/src/main/java/app/comm/android/MainApplication.java

  • This file was added.
div.containerViewerLiked {
padding: 4px;
border-radius: 4px;
background-color: var(--shades-black-80);
}
div.container:hover {
cursor: pointer;
}
tomekUnsubmitted
Not Done
Inline Actions

For other tooltip actions we don't need to manually set this style. Can we use the mechanism we already have, or are there any reasons for not doing so?

tomek: For other tooltip actions we don't need to manually set this style. Can we use the mechanism we…
ginsuAuthorUnsubmitted
Done
Inline Actions

I believe the other icons don't need to set this style because it is built into IcomoonReact. When I switched the Like action tooltip button with one of the icons the hover style just works out of the box. Wondering if @atul has more context since he is pretty familiar with the icons stuff

ginsu: I believe the other icons don't need to set this style because it is built into `IcomoonReact`.
tomekUnsubmitted
Not Done
Inline Actions

It wouldn't make too much sense for Icomoon to provide hover effects for icons because they could be used in other places - not only as buttons. It seems like the style on hover is applied in message-tooltip.css

div.messageActionButtons svg:hover {
  cursor: pointer;
  color: var(--fg);
}

so it should be enough to apply this style also to the new button.

tomek: It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they…
ginsuAuthorUnsubmitted
Done
Inline Actions

Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes

ginsu: Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes
View Options

native/lifecycle/lifecycle-event-emitter.js

Loading...
View Options

native/lifecycle/lifecycle.js

Loading...