Adds validators for server socket messages with tests, and enables output validation in the socket implementation.
Depends on D7714
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMM018eff6c2ed6: [keyserver] Validate websocket output
Check if web and ios app work fine, and there aren't any errors.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/socket/socket.js | ||
|---|---|---|
| 380–392 ↗ | (On Diff #26241) | If there's no viewer we can't be sure if we want to convert the ids (could be an old client). But this should happen only in case of an error, and none of the error payloads contain ids. |
| lib/types/socket-types.js | ||
| 407 ↗ | (On Diff #26241) | The payload from the responders will be converted already. |
| keyserver/src/socket/socket.js | ||
|---|---|---|
| 380–392 ↗ | (On Diff #26241) | I guess we can still validate the response. There's nothing wrong in doing that. |
Comment Actions
- Validate also when viewer is null (when error socket message is sent)
- APIResponseServerSocketMessage can have no payload (for example when calling deviceTokenUpdateResponder which returns void). Updated the socket type and the validator to match this