Page MenuHomePhabricator
Differential D5902

[native] [8/40] RN 0.70: Ruby 2.7.5
ClosedPublic
Actions

Authored by ashoat on Dec 17 2022, 7:48 PM.
Tags
None
Referenced Files
F5247199: D5902.diff
Sat, Apr 5, 11:28 PM
Unknown Object (File)
Thu, Apr 3, 5:12 PM
Unknown Object (File)
Mon, Mar 31, 5:11 PM
Unknown Object (File)
Sat, Mar 15, 7:35 AM
Unknown Object (File)
Mar 3 2025, 5:55 PM
Unknown Object (File)
Mar 3 2025, 5:55 PM
Unknown Object (File)
Mar 3 2025, 5:55 PM
Unknown Object (File)
Mar 3 2025, 5:55 PM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
• jon
Commits
rCOMM947d6dacdec9: [native] [8/40] RN 0.70: Ruby 2.7.5
Summary

This came from React Native Upgrade Helper

Depends on D5901

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 17 2022, 7:48 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 7:48 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:49 PM
Harbormaster failed remote builds in B14231: Diff 19465!
ashoat added a child revision: D5903: [native] [9/40] RN 0.70: Update eslint to 7.32.0.Dec 17 2022, 7:50 PM
ashoat requested review of this revision.Dec 17 2022, 8:08 PM
ashoat added a reviewer: • jon.

Please ignore CI until the end of the stack

ashoat updated this revision to Diff 19519.Dec 18 2022, 8:27 PM

Rebase

Harbormaster failed remote builds in B14280: Diff 19519!Dec 18 2022, 8:43 PM
ashoat updated this revision to Diff 19581.Dec 19 2022, 8:19 AM

Rebase

Harbormaster failed remote builds in B14332: Diff 19581!Dec 19 2022, 8:23 AM
bartek added a comment.Dec 19 2022, 8:30 AM
  • Shouldn't Gemfile.lock be affected?
  • Leaving this to @jon as I'm not sure if Nix environment require any additional changes
ashoat updated this revision to Diff 19614.Dec 19 2022, 8:35 AM

Add Gemfile.lock

tomek accepted this revision.Dec 19 2022, 8:42 AM
This revision is now accepted and ready to land.Dec 19 2022, 8:42 AM
Harbormaster failed remote builds in B14365: Diff 19614!Dec 19 2022, 8:52 AM
ashoat updated this revision to Diff 19655.Dec 19 2022, 9:51 AM

Rebase

Harbormaster failed remote builds in B14404: Diff 19655!Dec 19 2022, 9:54 AM
ashoat updated this revision to Diff 19807.Dec 20 2022, 11:00 AM

Rebase

Harbormaster failed remote builds in B14547: Diff 19807!Dec 20 2022, 11:06 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
Closed by commit rCOMM947d6dacdec9: [native] [8/40] RN 0.70: Ruby 2.7.5 (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM947d6dacdec9: [native] [8/40] RN 0.70: Ruby 2.7.5.

Revision Contents
Changeset List

PathSize
native/
2 lines

Diff 19465

View Options

native/Gemfile

Show First 20 Lines • Show All 396 Lines • ▼ Show 20 Lines async ensureAndroidPushNotifsEnabled() {
let [hasPermission] = permissionPromisesResult; let [hasPermission] = permissionPromisesResult;
const [, canRequestPermission] = permissionPromisesResult; const [, canRequestPermission] = permissionPromisesResult;
if (!hasPermission && canRequestPermission) { if (!hasPermission && canRequestPermission) {
const permissionResponse = await (async () => { const permissionResponse = await (async () => {
// We issue a call to sleep to match iOS behavior where prompt // We issue a call to sleep to match iOS behavior where prompt
// doesn't appear immediately but after logged-out modal disappears // doesn't appear immediately but after logged-out modal disappears
await sleep(10); await sleep(10);
await this.requestAndroidNotificationsPermission(); return await this.requestAndroidNotificationsPermission();
marcinUnsubmitted
Not Done
Inline Actions

We definitely should return something from this lambda since otherwise it is useless to assign it to variable.

When we find we don't have Android notif permissions, we ignore the result of requestAndroidNotificationsPermission. It seems like that would cause us to fail to register notif permissions on Android.

If we find that we don't have permissions then just calling await this.requestAndroidNotificationsPermission(); would result in a prompt asking for notifications permissions. However if the user grants those permissions then hasPermissions is still falsy (since promise returned nothing), so deviceToken will be set to null. Nevertheless permissions are actually granted byt the OS, so the state on the device and keyserver would heal itself on next render.

This differential fixes this case so that if user grants permissions correct state is achieved immediately without need for additional re-render to heal the state.

marcin: We definitely should return something from this lambda since otherwise it is useless to assign…
})(); })();
hasPermission = permissionResponse; hasPermission = permissionResponse;
} }
if (!hasPermission) { if (!hasPermission) {
this.failedToRegisterPushPermissionsAndroid(!canRequestPermission); this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);
return; return;
} }
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines