Page MenuHomePhabricator

[native] [37/40] RN 0.70: Update to react-native-floating-action@1.22.0
ClosedPublic

Authored by ashoat on Dec 19 2022, 7:23 AM.
Tags
None
Referenced Files
F3346287: D5938.id19740.diff
Fri, Nov 22, 8:12 AM
F3346283: D5938.id19643.diff
Fri, Nov 22, 8:11 AM
F3346275: D5938.id19716.diff
Fri, Nov 22, 8:08 AM
F3346270: D5938.id19678.diff
Fri, Nov 22, 8:07 AM
F3346087: D5938.id19610.diff
Fri, Nov 22, 7:57 AM
F3342767: D5938.diff
Fri, Nov 22, 2:01 AM
Unknown Object (File)
Wed, Nov 20, 4:09 PM
Unknown Object (File)
Wed, Nov 20, 3:16 PM
Subscribers

Details

Summary

npx @rnx-kit/dep-check --write recommended this.

Depends on D5937

Test Plan

The Release Notes on GitHub have not been well maintained, so I checked the commit log instead. There are three PRs that have been merged in the new version (1, 2, 3) and none of them seem like breaking changes. I also tested the button on Android on both debug and release builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:24 AM
Harbormaster failed remote builds in B14323: Diff 19566!
ashoat published this revision for review.Dec 19 2022, 9:13 AM

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 3:47 AM