Page MenuHomePhabricator
Differential D5939

[native] [38/40] RN 0.70: Update to react-native-fs@2.20.0
ClosedPublic
Actions

Authored by ashoat on Dec 19 2022, 7:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 8:32 AM
Unknown Object (File)
Sat, Mar 15, 7:05 AM
Unknown Object (File)
Thu, Mar 13, 1:05 PM
Unknown Object (File)
Thu, Mar 13, 6:02 AM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM2df6942d28eb: [native] [38/40] RN 0.70: Update to react-native-fs@2.20.0
Summary

npx @rnx-kit/dep-check --write recommended upgrading this package (albeit to a lower version).

Depends on D5938

Test Plan
  1. I reviewed the Release Notes and found no breaking changes
  2. I tested a bunch of react-native-fs stuff relating to media on both iOS and Android
  3. Tested along with whole stack: test plan (includes saving media)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 19 2022, 7:24 AM
Herald added a subscriber: atul. · View Herald TranscriptDec 19 2022, 7:24 AM
ashoat added a child revision: D5940: [native] [39/40] RN 0.70: Update to @react-native-community/netinfo@9.3.7.Dec 19 2022, 7:25 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:25 AM
Harbormaster failed remote builds in B14324: Diff 19567!
ashoat updated this revision to Diff 19611.Dec 19 2022, 8:23 AM

Rebase

ashoat updated this revision to Diff 19644.Dec 19 2022, 8:39 AM

Rebase

Harbormaster failed remote builds in B14362: Diff 19611!Dec 19 2022, 8:47 AM
ashoat published this revision for review.Dec 19 2022, 9:13 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14395: Diff 19644!Dec 19 2022, 9:16 AM
ashoat updated this revision to Diff 19668.Dec 19 2022, 10:02 AM

Rebase

Harbormaster failed remote builds in B14417: Diff 19668!Dec 19 2022, 10:06 AM
ashoat updated this revision to Diff 19679.Dec 19 2022, 10:24 AM

Rebase

Harbormaster failed remote builds in B14427: Diff 19679!Dec 19 2022, 11:19 AM
ashoat updated this revision to Diff 19717.Dec 19 2022, 12:31 PM

Rebase

Harbormaster failed remote builds in B14462: Diff 19717!Dec 19 2022, 12:59 PM
ashoat updated this revision to Diff 19741.Dec 19 2022, 3:37 PM

Rebase

Harbormaster completed remote builds in B14485: Diff 19741.Dec 19 2022, 3:52 PM
bartek accepted this revision.Dec 20 2022, 3:48 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:48 AM
ashoat updated this revision to Diff 19775.Dec 20 2022, 6:24 AM

Rebase

Harbormaster completed remote builds in B14518: Diff 19775.Dec 20 2022, 6:58 AM
tomek accepted this revision.Dec 20 2022, 9:03 AM
ashoat updated this revision to Diff 19837.Dec 20 2022, 11:04 AM

Rebase

Harbormaster completed remote builds in B14577: Diff 19837.Dec 20 2022, 11:52 AM
Closed by commit rCOMM2df6942d28eb: [native] [38/40] RN 0.70: Update to react-native-fs@2.20.0 (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM2df6942d28eb: [native] [38/40] RN 0.70: Update to react-native-fs@2.20.0.

Revision Contents
Changeset List

PathSize
native/
ios/
6 lines
2 lines
8 lines

Diff 19644

View Options

native/ios/Podfile.lock

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import type { ClientDBMessageStoreOperation } from 'lib/ops/message-store-ops.js'; import type { ClientDBMessageStoreOperation } from 'lib/ops/message-store-ops.js';
import type { ClientDBThreadStoreOperation } from 'lib/ops/thread-store-ops.js';
import type { import type {
RawMessageInfo, RawMessageInfo,
ClientDBMessageInfo, ClientDBMessageInfo,
ClientDBThreadMessageInfo, ClientDBThreadMessageInfo,
} from 'lib/types/message-types.js'; } from 'lib/types/message-types.js';
import type {
ClientDBThreadInfo,
RawThreadInfos,
} from 'lib/types/thread-types.js';
import { import {
translateClientDBMessageInfoToRawMessageInfo, translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo, translateRawMessageInfoToClientDBMessageInfo,
translateClientDBThreadMessageInfos, translateClientDBThreadMessageInfos,
translateThreadMessageInfoToClientDBThreadMessageInfo, translateThreadMessageInfoToClientDBThreadMessageInfo,
type TranslatedThreadMessageInfos, type TranslatedThreadMessageInfos,
} from 'lib/utils/message-ops-utils.js'; } from 'lib/utils/message-ops-utils.js';
import { entries } from 'lib/utils/objects.js'; import { entries, values } from 'lib/utils/objects.js';
import {
convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo,
} from 'lib/utils/thread-ops-utils.js';
function createUpdateDBOpsForThreadStoreThreadInfos(
clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>,
migrationFunc: RawThreadInfos => RawThreadInfos,
): $ReadOnlyArray<ClientDBThreadStoreOperation> {
// 1. Translate `ClientDBThreadInfo`s to `RawThreadInfo`s.
const rawThreadInfos = clientDBThreadInfos.map(
convertClientDBThreadInfoToRawThreadInfo,
);
// 2. Convert `RawThreadInfo`s to a map of `threadID` => `threadInfo`.
const keyedRawThreadInfos = _keyBy('id')(rawThreadInfos);
// 3. Apply `migrationFunc` to `ThreadInfo`s.
const updatedKeyedRawThreadInfos = migrationFunc(keyedRawThreadInfos);
// 4. Convert the updated `RawThreadInfos` back into an array.
const updatedKeyedRawThreadInfosArray = values(updatedKeyedRawThreadInfos);
// 5. Translate `RawThreadInfo`s back to `ClientDBThreadInfo`s.
const updatedClientDBThreadInfos = updatedKeyedRawThreadInfosArray.map(
convertRawThreadInfoToClientDBThreadInfo,
);
// 6. Construct `replace` `ClientDBThreadStoreOperation`s.
const replaceThreadOperations = updatedClientDBThreadInfos.map(thread => ({
type: 'replace',
payload: thread,
}));
// 7. Prepend `replaceThreadOperations` with `remove_all` op and return.
return [{ type: 'remove_all' }, ...replaceThreadOperations];
}
function createUpdateDBOpsForMessageStoreMessages( function createUpdateDBOpsForMessageStoreMessages(
clientDBMessageInfos: $ReadOnlyArray<ClientDBMessageInfo>, clientDBMessageInfos: $ReadOnlyArray<ClientDBMessageInfo>,
migrationFunc: ( migrationFunc: (
$ReadOnlyArray<RawMessageInfo>, $ReadOnlyArray<RawMessageInfo>,
) => $ReadOnlyArray<RawMessageInfo>, ) => $ReadOnlyArray<RawMessageInfo>,
): $ReadOnlyArray<ClientDBMessageStoreOperation> { ): $ReadOnlyArray<ClientDBMessageStoreOperation> {
const rawMessageInfos = clientDBMessageInfos.map( const rawMessageInfos = clientDBMessageInfos.map(
Show All 39 Lines return [
translateThreadMessageInfoToClientDBThreadMessageInfo(id, thread), translateThreadMessageInfoToClientDBThreadMessageInfo(id, thread),
), ),
}, },
}, },
]; ];
} }
export { export {
createUpdateDBOpsForThreadStoreThreadInfos,
createUpdateDBOpsForMessageStoreMessages, createUpdateDBOpsForMessageStoreMessages,
createUpdateDBOpsForMessageStoreThreads, createUpdateDBOpsForMessageStoreThreads,
}; };
View Options

native/package.json

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import type { ClientDBMessageStoreOperation } from 'lib/ops/message-store-ops.js'; import type { ClientDBMessageStoreOperation } from 'lib/ops/message-store-ops.js';
import type { ClientDBThreadStoreOperation } from 'lib/ops/thread-store-ops.js';
import type { import type {
RawMessageInfo, RawMessageInfo,
ClientDBMessageInfo, ClientDBMessageInfo,
ClientDBThreadMessageInfo, ClientDBThreadMessageInfo,
} from 'lib/types/message-types.js'; } from 'lib/types/message-types.js';
import type {
ClientDBThreadInfo,
RawThreadInfos,
} from 'lib/types/thread-types.js';
import { import {
translateClientDBMessageInfoToRawMessageInfo, translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo, translateRawMessageInfoToClientDBMessageInfo,
translateClientDBThreadMessageInfos, translateClientDBThreadMessageInfos,
translateThreadMessageInfoToClientDBThreadMessageInfo, translateThreadMessageInfoToClientDBThreadMessageInfo,
type TranslatedThreadMessageInfos, type TranslatedThreadMessageInfos,
} from 'lib/utils/message-ops-utils.js'; } from 'lib/utils/message-ops-utils.js';
import { entries } from 'lib/utils/objects.js'; import { entries, values } from 'lib/utils/objects.js';
import {
convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo,
} from 'lib/utils/thread-ops-utils.js';
function createUpdateDBOpsForThreadStoreThreadInfos(
clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>,
migrationFunc: RawThreadInfos => RawThreadInfos,
): $ReadOnlyArray<ClientDBThreadStoreOperation> {
// 1. Translate `ClientDBThreadInfo`s to `RawThreadInfo`s.
const rawThreadInfos = clientDBThreadInfos.map(
convertClientDBThreadInfoToRawThreadInfo,
);
// 2. Convert `RawThreadInfo`s to a map of `threadID` => `threadInfo`.
const keyedRawThreadInfos = _keyBy('id')(rawThreadInfos);
// 3. Apply `migrationFunc` to `ThreadInfo`s.
const updatedKeyedRawThreadInfos = migrationFunc(keyedRawThreadInfos);
// 4. Convert the updated `RawThreadInfos` back into an array.
const updatedKeyedRawThreadInfosArray = values(updatedKeyedRawThreadInfos);
// 5. Translate `RawThreadInfo`s back to `ClientDBThreadInfo`s.
const updatedClientDBThreadInfos = updatedKeyedRawThreadInfosArray.map(
convertRawThreadInfoToClientDBThreadInfo,
);
// 6. Construct `replace` `ClientDBThreadStoreOperation`s.
const replaceThreadOperations = updatedClientDBThreadInfos.map(thread => ({
type: 'replace',
payload: thread,
}));
// 7. Prepend `replaceThreadOperations` with `remove_all` op and return.
return [{ type: 'remove_all' }, ...replaceThreadOperations];
}
function createUpdateDBOpsForMessageStoreMessages( function createUpdateDBOpsForMessageStoreMessages(
clientDBMessageInfos: $ReadOnlyArray<ClientDBMessageInfo>, clientDBMessageInfos: $ReadOnlyArray<ClientDBMessageInfo>,
migrationFunc: ( migrationFunc: (
$ReadOnlyArray<RawMessageInfo>, $ReadOnlyArray<RawMessageInfo>,
) => $ReadOnlyArray<RawMessageInfo>, ) => $ReadOnlyArray<RawMessageInfo>,
): $ReadOnlyArray<ClientDBMessageStoreOperation> { ): $ReadOnlyArray<ClientDBMessageStoreOperation> {
const rawMessageInfos = clientDBMessageInfos.map( const rawMessageInfos = clientDBMessageInfos.map(
Show All 39 Lines return [
translateThreadMessageInfoToClientDBThreadMessageInfo(id, thread), translateThreadMessageInfoToClientDBThreadMessageInfo(id, thread),
), ),
}, },
}, },
]; ];
} }
export { export {
createUpdateDBOpsForThreadStoreThreadInfos,
createUpdateDBOpsForMessageStoreMessages, createUpdateDBOpsForMessageStoreMessages,
createUpdateDBOpsForMessageStoreThreads, createUpdateDBOpsForMessageStoreThreads,
}; };
View Options

yarn.lock

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import type { ClientDBMessageStoreOperation } from 'lib/ops/message-store-ops.js'; import type { ClientDBMessageStoreOperation } from 'lib/ops/message-store-ops.js';
import type { ClientDBThreadStoreOperation } from 'lib/ops/thread-store-ops.js';
import type { import type {
RawMessageInfo, RawMessageInfo,
ClientDBMessageInfo, ClientDBMessageInfo,
ClientDBThreadMessageInfo, ClientDBThreadMessageInfo,
} from 'lib/types/message-types.js'; } from 'lib/types/message-types.js';
import type {
ClientDBThreadInfo,
RawThreadInfos,
} from 'lib/types/thread-types.js';
import { import {
translateClientDBMessageInfoToRawMessageInfo, translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo, translateRawMessageInfoToClientDBMessageInfo,
translateClientDBThreadMessageInfos, translateClientDBThreadMessageInfos,
translateThreadMessageInfoToClientDBThreadMessageInfo, translateThreadMessageInfoToClientDBThreadMessageInfo,
type TranslatedThreadMessageInfos, type TranslatedThreadMessageInfos,
} from 'lib/utils/message-ops-utils.js'; } from 'lib/utils/message-ops-utils.js';
import { entries } from 'lib/utils/objects.js'; import { entries, values } from 'lib/utils/objects.js';
import {
convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo,
} from 'lib/utils/thread-ops-utils.js';
function createUpdateDBOpsForThreadStoreThreadInfos(
clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>,
migrationFunc: RawThreadInfos => RawThreadInfos,
): $ReadOnlyArray<ClientDBThreadStoreOperation> {
// 1. Translate `ClientDBThreadInfo`s to `RawThreadInfo`s.
const rawThreadInfos = clientDBThreadInfos.map(
convertClientDBThreadInfoToRawThreadInfo,
);
// 2. Convert `RawThreadInfo`s to a map of `threadID` => `threadInfo`.
const keyedRawThreadInfos = _keyBy('id')(rawThreadInfos);
// 3. Apply `migrationFunc` to `ThreadInfo`s.
const updatedKeyedRawThreadInfos = migrationFunc(keyedRawThreadInfos);
// 4. Convert the updated `RawThreadInfos` back into an array.
const updatedKeyedRawThreadInfosArray = values(updatedKeyedRawThreadInfos);
// 5. Translate `RawThreadInfo`s back to `ClientDBThreadInfo`s.
const updatedClientDBThreadInfos = updatedKeyedRawThreadInfosArray.map(
convertRawThreadInfoToClientDBThreadInfo,
);
// 6. Construct `replace` `ClientDBThreadStoreOperation`s.
const replaceThreadOperations = updatedClientDBThreadInfos.map(thread => ({
type: 'replace',
payload: thread,
}));
// 7. Prepend `replaceThreadOperations` with `remove_all` op and return.
return [{ type: 'remove_all' }, ...replaceThreadOperations];
}
function createUpdateDBOpsForMessageStoreMessages( function createUpdateDBOpsForMessageStoreMessages(
clientDBMessageInfos: $ReadOnlyArray<ClientDBMessageInfo>, clientDBMessageInfos: $ReadOnlyArray<ClientDBMessageInfo>,
migrationFunc: ( migrationFunc: (
$ReadOnlyArray<RawMessageInfo>, $ReadOnlyArray<RawMessageInfo>,
) => $ReadOnlyArray<RawMessageInfo>, ) => $ReadOnlyArray<RawMessageInfo>,
): $ReadOnlyArray<ClientDBMessageStoreOperation> { ): $ReadOnlyArray<ClientDBMessageStoreOperation> {
const rawMessageInfos = clientDBMessageInfos.map( const rawMessageInfos = clientDBMessageInfos.map(
Show All 39 Lines return [
translateThreadMessageInfoToClientDBThreadMessageInfo(id, thread), translateThreadMessageInfoToClientDBThreadMessageInfo(id, thread),
), ),
}, },
}, },
]; ];
} }
export { export {
createUpdateDBOpsForThreadStoreThreadInfos,
createUpdateDBOpsForMessageStoreMessages, createUpdateDBOpsForMessageStoreMessages,
createUpdateDBOpsForMessageStoreThreads, createUpdateDBOpsForMessageStoreThreads,
}; };