Details

Reviewers

tomek
bartek

Commits

rCOMMf4d6e6abba09: [native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash

Summary

Our old version of react-native-camera was erroring due to an import of ViewPropTypes from react-native, which has been deprecated. I tried to update it, but that didn't fix the issue, so I added a patch. Then I realized the update broke the Android build, so I took it out.

This package appears to have been deprecated sometime in the last year. ENG-1520 tracks the long-term solution, but I don't have the cycles to handle that right now unfortunately.

Depends on D5921

Test Plan

Confirm JS error due to ViewPropTypes import no longer occurs
Tested along with whole stack: test plan (includes testing camera functionality)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 18 2022, 7:53 PM

Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 7:53 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:53 PM

Harbormaster failed remote builds in B14251: Diff 19490!

ashoat added a child revision: D5923: [native] [28/40] RN 0.70: Fix Expo 47 SecureStore crash on Android.Dec 18 2022, 7:57 PM

ashoat retitled this revision from [native] [26/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash to [native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash.Dec 18 2022, 8:05 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:32 PM

Harbormaster failed remote builds in B14272: Diff 19511!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:58 PM

Harbormaster failed remote builds in B14299: Diff 19538!

Rebase