Page MenuHomePhabricator
Differential D5938

[native] [37/40] RN 0.70: Update to react-native-floating-action@1.22.0
ClosedPublic
Actions

Authored by ashoat on Dec 19 2022, 7:23 AM.
Tags
None
Referenced Files
F3342767: D5938.diff
Fri, Nov 22, 2:01 AM
Unknown Object (File)
Wed, Nov 20, 4:09 PM
Unknown Object (File)
Wed, Nov 20, 3:16 PM
Unknown Object (File)
Thu, Nov 14, 10:14 AM
Unknown Object (File)
Thu, Nov 14, 10:05 AM
Unknown Object (File)
Thu, Nov 14, 10:05 AM
Unknown Object (File)
Thu, Nov 14, 10:00 AM
Unknown Object (File)
Thu, Nov 14, 9:44 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMMaf61b971981d: [native] [37/40] RN 0.70: Update to react-native-floating-action@1.22.0
Summary

npx @rnx-kit/dep-check --write recommended this.

Depends on D5937

Test Plan

The Release Notes on GitHub have not been well maintained, so I checked the commit log instead. There are three PRs that have been merged in the new version (1, 2, 3) and none of them seem like breaking changes. I also tested the button on Android on both debug and release builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 19 2022, 7:23 AM
Herald added a subscriber: atul. · View Herald TranscriptDec 19 2022, 7:23 AM
ashoat added a child revision: D5939: [native] [38/40] RN 0.70: Update to react-native-fs@2.20.0.Dec 19 2022, 7:24 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:24 AM
Harbormaster failed remote builds in B14323: Diff 19566!
ashoat updated this revision to Diff 19610.Dec 19 2022, 8:23 AM

Rebase

ashoat updated this revision to Diff 19643.Dec 19 2022, 8:39 AM

Rebase

Harbormaster failed remote builds in B14361: Diff 19610!Dec 19 2022, 8:47 AM
ashoat published this revision for review.Dec 19 2022, 9:13 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14394: Diff 19643!Dec 19 2022, 9:15 AM
ashoat updated this revision to Diff 19667.Dec 19 2022, 10:02 AM

Rebase

Harbormaster failed remote builds in B14416: Diff 19667!Dec 19 2022, 10:06 AM
ashoat updated this revision to Diff 19678.Dec 19 2022, 10:24 AM

Rebase

Harbormaster failed remote builds in B14426: Diff 19678!Dec 19 2022, 11:18 AM
ashoat updated this revision to Diff 19716.Dec 19 2022, 12:31 PM

Rebase

Harbormaster completed remote builds in B14461: Diff 19716.Dec 19 2022, 1:00 PM
ashoat updated this revision to Diff 19740.Dec 19 2022, 3:37 PM

Rebase

Harbormaster completed remote builds in B14484: Diff 19740.Dec 19 2022, 3:50 PM
bartek accepted this revision.Dec 20 2022, 3:47 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:47 AM
ashoat updated this revision to Diff 19774.Dec 20 2022, 6:23 AM

Rebase

Harbormaster completed remote builds in B14517: Diff 19774.Dec 20 2022, 6:59 AM
tomek accepted this revision.Dec 20 2022, 9:01 AM
ashoat updated this revision to Diff 19836.Dec 20 2022, 11:03 AM

Rebase

Harbormaster completed remote builds in B14576: Diff 19836.Dec 20 2022, 11:51 AM
Closed by commit rCOMMaf61b971981d: [native] [37/40] RN 0.70: Update to react-native-floating-action@1.22.0 (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMaf61b971981d: [native] [37/40] RN 0.70: Update to react-native-floating-action@1.22.0.

Revision Contents
Changeset List

PathSize
native/
2 lines
8 lines

Diff 19740

View Options

native/package.json

Loading...
View Options

yarn.lock

Loading...