These are the Android changes from React Native Upgrade Helper. Exceptions to that are highlighted inline.
Depends on D5897
Details
Details
- Reviewers
tomek bartek - Commits
- rCOMM3773e96bdb12: [native] [4/40] RN 0.70: Android stuff
Tested along with whole stack: test plan
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/android/app/CMakeLists.txt | ||
|---|---|---|
| 145 ↗ | (On Diff #19461) | This file was moved so we need to update where we're pointing to |
| native/android/app/build.gradle | ||
| 84 ↗ | (On Diff #19461) | To confirm this was safe to remove, I first set it to some incorrect value to see what the error condition would be. I then confirmed that the error condition did not occur with the default value (eg. after I removed the custom value) |
| 86 ↗ | (On Diff #19461) | To confirm this was safe to remove, I first set it to some incorrect value to see what the error condition would be. I then confirmed that the error condition did not occur with the default value (eg. after I removed the custom value) For this one, I also did some code sleuthing to see where this was used, and added a log statement to make sure it was being done correctly |
Comment Actions
Fix cmake-lint error due to line in new file native/android/app/src/main/jni/CMakeLists.txt
| native/android/app/src/main/java/app/comm/android/MainActivity.java | ||
|---|---|---|
| 27–30 ↗ | (On Diff #19515) | Why is this method commented out? In the guide it is present. |
| native/android/app/src/main/java/app/comm/android/MainActivity.java | ||
|---|---|---|
| 27–30 ↗ | (On Diff #19515) | Oops, good catch. D5935 updates our createReactActivityDelegate to use MainActivityDelegate, but that's the wrong place to do it... and there is still commented-out code even after that change. I'll fix this up |