Paths

Table of Contentst

Differential D7655

[lib] Add validator to the message spec
ClosedPublic
Actions

Authored by michal on Apr 27 2023, 6:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 29, 7:15 AM

	Unknown Object (File)
	Fri, Nov 29, 7:08 AM

	Unknown Object (File)
	Fri, Nov 29, 6:03 AM

	Unknown Object (File)
	Mon, Nov 25, 8:48 PM

	Unknown Object (File)
	Mon, Nov 25, 8:48 PM

	Unknown Object (File)
	Mon, Nov 25, 7:59 PM

	Unknown Object (File)
	Thu, Nov 21, 3:48 PM

	Unknown Object (File)
	Wed, Nov 20, 5:45 PM

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMMce72e5f71c1f: [lib] Add validator to the message spec

Summary

Mentioned in D7567. Adds validators to the message spec and uses them in tests.

Test Plan

Run yarn jest

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Apr 27 2023, 6:28 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 27 2023, 6:28 AM

michal added a parent revision: D7567: [lib] Introduce raw message info validators.Apr 27 2023, 6:29 AM

michal added a child revision: D7569: [lib] Introduce raw thread info validators.

Harbormaster completed remote builds in B18856: Diff 25825.Apr 27 2023, 6:46 AM

michal requested review of this revision.Apr 27 2023, 6:46 AM

Rebase

Harbormaster completed remote builds in B19027: Diff 26058.May 4 2023, 3:27 AM

tomek accepted this revision.May 4 2023, 3:47 AM

tomek added inline comments.

lib/types/validation.test.js
308–314 ↗	(On Diff #26058)	Why do we need this condition?

This revision is now accepted and ready to land.May 4 2023, 3:47 AM

michal added inline comments.May 4 2023, 3:51 AM

lib/types/validation.test.js
308–314 ↗	(On Diff #26058)	`IMAGES` and `MULTIMEDIA` message types have the same `multimediaMessageSpec` message spec, so they have the same validator (which is a union of images validator and multimedia validator). So they accept each other.

Closed by commit rCOMMce72e5f71c1f: [lib] Add validator to the message spec (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 5 2023, 5:46 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMce72e5f71c1f: [lib] Add validator to the message spec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

add-members-message-spec.js

11 lines

change-role-message-spec.js

11 lines

change-settings-message-spec.js

11 lines

create-entry-message-spec.js

11 lines

create-sidebar-message-spec.js

11 lines

create-sub-thread-message-spec.js

11 lines

create-thread-message-spec.js

11 lines

delete-entry-message-spec.js

11 lines

edit-entry-message-spec.js

11 lines

edit-message-spec.js

11 lines

join-thread-message-spec.js

11 lines

leave-thread-message-spec.js

11 lines

message-spec.js

3 lines

multimedia-message-spec.js

7 lines

reaction-message-spec.js

11 lines

remove-members-message-spec.js

11 lines

restore-entry-message-spec.js

11 lines

sidebar-source-message-spec.js

3 lines

text-message-spec.js

11 lines

toggle-pin-message-spec.js

11 lines

unsupported-message-spec.js

9 lines

update-relationship-message-spec.js

11 lines

types/

message-types.js

6 lines

validation.test.js

67 lines

Diff 26110

lib/shared/messages/add-members-message-spec.js

Loading...

lib/shared/messages/change-role-message-spec.js

Loading...

lib/shared/messages/change-settings-message-spec.js

Loading...

lib/shared/messages/create-entry-message-spec.js

Loading...

lib/shared/messages/create-sidebar-message-spec.js

Loading...

lib/shared/messages/create-sub-thread-message-spec.js

Loading...

lib/shared/messages/create-thread-message-spec.js

Loading...

lib/shared/messages/delete-entry-message-spec.js

Loading...

lib/shared/messages/edit-entry-message-spec.js

Loading...

lib/shared/messages/edit-message-spec.js

Loading...

lib/shared/messages/join-thread-message-spec.js

Loading...

lib/shared/messages/leave-thread-message-spec.js

Loading...

lib/shared/messages/message-spec.js

Loading...

lib/shared/messages/multimedia-message-spec.js

Loading...

lib/shared/messages/reaction-message-spec.js

Loading...

lib/shared/messages/remove-members-message-spec.js

Loading...

lib/shared/messages/restore-entry-message-spec.js

Loading...

lib/shared/messages/sidebar-source-message-spec.js

Loading...

lib/shared/messages/text-message-spec.js

Loading...

lib/shared/messages/toggle-pin-message-spec.js

Loading...

lib/shared/messages/unsupported-message-spec.js

Loading...

lib/shared/messages/update-relationship-message-spec.js

Loading...

lib/types/message-types.js

Loading...

lib/types/validation.test.js

Loading...