This permission will be required to create / edit / disable an invite link. We don't need to use descendants feature as only the communities can have an invite link.
Details
Details
Run the migration and check if all the admin roles has this permission.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- invite2
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/redux/update-roles-and-permissions.test.js | ||
|---|---|---|
| 11 | These tests are based on a state exported from @atul's redux - updating it is tricky and I haven't found a good way of doing that. Described it a bit in https://linear.app/comm/issue/ENG-3557/create-a-new-permission. | |
| native/redux/update-roles-and-permissions.test.js | ||
|---|---|---|
| 11 | Created https://linear.app/comm/issue/ENG-3901/rethink-roles-and-permissions-tests to update the tests | |
Comment Actions
This permission should not have been introduced without corresponding changes on the native side to prevent massive inconsistency reports from being generated.
Two other changes should have been included:
- D8006: a redux-persist migration that calls updateClientDBThreadStoreThreadInfos(state, updateRolesAndPermissions) so that native clients add the permission without needing any updates from the keyserver.
- D8007: code on the keyserver to gate the new permission to only clients that can support it and will have it already in Redux due to 1.