Page MenuHomePhabricator

[lib] Add client side boilerplate and reducer for an endpoint that allows creating or updating public links
ClosedPublic

Authored by tomek on May 19 2023, 10:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 8:57 AM
Unknown Object (File)
Wed, Oct 16, 5:10 PM
Unknown Object (File)
Wed, Oct 9, 5:10 AM
Unknown Object (File)
Sun, Oct 6, 9:08 PM
Unknown Object (File)
Sun, Oct 6, 8:24 PM
Unknown Object (File)
Fri, Oct 4, 6:39 AM
Unknown Object (File)
Fri, Oct 4, 6:16 AM
Unknown Object (File)
Oct 1 2024, 9:15 AM
Subscribers

Details

Summary

The only interesting part is that the link in redux is updated after successful call to this endpoint. For that purpose I'm using a link returned by backend, instead of figuring out the values on the client, because at some point we could consider having different defaults.

Depends on D7878

Test Plan

Tested in combination with the rest of the stack. Checking if updating or creating a public link works is enough to verify the correctness.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil added inline comments.
lib/actions/link-actions.js
67–75 ↗(On Diff #26682)

why not return response;?

This revision is now accepted and ready to land.May 22 2023, 2:41 AM
lib/actions/link-actions.js
67–75 ↗(On Diff #26682)

The response may contain more fields and we should make sure that all the other fields are filtered out.