Merge imports

Seems reasonable, but might be a good idea for @varun to take a look.

Have you tested a scenario where externalSignal is used?

Shouldn't this diff have a dependency on D9053? Also, the test plan seems to be incomplete

"Before":

"After":

You can consider using React.memo instead - might be a lot simpler.

Nice!

In D9041#266850, @bartek wrote:

In D9041#266461, @tomek wrote:

Should we also update the docs with the new facts file?

Which docs? Other services' facts don't have any docs IIRC 🤔

Although this change on its own doesn't have important disadvantages, the following diff D8846 makes it worse. The consequence is that we're wasting memory because _memoize remembers the result of each computation, while we only care about the most recent one. So it's better to reintroduce the previous approach.

Should we also update the docs with the new facts file?

Dependencies look ok

Shouldn't we delete QRCodeLinkHandler as a part of this diff?

In D8979#265014, @bartek wrote:

So it means that innerHashKey is defined only for collections, and should be null / undefined for top-level, non-iterable infos

Simplify thread state sync spec

Convert to string explicitly and return null if the entry isn't found

In D8987#265759, @bartek wrote:

In D8987#265730, @tomek wrote:

The license is ok, but the library doesn't have too many downloads and the repo has only 6 stars. It also isn't mentioned by Postmark as official https://postmarkapp.com/developer/integration/official-libraries or community https://postmarkapp.com/developer/integration/community-libraries library. Are there any alternatives? Have we considered sending HTTP requests directly?

There's no official Rust library for Postmark. The service itself offers a REST API over which this library is a thin wrapper. We found it during 1:1 with @ashoat, I quickly looked at its source code and it looks alright. If you feel strongly, I can implement the API calls directly as a follow-up task, but this will introduce more maintenance overhead.
Quickly looked for other alternatives, but these libraries are poor or not maintained at all.

The license is ok, but the library doesn't have too many downloads and the repo has only 6 stars. It also isn't mentioned by Postmark as official https://postmarkapp.com/developer/integration/official-libraries or community https://postmarkapp.com/developer/integration/community-libraries library. Are there any alternatives? Have we considered sending HTTP requests directly?

The dependency looks ok - has an appropriate license, is maintained, and doesn't have serious issues open. It also seems convenient to use, so it's probably not worth it to search for possible alternatives.

The dependency looks ok

Looks great!

Sorry for requesting changes once again, but the logic in invite-links-context-provider seems to be a little brittle and I'd like to verify the changes before landing.

Reviewed mostly the migration

An additional thing worth testing is a case where Comm is closed when the code is scanned.

Makes sense to me but might be a good idea for @bartek to also review this

In D8795#262651, @marcin wrote:

Make this diff contain synchronization implementation only.