Page MenuHomePhabricator
Feed Advanced Search

Jan 9 2024

tomek accepted D10583: [lib][native][web] Move some types and basic functions out of action-utils.js.
Jan 9 2024, 8:57 AM
tomek accepted D10579: [lib] Separate out keyserver utils in action-utils.js into a separate file.
Jan 9 2024, 8:40 AM
tomek requested review of D10584: [lib][native][web] Expose identity API by using a context.
Jan 9 2024, 8:21 AM
tomek added inline comments to D10352: [web] dispatch deleteIdentityAction.
Jan 9 2024, 3:33 AM
tomek accepted D10352: [web] dispatch deleteIdentityAction.
Jan 9 2024, 2:59 AM

Jan 8 2024

tomek added inline comments to D10202: [lib] scaffolding for delete identity account.
Jan 8 2024, 7:15 AM
tomek updated the diff for D10449: [native] Expose get keyserver keys Identity RPC.

Fix error handling and capturing

Jan 8 2024, 5:33 AM
tomek updated the diff for D10403: [web] Expose get keyserver keys Identity RPC.

Rebase

Jan 8 2024, 5:23 AM
tomek requested changes to D10352: [web] dispatch deleteIdentityAction.
Jan 8 2024, 3:44 AM
tomek accepted D10202: [lib] scaffolding for delete identity account.
Jan 8 2024, 3:29 AM

Jan 7 2024

tomek added inline comments to D10484: [lib][web][native] Create defaultKeyserverInfo.
Jan 7 2024, 11:46 PM

Dec 22 2023

tomek updated the test plan for D10403: [web] Expose get keyserver keys Identity RPC.
Dec 22 2023, 8:01 AM
tomek updated the diff for D10403: [web] Expose get keyserver keys Identity RPC.

Modify function signature

Dec 22 2023, 8:01 AM
tomek requested review of D10449: [native] Expose get keyserver keys Identity RPC.
Dec 22 2023, 7:34 AM
tomek planned changes to D10403: [web] Expose get keyserver keys Identity RPC.
Dec 22 2023, 6:20 AM
tomek added a comment to D10440: [lib] rename register -> keyserver register.

Wondering about the consequences of this rename. It feels like it could break the compatibility of our reports - an older report could contain one of registerActionTypes actions that can't be recognized by the more recent code.

Dec 22 2023, 5:26 AM
tomek accepted D10439: [web] avoid initializing already initialized WASM module.
Dec 22 2023, 3:03 AM
tomek added a comment to D10434: [lib] Move `socketPreferredEndpoints` to `httpPreferredEndpoints`.

Wondering about the impact on the keyserver - if all the clients use HTTP, it might result in a lot of open HTTP connections. Also, from the client's point of view, it might result in a lot of open connections (probably more than a browser allows). So I think we should move only some requests to HTTP, but I might be wrong.

Dec 22 2023, 1:56 AM

Dec 21 2023

tomek added a comment to D10403: [web] Expose get keyserver keys Identity RPC.

Debugged it a bit and figured out what's going on. It seems like the Identity service doesn't recognize ashoatKeyserverID to be an ID of Ashoat's user. Instead, in identity-users table there's an entry for the user whose value is some UUID (different for staging and prod). After using the ID from the table, this code works correctly.

Dec 21 2023, 3:03 AM
tomek added a comment to D10403: [web] Expose get keyserver keys Identity RPC.

what's not working?

Dec 21 2023, 2:31 AM
tomek requested changes to D10202: [lib] scaffolding for delete identity account.
Dec 21 2023, 1:14 AM
tomek added inline comments to D10357: [web] introduce calculateNavigationSidebarTooltipSize.
Dec 21 2023, 12:58 AM
tomek planned changes to D10338: [web][native] Download invite link blob and use it as an override.
Dec 21 2023, 12:45 AM

Dec 20 2023

tomek accepted D10332: [lib][web][native] Stop logging out from the Socket.
Dec 20 2023, 4:27 AM
tomek accepted D10287: [lib] Add connectionIssue field.
Dec 20 2023, 4:11 AM

Dec 19 2023

tomek requested review of D10403: [web] Expose get keyserver keys Identity RPC.
Dec 19 2023, 7:32 AM
tomek accepted D10331: [lib] Call logout when connectionIssue is set.
Dec 19 2023, 6:35 AM
tomek accepted D10396: [WASM] improve error logging.
Dec 19 2023, 6:23 AM
tomek accepted D10395: [web] don't log out user when processing draft store ops fails.

I would guess that failing to process the reports also shouldn't cause clearing the db - if we fail the operation, we won't save a report, and by clearing the db we're making things a little worse.

Dec 19 2023, 6:21 AM

Dec 15 2023

tomek added inline comments to D10202: [lib] scaffolding for delete identity account.
Dec 15 2023, 8:49 AM
tomek accepted D10305: [web] improve error handling when setting/getting userID.
Dec 15 2023, 6:25 AM
tomek planned changes to D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.

This diff still has an issue: when calling a new keyserver, it returns sessionChange which causes setNewSession to be dispatched - this results in the keyserver being added to a store in an incorrect way and breaks more things down the line.

Dec 15 2023, 4:35 AM
tomek resigned from D10341: [emscripten] Switch Emscripten CI job to autoscaling runners.
Dec 15 2023, 4:27 AM
tomek accepted D10202: [lib] scaffolding for delete identity account.
Dec 15 2023, 4:25 AM
tomek accepted D10353: [terraform] Bump Blob service to 1.1.0 on prod.
Dec 15 2023, 4:06 AM
tomek requested changes to D10352: [web] dispatch deleteIdentityAction.
Dec 15 2023, 4:05 AM
tomek added a comment to D10157: [lib] Fix Logout not working and state difference after invalid session downgrade.
In D10157#299660, @inka wrote:

I wanted to move reducing loading statuses to web and native reducers altogether, but I couldn't overcome a flow problem:
I don't want to copy the reduceLoadingStatuses reducer to web and native, so it is located in lib. It takes an action: BaseAction. I was unable to type it in a way that wouldn't cause errors. If I make the action be an inexact BaseAction, like flow docs suggest: action: {...BaseAction, ...}, then I get errors about read-only properties, as the action I'm passing into the function has nested read-only fields, and the action that is being taken by the reducer was stripped of all read-only.
This works, because setNewSessionActionType, logOutActionTypes and deleteAccountActionTypes are in BaseAction
I know this is not ideal, but it fixes the issue, and is way less hacky than the previous solution.

Dec 15 2023, 2:24 AM
tomek accepted D10157: [lib] Fix Logout not working and state difference after invalid session downgrade.

Looks a lot cleaner!

Dec 15 2023, 2:23 AM

Dec 14 2023

tomek requested review of D10338: [web][native] Download invite link blob and use it as an override.
Dec 14 2023, 7:45 AM

Dec 13 2023

tomek accepted D10326: Don't add nullish id field to badgeonly notification payload.
Dec 13 2023, 9:46 AM
tomek updated the diff for D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.

Probably fix the override. This still requires a lot of testing and thinking about
memoization, but it isn't broken in an obvious way.

Dec 13 2023, 6:33 AM
tomek accepted D10306: [web] avoid race condition while deleting database.
Dec 13 2023, 5:01 AM
tomek requested changes to D10305: [web] improve error handling when setting/getting userID.
Dec 13 2023, 4:59 AM
tomek accepted D10300: [web] avoid calling worker with empty store ops.
Dec 13 2023, 4:52 AM
tomek accepted D10309: [web/native/lib] Combine openSocketSelector from web and native.
Dec 13 2023, 4:51 AM
tomek accepted D10310: [native] Fix failing base64 decode for thumbhash.
Dec 13 2023, 4:47 AM
tomek accepted D10244: [web] add gRPC client wrapper.
Dec 13 2023, 4:44 AM

Dec 12 2023

tomek planned changes to D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.
Dec 12 2023, 6:15 AM
tomek updated the diff for D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.

Use optional

Dec 12 2023, 5:30 AM
tomek requested review of D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.
Dec 12 2023, 5:04 AM
tomek requested review of D10308: [keyserver] Modify link verification so that it works with users that aren't logged in to a keyserver.
Dec 12 2023, 3:25 AM
tomek requested review of D10307: [lib] Do not provide overrides when we already know a keyserver.
Dec 12 2023, 3:00 AM
tomek updated the diff for D10290: [lib] Modify link verification to call the proper keyserver.

Use the correct key in overrides. Tested it by specifying keyserver override in web link
handler.

const validateLink = useVerifyInviteLink({
  keyserverID: ashoatKeyserverID,
  keyserverURL: 'http://localhost:3000/keyserver',
});

This calls the proper endpoint, but causes some other issues - e.g. invite link
verification assumes that a user is logged in, which isn't always true when using an invite
link. Going to fix this in the next diffs.

Dec 12 2023, 1:23 AM
tomek accepted D10262: Don't overwrite original notification with error message notification.
Dec 12 2023, 12:55 AM
tomek accepted D10253: [web] Update AddUsersList to call useUserSearchIndex.
Dec 12 2023, 12:31 AM
tomek accepted D10292: [lib][web][native] Simplify logout call.
Dec 12 2023, 12:22 AM

Dec 11 2023

tomek requested review of D10290: [lib] Modify link verification to call the proper keyserver.
Dec 11 2023, 9:37 AM

Dec 8 2023

tomek closed D10248: [lib] Introduce keyserver connection handler.
Dec 8 2023, 7:24 AM
tomek committed rCOMM37a9dfc0bb1d: [lib] Introduce keyserver connection handler (authored by tomek).
[lib] Introduce keyserver connection handler
Dec 8 2023, 7:24 AM
tomek requested review of D10248: [lib] Introduce keyserver connection handler.
Dec 8 2023, 5:33 AM
tomek accepted D10222: [web] add missing `userID` param.
Dec 8 2023, 4:43 AM
tomek requested changes to D10244: [web] add gRPC client wrapper.
Dec 8 2023, 4:35 AM

Dec 7 2023

tomek accepted D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`.
Dec 7 2023, 6:53 AM
tomek accepted D10204: [web] remove `CommQueryExecutor` code.
Dec 7 2023, 2:52 AM
tomek accepted D10203: [web] rename `WorkerConnectionProxy` file to match convention.
Dec 7 2023, 2:45 AM
tomek added inline comments to D10202: [lib] scaffolding for delete identity account.
Dec 7 2023, 2:42 AM

Dec 6 2023

tomek requested review of D10206: [keyserver] Set a job that synchronizes links with blobs.
Dec 6 2023, 7:17 AM
tomek requested review of D10205: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.
Dec 6 2023, 6:31 AM
tomek planned changes to D10134: [keyserver] Create a blob while adding / editing an invite link.

I'm going to check the option of using MariaDB transactions to minimize the number of possible race conditions

Dec 6 2023, 1:44 AM

Dec 5 2023

tomek accepted D10191: [web] make database errors more descriptive.
Dec 5 2023, 5:54 AM
tomek requested changes to D10157: [lib] Fix Logout not working and state difference after invalid session downgrade.

This solution is hacky - we're discarding loading statuses of requests that will be resolved later. Instead, we should reduce loading statuses before we check invalidSessionDowngrade.

Dec 5 2023, 5:41 AM
tomek accepted D10189: [keyserver] Fix error when changing thread description.
Dec 5 2023, 5:20 AM
tomek accepted D10174: [native] Remove async IIFE in CommunityDrawerContent effect.

I don't think there was a good reason behind this await

Dec 5 2023, 5:13 AM
tomek accepted D10163: [web] Return dispatchCreateSubchannel directly in Stepper.Item nextProps.
Dec 5 2023, 5:07 AM

Dec 4 2023

tomek accepted D10152: [web] catch error while processing store operations.
Dec 4 2023, 8:04 AM
tomek retitled D10150: [keyserver] Introduce a function that allows fetching all the primary links from [keyserver] Fetch all the links when a viewer is a script viewer to [keyserver] Introduce a function that allows fetching all the primary links.
Dec 4 2023, 6:47 AM
tomek updated the summary of D10150: [keyserver] Introduce a function that allows fetching all the primary links.
Dec 4 2023, 6:47 AM
tomek updated the diff for D10150: [keyserver] Introduce a function that allows fetching all the primary links.

Split a function into two

Dec 4 2023, 6:46 AM
tomek planned changes to D10150: [keyserver] Introduce a function that allows fetching all the primary links.

This feels pretty messy. I'm not sure what the callstack looks like, but is it possible to introduce a second function for this (with shared code factored out) instead of overloading fetchPrimaryInviteLinks to handle two different scenarios?

Dec 4 2023, 6:33 AM
tomek requested review of D10150: [keyserver] Introduce a function that allows fetching all the primary links.
Dec 4 2023, 4:56 AM
tomek accepted D10119: [web] Update existing checks on isDefault in role-actions-menu.reactjs.
Dec 4 2023, 12:28 AM
tomek accepted D10118: [native] Update existing checks on isDefault in role-panel-entry.react.js.
Dec 4 2023, 12:28 AM
tomek accepted D10117: [keyserver] Update existing checks on isDefault in invite-link-creator.js.
Dec 4 2023, 12:27 AM
tomek accepted D10116: [lib] Update existing checks on isDefault in thread-utils.js.
Dec 4 2023, 12:27 AM
tomek accepted D10109: [lib] Update thread-utils to include specialRole field.
Dec 4 2023, 12:23 AM

Dec 1 2023

tomek accepted D10108: [keyserver] Update role-creator to include specialRole field.
Dec 1 2023, 7:55 AM
tomek accepted D10107: [keyserver] Update `fetchServerThreadInfos(filter?: FetchThreadInfosFilter)` to fetch special_role.
Dec 1 2023, 7:54 AM
tomek accepted D10106: [keyserver] Update `fetchRoles(threadID: string)` to fetch special_role.
Dec 1 2023, 7:54 AM
tomek accepted D10105: [lib] Add optional specialRole field to RoleInfo.
Dec 1 2023, 7:52 AM
tomek accepted D10135: [blob] Add option to instantly delete a blob.
Dec 1 2023, 7:35 AM
tomek requested review of D10134: [keyserver] Create a blob while adding / editing an invite link.
Dec 1 2023, 7:22 AM
tomek requested review of D10131: [keyserver] Change blob upload functions to return more usable results.
Dec 1 2023, 4:37 AM

Nov 30 2023

tomek accepted D10097: [web] wrap store operations in transaction.
Nov 30 2023, 8:09 AM
tomek requested review of D10099: [keyserver] Introduce a util function that generates invite link blob hash.
Nov 30 2023, 8:02 AM
tomek requested review of D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.
Nov 30 2023, 7:28 AM
tomek updated the diff for D9972: [keyserver] Delete a holder after deleting a blob.

Rebase

Nov 30 2023, 6:57 AM
tomek updated the diff for D9968: [keyserver] Fetch invite link blob holder.

Rebase

Nov 30 2023, 6:54 AM
tomek updated the diff for D9966: [keyserver] Add a function that deletes a blob.

Use a param object instead of two args for hash and holder to avoid the confusion between them

Nov 30 2023, 6:52 AM
tomek accepted D10095: [lib] `ThreadInfo` -> `LegacyThreadInfo`.

Accepting without review. What procedure did you use to rename all the types?

Nov 30 2023, 1:23 AM

Nov 29 2023

tomek accepted D10054: [native] Implement native backup.
Nov 29 2023, 6:07 AM