- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 19 2024
Jan 19 2024
tomek committed rCOMM715cc109dc0a: [lib][native][web] Parse keyserver keys payload and validate the result (authored by tomek).
[lib][native][web] Parse keyserver keys payload and validate the result
tomek committed rCOMMaf7c614948c2: [lib] Improve error handling in connection handler (authored by tomek).
[lib] Improve error handling in connection handler
tomek committed rCOMMd5ef4a27085a: [native][web] Make identity client mandatory (authored by tomek).
[native][web] Make identity client mandatory
tomek committed rCOMMbf1ff1e5e8ff: [native][web] Add a context provider on native that exposes notifications… (authored by tomek).
[native][web] Add a context provider on native that exposes notifications…
tomek committed rCOMM4290fd868410: [web] Introduce deviceID parameter to initial notif message function (authored by tomek).
[web] Introduce deviceID parameter to initial notif message function
tomek committed rCOMM50b762fbe2de: [lib][native] Introduce deviceID parameter to initial notif message function (authored by tomek).
[lib][native] Introduce deviceID parameter to initial notif message function
Simplify the code
tomek updated the diff for D10666: [lib][native][web] Parse keyserver keys payload and validate the result.
Improve validation
Rebase
Rebase
tomek updated the diff for D10663: [native][web] Add a context provider on native that exposes notifications session creator.
Rename
tomek updated the diff for D10662: [web] Introduce deviceID parameter to initial notif message function.
Rename
tomek updated the diff for D10660: [lib][native] Introduce deviceID parameter to initial notif message function.
Rebase
tomek updated the diff for D10660: [lib][native] Introduce deviceID parameter to initial notif message function.
Rename
In D10667#309741, @marcin wrote:I am confused by this differential. I have two questions:
- What is the purpose of deleting and recreating notifications sessions at least every time app starts (session creation is not idempotent - it overwrites previous session)? Session is created on login and via socket if the keyserver happens to be missing session.
- In its current state this differential doesn't guarantee that session on the client is in sync with session on the keyserver - initialEncryptedMessage returned from session creator is not used. If this differential is intentionally breaking the app and you plan to fix it later in the stack then it should be explicitly stated in summary or in a comment.
tomek added inline comments to D10666: [lib][native][web] Parse keyserver keys payload and validate the result.
tomek added a comment to D10662: [web] Introduce deviceID parameter to initial notif message function.
In D10662#309232, @kamil wrote:Using deviceID everywhere makes me sometimes confused which ID it is, so in places like this I would prefer recipientDeviceID or targetDeviceID but curious about what other reviewers think.
I did the same here D10381 so going to update next time touching this code.
tomek added inline comments to D10660: [lib][native] Introduce deviceID parameter to initial notif message function.
Jan 18 2024
Jan 18 2024
tomek added inline comments to D10663: [native][web] Add a context provider on native that exposes notifications session creator.
tomek updated the diff for D10663: [native][web] Add a context provider on native that exposes notifications session creator.
Reverse providers order
Simplify
Jan 17 2024
Jan 17 2024
tomek retitled D10663: [native][web] Add a context provider on native that exposes notifications session creator from [native][web] Add a context provider on web that exposes notifications session creator to [native][web] Add a context provider on native that exposes notifications session creator.
tomek published D10666: [lib][native][web] Parse keyserver keys payload and validate the result for review.
tomek published D10662: [web] Introduce deviceID parameter to initial notif message function for review.
tomek published D10660: [lib][native] Introduce deviceID parameter to initial notif message function for review.
tomek added inline comments to D10631: [native] implement prekey rotation handler and call Identity.
Jan 15 2024
Jan 15 2024
Jan 12 2024
Jan 12 2024
tomek added inline comments to D10616: [lib][native][web] add new changeIdentityUserPassword action.
Jan 11 2024
Jan 11 2024
[lib] Get keyserver keys in a handler
Avoid console logging the keys
tomek committed rCOMMa1bc42b9e40d: [lib][native][web] Expose identity API by using a context (authored by tomek).
[lib][native][web] Expose identity API by using a context
tomek committed rCOMM90c438564d6d: [native] Expose get keyserver keys Identity RPC (authored by tomek).
[native] Expose get keyserver keys Identity RPC
tomek committed rCOMMdad3f22e6e75: [web] Expose get keyserver keys Identity RPC (authored by tomek).
[web] Expose get keyserver keys Identity RPC
Rebase
Readonly
Rever import ordering change
Address review
It's unfortunate how different native and web are, but I think it makes sense given the technical decisions we've made
When we receive the version we compare it, if it's different this tab is old, we refresh it - download the newest web app version, and connect to the new worker.
Are there any risks here? Can the refresh fail, or be stopped by a user?
Jan 10 2024
Jan 10 2024
Rebase
Format
Rebase
Rebase
tomek added a reviewer for D10584: [lib][native][web] Expose identity API by using a context: marcin.
Improve error handling
Use event emitter
Jan 9 2024
Jan 9 2024
Fix Flow
tomek added 1 blocking reviewer(s) for D10584: [lib][native][web] Expose identity API by using a context: varun.