Update comment

I'm glad it worked, thanks!

In D12525#357103, @ashoat wrote:

Can you remind me how we make sure that only Comm services can call DeleteDeviceData?

This was triggered recently and might've been a websocket health check or something related.

Rust looks ok, letting @marcin review as well, I have no context on some of these

Nice job with the Arc<RwLock>!

Can we either?:

• Fully rely on clap parsing the env variable
• Remove the env support in clap

The crate looks reasonable

Nice!

In D12563#355966, @will wrote:

In D12563#355851, @bartek wrote:

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

This a really cool feature I didn't know existed. tbh, originally planned on just resubscribing but I'll use terraform state mv instead.

Accepting but please address feedback before landing

Remove trait for reports service

Rust LGTM, nice idea with these traits!

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

What about undelivered_messages? Are they considered a "device data" too?

Why did we introduce it initially? 🤨

Looks good. Left some nits

Simple change to imports and adding undelivered_messages:: made it look much better

You're doing OPAQUE login for old password and OPAQUE registration for new password in the same RPC. Smart!