Can you link to where you got these types from? Eg. docs or TypeScript types?

Accepting to save you rebasing

Thank you for figuring out this bug!

Probably not worth doing now, but I think it would be more clear to the reveiwer if you had put D7774 before D7773. Then you could squash this into D7773

No, that's not it. The issue is that the children prop you're passing to <div className={css.innerContainer}> will get recreated anyways every time as <>{header}{activePage}{footer}{modals}</>. You're not successfully memoizing any prop passed to any component, so there is no benefit here. You would have to memoize the entirety of <>{header}{activePage}{footer}{modals}</> for it to have any effect.

on the app -> in the app

Makes sense to me, but would like @varun to take a look RE how this might affect an externally runnning staging environment

This has literally no effect

Are we doing this so performance is better than it would be in a pure-JS implementation? Given you've already done it I guess we should keep it (assuming you avoided copy-paste), but in the future when we need performant low-level implementations of crypto functionality, I would if it would be easier to bridge to a Rust library than to implement "from scratch" in C++

Note that Map<K, T> defines the Map class in JS, and doesn't work for objects. If you absolutely must use an object, you should still be able to type it better, eg. { +[key: string]: mixed } or something

Flow doesn't like generic Map<K, T> while iterating over properties, so I used Object.

• Agree it would be good to see Android too, given that ReactNav can look different on iOS on Android
• Hard to review this without knowing the test plan (later diffs are not here yet, but I guess they will be coming soon)
• It looks like the border radius is too rounded, compared to the Figma designs

Use a for loop instead to improve performance. Tested again on web to make sure it still works

My high-level view is that it would be better to keep account-utils.js as a "leaf", and just extract the one function that is preventing account-utils.js from being a leaf, than to extract all of the other stuff into a new leaf

Is panelBackgroundLabel actually the right color to use here per the designs?

The de-duplication refactor will be performed in a separate diff.

The de-duplicate refactor will be done in a separate diff.

Thanks for making this fix. siweNonceResponder also doesn't have an input

Some nits that aren't super important

@atul should review this. I'm not familiar with comm-icon-config.json and its format

Accepting to unblock

This looks clean!

Thanks @rohan!

Let’s include the condition. Looking at Git history for MessageList, I seem to have added the condition in an unrelated Android diff in 2019 when it was still a personal project… so not much detail in the commit message, and it might reflect an outdated issue in React Native… but doesn’t hurt to check just in case, and for consistency

I’m confused how the optional chaining works here – if ?.slice(-1) is called on an undefined value and returns undefined, won’t you still be indexing on undefined (undefined[0])? Also note that the concern I shared was about the array being empty, whereas you seem to explored the possibility of the array being null

Concerned that we're not checking for height and pageY being set

Thought a little bit more carefully about the ReactNav stuff and have just one more round of feedback (hopefully), all regarding the new useNavigateToPinModal hook. Sorry I didn't call this out earlier!

Looks perfect to me! Just need @tomek to accept now

Retrigger CI

In D7710#229097, @michal wrote:

I've talked with @ashoat about report ids, and in the future, we probably will send them to some centralized server, so we don't need to convert ids or payloads.

Great work on this, @marcin – your approach is different from what I proposed, but I agree it is a better approach. Thanks for thinking about this!