Page MenuHomePhabricator
Feed Advanced Search

May 25 2023

ashoat closed D7992: [native] Implement PasswordSelection logic.
May 25 2023, 2:10 PM
ashoat closed D7990: [native] Minor updates to UsernameSelection.
May 25 2023, 2:10 PM
ashoat committed rCOMMb2cc8cdbd7ee: [native] Implement PasswordSelection logic (authored by ashoat).
[native] Implement PasswordSelection logic
May 25 2023, 2:10 PM
ashoat committed rCOMM1192076525b1: [native] Minor updates to UsernameSelection (authored by ashoat).
[native] Minor updates to UsernameSelection
May 25 2023, 2:10 PM
ashoat closed D7989: [native] Minor updates to KeyserverSelection TextInput.
May 25 2023, 2:10 PM
ashoat committed rCOMM92d6fa3e3161: [native] Minor updates to KeyserverSelection TextInput (authored by ashoat).
[native] Minor updates to KeyserverSelection TextInput
May 25 2023, 2:10 PM
ashoat updated the diff for D7992: [native] Implement PasswordSelection logic.

Newline and textContentType="newPassword"

May 25 2023, 2:03 PM
ashoat requested review of D7992: [native] Implement PasswordSelection logic.
May 25 2023, 12:48 PM
ashoat requested review of D7990: [native] Minor updates to UsernameSelection.
May 25 2023, 12:29 PM
ashoat requested review of D7989: [native] Minor updates to KeyserverSelection TextInput.
May 25 2023, 12:25 PM
ashoat closed D7969: [native] Introduce PasswordSelection screen.
May 25 2023, 11:59 AM
ashoat committed rCOMM9c414ebbc349: [native] Introduce PasswordSelection screen (authored by ashoat).
[native] Introduce PasswordSelection screen
May 25 2023, 11:59 AM
ashoat added a comment to D7870: [landing] fix mobile nav still being shown when window resizes.

Oops – this is what I should've said (had a typo in my last comment):

May 25 2023, 10:53 AM
ashoat accepted D7968: [native] Make `enumCheckBox` functional in `CommunityConfiguration`.

Thanks!!

May 25 2023, 8:58 AM
ashoat requested changes to D7753: [lib] introduce function to find deep difference between two objects.

Map type is defined as follows in the codebase: type Map<K, T> = { +[key: K]: T };

May 25 2023, 4:11 AM
ashoat added inline comments to D7971: [web] Disabled edit button if edited message is empty.
May 25 2023, 3:59 AM
ashoat accepted D7960: [web][fixed] Added FocusTrap for modals.
May 25 2023, 3:58 AM

May 24 2023

ashoat requested review of D7969: [native] Introduce PasswordSelection screen.
May 24 2023, 5:36 PM
ashoat requested changes to D7968: [native] Make `enumCheckBox` functional in `CommunityConfiguration`.

Requesting changes for design iteration. Really wish this was captured in the designs we got from @ted before the hand-off

May 24 2023, 4:18 PM
ashoat accepted D7967: [native] Add `enumCell` layout/styling to `CommunityConfiguration`.
May 24 2023, 4:08 PM
ashoat accepted D7966: [native] Add "Clear media cache" button to dev menu.
May 24 2023, 11:47 AM
ashoat accepted D7965: [web] Add missing thumbhash to newly created media message.
May 24 2023, 11:18 AM
ashoat accepted D7964: [native] Remove HelloWorld expo module.
May 24 2023, 11:17 AM
ashoat accepted D7963: [native] Move Thumbhash to umbrella expo module.
May 24 2023, 11:17 AM
ashoat accepted D7962: [native] Move AndroidLifecycle to umbrella expo module.
May 24 2023, 11:17 AM
ashoat accepted D7961: [native] Move AES-Crypto to umbrella expo module.
May 24 2023, 11:15 AM
ashoat requested changes to D7960: [web][fixed] Added FocusTrap for modals.

Requesting changes for comment above

May 24 2023, 11:15 AM
ashoat added inline comments to D7943: [landing] introduce logo svg assets for competitor comparison.
May 24 2023, 11:00 AM
ashoat added inline comments to D7797: Implement olm session updater that has encrypting functionality.
May 24 2023, 10:38 AM
ashoat accepted D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
May 24 2023, 10:37 AM
ashoat accepted D7956: [native] Scaffold an umbrella expo-module.
May 24 2023, 10:11 AM
ashoat accepted D7900: [web] Add thumbhash to encrypted media, fix spinner.
May 24 2023, 10:10 AM
ashoat accepted D7874: Encrypt Android notifications on the keyserver before sending them.
May 24 2023, 9:38 AM
ashoat accepted D7815: Send encrypted notifications to iOS devices.
May 24 2023, 9:37 AM
ashoat accepted D7872: Implement function to encrypt android notification.

Makes sense, thanks for explaining @marcin!

May 24 2023, 9:29 AM
ashoat accepted D7952: [native] Add community name `TextInput` to `CommunityConfiguration`.

Makes sense

May 24 2023, 9:27 AM
ashoat requested changes to D7900: [web] Add thumbhash to encrypted media, fix spinner.
May 24 2023, 9:26 AM
ashoat accepted D7947: [web] Support thumbhash in modals.
May 24 2023, 9:24 AM
ashoat accepted D7902: [web] Display thumbhash in chat.
May 24 2023, 9:18 AM
ashoat accepted D7946: [web] Add loadable video component.
May 24 2023, 9:00 AM
ashoat accepted D7950: [native] Introduce `CommunityCreationNavigator`.
May 24 2023, 7:21 AM

May 23 2023

ashoat added inline comments to D7939: [native] stop persisting reports.
May 23 2023, 5:59 PM
ashoat accepted D7953: [native] Add `communityNameNotice` to `CommunityConfiguration`.
May 23 2023, 2:26 PM
ashoat requested changes to D7952: [native] Add community name `TextInput` to `CommunityConfiguration`.

The placeholder color you're using is super bright. Can you link to designs? Feels like it might be best to stick with what RegistrationTextInput does for consistency

May 23 2023, 2:26 PM
ashoat accepted D7951: [native] Add keyserver label to `CommunityConfiguration`.
May 23 2023, 2:18 PM
ashoat requested changes to D7950: [native] Introduce `CommunityCreationNavigator`.

High-level approach is great, but some comments below

May 23 2023, 2:16 PM
ashoat requested changes to D7902: [web] Display thumbhash in chat.

Passing back to your queue, but feel free to-request review again if there's something that I'm missing. Also please let me know if this would be a difficult change to make... my impression is that changes in D7946 should hopefully be easy, but I'm not sure about the whole scope of changes that would be required.

May 23 2023, 2:06 PM
ashoat accepted D7947: [web] Support thumbhash in modals.
May 23 2023, 1:15 PM
ashoat requested changes to D7946: [web] Add loadable video component.
May 23 2023, 1:08 PM
ashoat requested changes to D7900: [web] Add thumbhash to encrypted media, fix spinner.
May 23 2023, 1:03 PM
ashoat requested changes to D7902: [web] Display thumbhash in chat.

I think either there's a disconnect about when to display the thumbhash vs. the thumbnail, or perhaps I am misunderstanding the feasibility of my suggestion. Please let me know if I'm missing something!

May 23 2023, 1:00 PM
ashoat accepted D7942: [native] Fix reply not working in search results.

Thanks for explaining everything!

May 23 2023, 11:58 AM
ashoat added a comment to D7870: [landing] fix mobile nav still being shown when window resizes.

The last comment was pretty concerning...

May 23 2023, 11:48 AM
ashoat added inline comments to D7930: [web] Changed edit modal overlay opacity.
May 23 2023, 11:36 AM
ashoat accepted D7899: [web] Refactor Mutlimedia to function component.
May 23 2023, 11:34 AM
ashoat accepted D7814: Implement method in NSE to decrypt notification.
May 23 2023, 11:33 AM
ashoat accepted D7813: Implement function to encrypt relevant parts of iOS notification.
May 23 2023, 11:31 AM
ashoat added inline comments to D7837: [web] Added FocusTrap for modals.
May 23 2023, 11:29 AM
ashoat added a comment to D7730: [native] Create a modal where invite links are displayed.

As @ted is off for now, I don't think it makes sense to block this diff on this change.

May 23 2023, 11:26 AM
ashoat accepted D7944: [keyserver] Use mixed as an input type in inviteLinkVerificationResponder.
May 23 2023, 11:24 AM
ashoat closed D7929: [native] Rename FullscreenSIWEPanel onClose prop to goBackToPrompt.
May 23 2023, 8:30 AM
ashoat closed D7928: [native] Extract onClose-disabling behavior from SIWEPanel to FullscreenSIWEPanel.
May 23 2023, 8:30 AM
ashoat committed rCOMM4c772b92e080: [native] Rename FullscreenSIWEPanel onClose prop to goBackToPrompt (authored by ashoat).
[native] Rename FullscreenSIWEPanel onClose prop to goBackToPrompt
May 23 2023, 8:29 AM
ashoat committed rCOMMf0791928faa6: [native] Extract onClose-disabling behavior from SIWEPanel to… (authored by ashoat).
[native] Extract onClose-disabling behavior from SIWEPanel to…
May 23 2023, 8:29 AM
ashoat closed D7927: [native] Use loading button variant in ConnectEthereum during username search.
May 23 2023, 8:29 AM
ashoat closed D7926: [native] Use Arial for all body text in registration flow.
May 23 2023, 8:29 AM
ashoat committed rCOMM8931825daf4d: [native] Use Arial for all body text in registration flow (authored by ashoat).
[native] Use Arial for all body text in registration flow
May 23 2023, 8:29 AM
ashoat committed rCOMMf3e5e91a3801: [native] Use loading button variant in ConnectEthereum during username search (authored by ashoat).
[native] Use loading button variant in ConnectEthereum during username search
May 23 2023, 8:29 AM
ashoat closed D7925: [native] Implement UsernameSelection logic.
May 23 2023, 8:29 AM
ashoat committed rCOMMdf6166aa2bb5: [native] Implement UsernameSelection logic (authored by ashoat).
[native] Implement UsernameSelection logic
May 23 2023, 8:29 AM
ashoat added a comment to D7925: [native] Implement UsernameSelection logic.
In D7925#235234, @atul wrote:

Should we style the input w/ a red outline when there's invalid input + some sort of error state? (cc @ted)

I would expect something more like the right:

53ecb9.png (1×1 px, 117 KB)

Either way, implementation matches the designs

May 23 2023, 8:28 AM
ashoat updated the diff for D7925: [native] Implement UsernameSelection logic.

Avoid putting JSX into React state

May 23 2023, 8:27 AM
ashoat added inline comments to D7877: [lib] Create a store in redux for the invite links.
May 23 2023, 7:28 AM
ashoat requested changes to D7874: Encrypt Android notifications on the keyserver before sending them.
May 23 2023, 7:26 AM
ashoat added inline comments to D7797: Implement olm session updater that has encrypting functionality.
May 23 2023, 7:06 AM
ashoat requested changes to D7872: Implement function to encrypt android notification.
May 23 2023, 7:06 AM
ashoat added inline comments to D7833: [web] Storing edited message component position.
May 23 2023, 7:01 AM
ashoat accepted D7771: [lib] Add useSearchMessages.
May 23 2023, 6:57 AM
ashoat accepted D7774: [native] Add MessageSearchContent.
May 23 2023, 6:56 AM
ashoat added a comment to D7930: [web] Changed edit modal overlay opacity.

Looks like @ted suggested using two different opacities for modals here. My first instinct would be to just have a single opacity, but he's on vacation so we can just proceed with this approach for now

May 23 2023, 6:36 AM
ashoat added a comment to D7935: Remove ListLoadingIndicator background color.

Thanks for solving this the "right" way with a red diff that simplifies things!

May 23 2023, 6:32 AM
ashoat added a comment to D7837: [web] Added FocusTrap for modals.

In a previous comment, I said:

May 23 2023, 6:31 AM
ashoat added inline comments to D7908: [native] Introduce disable link button.
May 23 2023, 5:42 AM
ashoat added inline comments to D7772: [natvie] Add SearchFooter component.
May 23 2023, 5:41 AM
ashoat added inline comments to D7827: [web] Display edit state (in the background).
May 23 2023, 5:41 AM
ashoat added inline comments to D6973: [web] Extract from drawer item code that can be reused in community items.
May 23 2023, 5:38 AM

May 22 2023

ashoat added a reviewer for D7926: [native] Use Arial for all body text in registration flow: ted.
May 22 2023, 6:12 PM
ashoat requested review of D7929: [native] Rename FullscreenSIWEPanel onClose prop to goBackToPrompt.
May 22 2023, 4:46 PM
ashoat requested review of D7928: [native] Extract onClose-disabling behavior from SIWEPanel to FullscreenSIWEPanel.
May 22 2023, 4:41 PM
ashoat requested review of D7927: [native] Use loading button variant in ConnectEthereum during username search.
May 22 2023, 1:21 PM
ashoat requested review of D7926: [native] Use Arial for all body text in registration flow.
May 22 2023, 1:00 PM
ashoat requested review of D7925: [native] Implement UsernameSelection logic.
May 22 2023, 12:43 PM
ashoat accepted D7924: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`.

Make sure Flow etc pass before landing please

May 22 2023, 11:26 AM
ashoat added inline comments to D6976: [web] Use new handlers in communnity drawer.
May 22 2023, 11:25 AM
ashoat added inline comments to D7906: [keyserver] Create an endpoint that allows disabling links.
May 22 2023, 11:10 AM
ashoat added inline comments to D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
May 22 2023, 11:03 AM
ashoat added a comment to D7904: [landing] introduce signal competitor data.

I'm guessing this is the copy from DES-79, in which case I wrote it. RE line lengths, I guess it's fine

May 22 2023, 10:57 AM
ashoat added a comment to D7908: [native] Introduce disable link button.

Looks like

disable-button-bright.png (2×1 px, 168 KB)
failed to attach

May 22 2023, 10:55 AM
ashoat closed D7896: [native] Introduce UsernameSelection screen.
May 22 2023, 10:51 AM
ashoat committed rCOMM3cae1466e7bb: [native] Introduce UsernameSelection screen (authored by ashoat).
[native] Introduce UsernameSelection screen
May 22 2023, 10:51 AM