- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 25 2023
Newline and textContentType="newPassword"
Oops – this is what I should've said (had a typo in my last comment):
Thanks!!
Map type is defined as follows in the codebase: type Map<K, T> = { +[key: K]: T };
May 24 2023
Requesting changes for design iteration. Really wish this was captured in the designs we got from @ted before the hand-off
Requesting changes for comment above
Makes sense, thanks for explaining @marcin!
Makes sense
May 23 2023
The placeholder color you're using is super bright. Can you link to designs? Feels like it might be best to stick with what RegistrationTextInput does for consistency
High-level approach is great, but some comments below
Passing back to your queue, but feel free to-request review again if there's something that I'm missing. Also please let me know if this would be a difficult change to make... my impression is that changes in D7946 should hopefully be easy, but I'm not sure about the whole scope of changes that would be required.
I think either there's a disconnect about when to display the thumbhash vs. the thumbnail, or perhaps I am misunderstanding the feasibility of my suggestion. Please let me know if I'm missing something!
Thanks for explaining everything!
The last comment was pretty concerning...
As @ted is off for now, I don't think it makes sense to block this diff on this change.
In D7925#235234, @atul wrote:Should we style the input w/ a red outline when there's invalid input + some sort of error state? (cc @ted)
I would expect something more like the right:
Either way, implementation matches the designs
Avoid putting JSX into React state
Thanks for solving this the "right" way with a red diff that simplifies things!
In a previous comment, I said:
May 22 2023
Make sure Flow etc pass before landing please
I'm guessing this is the copy from DES-79, in which case I wrote it. RE line lengths, I guess it's fine