Page MenuHomePhorge
Feed Search

Search
Use Results
Hide Query

May 2 2024

will requested review of D11859: [lib] Rename action type to set aux user fids.
May 2 2024, 3:28 PM
will requested review of D11854: [terraform] identity service cloudwatch alarms.
May 2 2024, 3:25 AM
will requested review of D11853: [terraform] metric filters for error logs in identity service.
May 2 2024, 3:22 AM
will requested review of D11852: [identity] Add prefixes to error logs for filtering.
May 2 2024, 3:20 AM

May 1 2024

will closed D11851: [identity] remove duplicate debug log for HTTP requests.
May 1 2024, 4:12 PM
will committed rCOMM3e1a4ed50f83: [identity] remove duplicate debug log for HTTP requests.
May 1 2024, 4:12 PM
will closed D11850: [identity] Disable external crate debug messages.
May 1 2024, 3:54 PM
will committed rCOMM16d89108d6f3: [identity] Disable external crate debug messages.
May 1 2024, 3:54 PM
will updated the diff for D11851: [identity] remove duplicate debug log for HTTP requests.

review feedback

May 1 2024, 3:51 PM
will added inline comments to D11851: [identity] remove duplicate debug log for HTTP requests.
May 1 2024, 3:47 PM

Apr 30 2024

will requested review of D11851: [identity] remove duplicate debug log for HTTP requests.
Apr 30 2024, 8:39 PM
will requested review of D11850: [identity] Disable external crate debug messages.
Apr 30 2024, 8:34 PM

Apr 29 2024

will requested review of D11831: [identity] add span tracing to identity farcaster.rs.
Apr 29 2024, 6:37 AM
will requested review of D11830: [identity] add span tracing to token.rs.
Apr 29 2024, 6:32 AM
will requested review of D11829: [identity] Add span tracing to one_time_keys.rs.
Apr 29 2024, 6:28 AM
will requested review of D11828: [identity] add span tracing to identity device_list.rs functions.
Apr 29 2024, 6:24 AM
will updated the summary of D11825: [identity] Add span tracing to grpc handlers.
Apr 29 2024, 6:21 AM
will requested review of D11827: [identity] add span tracing to identity database.rs file.
Apr 29 2024, 6:20 AM
will requested review of D11826: [identity] add span tracing to identity websocket server.
Apr 29 2024, 6:15 AM
will requested review of D11825: [identity] Add span tracing to grpc handlers.
Apr 29 2024, 6:13 AM
will requested review of D11824: [terraform] add comm_services_use_json_logs env variable for json tracing.
Apr 29 2024, 6:13 AM

Apr 27 2024

will accepted D11799: [lib] Search for users in thread list search.

Looks good to me

Apr 27 2024, 2:51 AM

Apr 26 2024

will closed D11744: [identity] add env var conditional json tracing.
Apr 26 2024, 4:28 AM
will committed rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing.
Apr 26 2024, 4:28 AM
will updated the diff for D11744: [identity] add env var conditional json tracing.

rebase

Apr 26 2024, 4:25 AM
will updated the diff for D11744: [identity] add env var conditional json tracing.

rebase

Apr 26 2024, 4:18 AM
will closed D11743: [terraform] Warning message typo.
Apr 26 2024, 4:16 AM
will committed rCOMM36426c2b3761: [terraform] Warning message typo.
Apr 26 2024, 4:16 AM
will closed D11745: [identity] Convert unwraps in sync identity search to expects.
Apr 26 2024, 4:15 AM
will committed rCOMMcf544ccfab3a: [identity] Convert unwraps in sync identity search to expects.
Apr 26 2024, 4:15 AM

Apr 25 2024

will accepted D11783: [terraform] enable debug logs by default on staging.
Apr 25 2024, 6:32 PM

Apr 23 2024

will requested review of D11745: [identity] Convert unwraps in sync identity search to expects.
Apr 23 2024, 7:16 PM
will requested review of D11744: [identity] add env var conditional json tracing.
Apr 23 2024, 7:01 PM
will requested review of D11743: [terraform] Warning message typo.
Apr 23 2024, 6:55 PM
will accepted D11740: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`.
Apr 23 2024, 6:08 PM

Apr 19 2024

will accepted D11704: bump identity version and introduce script for identity releases.
Apr 19 2024, 8:10 PM
will closed D11618: [native][web] Read thread activity entries from SQLite on app start.
Apr 19 2024, 8:09 PM
will committed rCOMMa11214af00e9: [native][web] Read thread activity entries from SQLite on app start.
Apr 19 2024, 8:09 PM
will closed D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.
Apr 19 2024, 8:09 PM
will closed D11617: [native][web] Start processing thread activity store with sqlite operations.
Apr 19 2024, 8:09 PM
will committed rCOMMd82518d49a1b: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use….
Apr 19 2024, 8:08 PM
will closed D11616: [native] migrate threadActivityStore to SQLite.
Apr 19 2024, 8:08 PM
will committed rCOMM107293bdf1bf: [native][web] Start processing thread activity store with sqlite operations.
Apr 19 2024, 8:08 PM
will committed rCOMM408f153e9e31: [native] migrate threadActivityStore to SQLite.
Apr 19 2024, 8:08 PM
will closed D11615: [sqlite] Implement processing thread activity on web worker.
Apr 19 2024, 8:08 PM
will committed rCOMMc175e1714d27: [sqlite] Implement processing thread activity on web worker.
Apr 19 2024, 8:08 PM
will closed D11614: [sqlite] Implement C++ code for native to get sqlite thread activity entries.
Apr 19 2024, 8:08 PM
will closed D11584: [sqlite/native] Make C++ thread activity sqlite ops available to native.
Apr 19 2024, 8:08 PM
will committed rCOMM9567929ea151: [sqlite] Implement C++ code for native to get sqlite thread activity entries.
Apr 19 2024, 8:08 PM
will committed rCOMMf2f89a5bf164: [sqlite/native] Make C++ thread activity sqlite ops available to native.
Apr 19 2024, 8:08 PM
will closed D11581: [sqlite] Implement C++ methods for thread activity.
Apr 19 2024, 8:08 PM
will committed rCOMM7aa6f6dc604f: [sqlite] Implement C++ methods for thread activity.
Apr 19 2024, 8:08 PM
will closed D11579: [lib] return ops from thread activity reducer.
Apr 19 2024, 8:06 PM
will committed rCOMM44fd4370b83c: [lib] return ops from thread activity reducer.
Apr 19 2024, 8:06 PM
will updated the diff for D11579: [lib] return ops from thread activity reducer.

fix tests

Apr 19 2024, 7:42 PM
will closed D11578: [lib] refactor thread activity reducer to use sqlite operations.
Apr 19 2024, 7:32 PM
will committed rCOMM68fc96783930: [lib] refactor thread activity reducer to use sqlite operations.
Apr 19 2024, 7:32 PM
will closed D11576: [native/sqlite] Create thread activity table in sqlite.
Apr 19 2024, 7:32 PM
will committed rCOMMedad6555237f: [native/sqlite] Create thread activity table in sqlite.
Apr 19 2024, 7:32 PM
will closed D11575: [lib] Add thread activity store ops.
Apr 19 2024, 7:25 PM
will committed rCOMM6f981993537e: [lib] Add thread activity store ops.
Apr 19 2024, 7:25 PM
will closed D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.
Apr 19 2024, 7:05 PM
will committed rCOMMc37e98658ab9: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity….
Apr 19 2024, 7:05 PM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

rebase before landing

Apr 19 2024, 6:42 PM
will updated the diff for D11616: [native] migrate threadActivityStore to SQLite.

rebase before landing

Apr 19 2024, 6:42 PM
will updated the test plan for D11618: [native][web] Read thread activity entries from SQLite on app start.
Apr 19 2024, 6:39 PM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

style. rebase before landing

Apr 19 2024, 6:35 PM
will planned changes to D11618: [native][web] Read thread activity entries from SQLite on app start.
Apr 19 2024, 6:29 PM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

Do not assert equality of threadActivity on web

Apr 19 2024, 6:28 PM
will closed D11672: create new aux user store action for clearing fids.
Apr 19 2024, 4:13 AM
will committed rCOMM2b05aaf6d911: create new aux user store action for clearing fids.
Apr 19 2024, 4:13 AM
will closed D11671: Makes fid optionally null so that we can delete the fid later.
Apr 19 2024, 4:13 AM
will committed rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later.
Apr 19 2024, 4:13 AM
will updated the diff for D11672: create new aux user store action for clearing fids.

rename clear to not include friends

Apr 19 2024, 3:32 AM

Apr 17 2024

will added a comment to D11672: create new aux user store action for clearing fids.

Removing the language of friends. This action type will encompass wiping all aux user store data irregardless of whether or not the user is friends with them or not.

Apr 17 2024, 5:31 PM
will abandoned D11639: [lib] Add farcaster friend fids to sqlite.
Apr 17 2024, 5:23 PM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.

Updated linear project with new tasks: https://linear.app/comm/project/farcaster-sqlite-followups-a2415120f443.

Apr 17 2024, 5:22 PM
will added a comment to D11672: create new aux user store action for clearing fids.
In D11672#335437, @ashoat wrote:

but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.

Apr 17 2024, 4:13 PM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.

Separately, thinking about this a bit more... is the purpose of putting FIDs in the aux user store so that we can show Farcaster accounts on user profiles in Comm? If >> so, shouldn't we fetch FIDs for all users in the UserStore, and not just for Farcaster friends?

Apr 17 2024, 3:40 PM
will closed D11673: [native] check for null fid before adding to sqlite database.
Apr 17 2024, 3:07 PM
will committed rCOMMc017019752b0: [native] check for null fid before adding to sqlite database.
Apr 17 2024, 3:07 PM
will published D11673: [native] check for null fid before adding to sqlite database for review.
Apr 17 2024, 3:03 PM
will added a comment to D11672: create new aux user store action for clearing fids.
In D11672#335437, @ashoat wrote:

but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.

Apr 17 2024, 1:56 PM
will added reviewers for D11672: create new aux user store action for clearing fids: ashoat, atul, ginsu.
Apr 17 2024, 1:55 PM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

rebase

Apr 17 2024, 5:19 AM
will updated the diff for D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.

review feedback

Apr 17 2024, 5:18 AM
will closed D11630: [lib/native] Delete FIDProvider.
Apr 17 2024, 4:24 AM
will committed rCOMM609c93977002: [lib/native] Delete FIDProvider.
Apr 17 2024, 4:24 AM
will closed D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Apr 17 2024, 4:24 AM
will closed D11628: [lib] Make synced metadata name field an enum.
Apr 17 2024, 4:24 AM
will committed rCOMM8ce3feec147e: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Apr 17 2024, 4:24 AM
will committed rCOMM051c63bec1d7: [lib] Make synced metadata name field an enum.
Apr 17 2024, 4:24 AM
will closed D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.
Apr 17 2024, 4:24 AM
will committed rCOMM340733ee63e9: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.
Apr 17 2024, 4:24 AM
will updated the diff for D11616: [native] migrate threadActivityStore to SQLite.

rebase

Apr 17 2024, 4:04 AM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

rebase

Apr 17 2024, 3:59 AM
will updated the diff for D11614: [sqlite] Implement C++ code for native to get sqlite thread activity entries.

thread_activity_store_entry => threadActivityStoreEntry

Apr 17 2024, 3:58 AM

Apr 16 2024

will requested review of D11672: create new aux user store action for clearing fids.
Apr 16 2024, 10:36 PM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.

Given that we're already checking farcaster friends in a useEffect, should we consider adding a syncing action type that not only adds new farcaster friends but also removes farcaster friends that we've unfollowed as well?

Apr 16 2024, 10:31 PM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.
Apr 16 2024, 10:29 PM
First
Prev
Next