Update toggleMessagePinRequestInputValidator
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 20 2023
Update ToggleMessagePinRequest
Simplify the migration
Introduce two columns in messages
Address Feedback
I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.
rebase
update types
Sequencing this diff towards the end of the diff stack (need to put up a few more diffs up first) but will update the relational revisions when I have a better idea
rebase and land
address feedback (and sneak in ENSAvatarDBContent)
rebase after changing up diff stack order
rebase after switching up diff stack order
rebase after switching up diff stack order
rebase after switching up diff stack order
rebase
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Remove unnecessary lines
Address review. Tested the new db creation (in prod mode, because I'm having weird problems with my setup. For more info see https://linear.app/comm/issue/ENG-3325/clean-database-migration-fail),
made sure the primary key is created.
In D6993#209859, @tomek wrote:Do we know how this diff corresponds to https://linear.app/comm/issue/ENG-3322/fix-stale-cache-error-for-olmwasm#comment-d1aabe3d? Maybe this will somehow improve the experience about the path's configuration?
Address review and add early return when there is nothing to insert
This code was supposed to handle an edge case where:
- Electron downloads an update, and we display the modal
- Before the user presses the modal to quit-and-install, we release a new version.
Without this, the user will have to update the app twice instead of once (in this rare case).