Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Fri, Dec 13

ashoat committed rCOMM730c48dec5a5: [lib] Fix stack overflow from lastUpdatedTime (authored by ashoat).
[lib] Fix stack overflow from lastUpdatedTime
Fri, Dec 13, 4:36 PM
varun accepted D14157: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars.
Fri, Dec 13, 4:05 PM
varun accepted D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.
Fri, Dec 13, 4:05 PM
ashoat published D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList for review.

I'll confirm relevant CI passes before landing

Fri, Dec 13, 2:58 PM
ashoat published D14157: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars for review.

I'll confirm relevant CI passes before landing

Fri, Dec 13, 2:57 PM
ashoat added inline comments to D13996: [native] community joiner modal.
Fri, Dec 13, 1:21 PM
ashoat accepted D14155: [native] Delete console log.
Fri, Dec 13, 11:56 AM
tomek requested review of D14155: [native] Delete console log.
Fri, Dec 13, 10:18 AM
will accepted D14156: [lib] Fix stack overflow from lastUpdatedTime.
Fri, Dec 13, 10:17 AM
ashoat published D14156: [lib] Fix stack overflow from lastUpdatedTime for review.

Will wait for relevant CI before landing

Fri, Dec 13, 9:09 AM
varun added inline comments to D13994: [native] community list item component.
Fri, Dec 13, 8:56 AM
ashoat added a comment to D13994: [native] community list item component.

Also: in the screenshot you shared, the vertical padding seems uneven between top / bottom

Fri, Dec 13, 8:30 AM
ashoat requested changes to D13994: [native] community list item component.

Can you share updated videos of how this looks in both dark mode and light mode?

Fri, Dec 13, 8:29 AM
varun added a comment to D13994: [native] community list item component.

Latest look at the modal with the redesigned CommunityListItem component

Fri, Dec 13, 8:29 AM
varun updated the diff for D13994: [native] community list item component.

Move joinStatus closer to where it's used

Fri, Dec 13, 8:27 AM
varun updated the diff for D13994: [native] community list item component.

address feedback

Fri, Dec 13, 8:22 AM
tomek added inline comments to D13907: [native] Introduce a restore screen.
Fri, Dec 13, 6:47 AM
angelika updated the diff for D14130: [native] Migrate ActionResultModal component to Reanimated v2 API.

Fix nit

Fri, Dec 13, 6:37 AM
angelika updated the diff for D14113: [native] Enable Flow types in Reanimated worklets.

Remove comment

Fri, Dec 13, 6:37 AM
tomek accepted D14153: [native] handle waiting for secondary device response.

It might be a good idea to have an effect that clears the timeout on unmount.

Fri, Dec 13, 6:32 AM
angelika added inline comments to D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.
Fri, Dec 13, 6:28 AM
tomek accepted D14151: [native] add callback to remove secondary device during QR auth.
Fri, Dec 13, 6:26 AM
angelika added inline comments to D14128: [native] Migrate useOverlayPosition, useContentAndHeaderOpacity, useDeliveryIconOpacity hooks to Reanimated V2 API.
Fri, Dec 13, 6:24 AM
ashoat added inline comments to D14111: [native] Move methods from Tooltip to functional compononent.
Fri, Dec 13, 6:17 AM
angelika added inline comments to D14111: [native] Move methods from Tooltip to functional compononent.
Fri, Dec 13, 6:16 AM
tomek accepted D14115: [native] implement screen when connecting secondary device.
Fri, Dec 13, 6:15 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14154: [lib] Use ChatThreadItemLoaderCache for loading sidebar.
Fri, Dec 13, 6:14 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM4b33216d7218: [lib] Use ChatThreadItemLoaderCache for loading sidebar (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[lib] Use ChatThreadItemLoaderCache for loading sidebar
Fri, Dec 13, 6:14 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14144: [native] Stop resetting ChatThreadList on navigation.
Fri, Dec 13, 6:14 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14143: [native] Add loading indicator at the bottom of ChatThreadList.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM58176056c7d3: [native] Stop resetting ChatThreadList on navigation (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[native] Stop resetting ChatThreadList on navigation
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14142: [native] Factor out listLoadingIndicatorHeight.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM09d091b0edd0: [native] Add loading indicator at the bottom of ChatThreadList (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[native] Add loading indicator at the bottom of ChatThreadList
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM058864d257ed: [native] Factor out listLoadingIndicatorHeight (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[native] Factor out listLoadingIndicatorHeight
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14140: [lib] Introduce ChatThreadItemLoaderCache.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14141: [lib][native] Update native to use ChatThreadItemLoaderCache.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14139: [lib] Rename useCreateChatThreadItem to useGetChatThreadItemLoader.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM3dba5dbadd19: [lib][native] Update native to use ChatThreadItemLoaderCache (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[lib][native] Update native to use ChatThreadItemLoaderCache
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM55b685af24c9: [lib] Introduce ChatThreadItemLoaderCache (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[lib] Introduce ChatThreadItemLoaderCache
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM59e9b16deb5f: [lib] Rename useCreateChatThreadItem to useGetChatThreadItemLoader (authored by ashoat).
[lib] Rename useCreateChatThreadItem to useGetChatThreadItemLoader
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14138: [lib] Extract initialChatThreadItem.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14137: [lib] Avoid unnecessary useSelector on MessageStore in useGetLastUpdatedTimes.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM77ed3c708135: [lib] Extract initialChatThreadItem (authored by ashoat).
[lib] Extract initialChatThreadItem
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D14136: [lib] Don't construct promises in useCreateChatThreadItem.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM9095f4869bfa: [lib] Avoid unnecessary useSelector on MessageStore in useGetLastUpdatedTimes (authored by ashoat).
[lib] Avoid unnecessary useSelector on MessageStore in useGetLastUpdatedTimes
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D13984: [lib] Fix incorrect timestamps for sidebars.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM24a324d1ebe2: [lib] Don't construct promises in useCreateChatThreadItem (authored by ashoat).
[lib] Don't construct promises in useCreateChatThreadItem
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM617ed804e81d: [lib] Fix incorrect timestamps for sidebars (authored by ashoat).
[lib] Fix incorrect timestamps for sidebars
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM0943dead4c72: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different (authored by ashoat).
[lib][web] Await lastUpdatedTime and update ChatThreadItems if different
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM85d0b02b1949: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime (authored by ashoat).
[lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D13914: [lib] Extract getSidebarItems.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM381a55bb9bb9: [lib] Extract getSidebarItems (authored by ashoat).
[lib] Extract getSidebarItems
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM511682b3a71d: [lib] Introduce MessageSpec.getLastUpdatedTime (authored by ashoat).
[lib] Introduce MessageSpec.getLastUpdatedTime
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> closed D13912: [lib] Extract getLastUpdatedTime to a separate file.
Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM2f9b274e6865: [lib] Extract getLastUpdatedTime to a separate file (authored by ashoat).
[lib] Extract getLastUpdatedTime to a separate file
Fri, Dec 13, 6:13 AM
angelika added inline comments to D14108: [native] Move Reanimated nodes in Tooltip to functional component.
Fri, Dec 13, 6:13 AM
tomek accepted D14154: [lib] Use ChatThreadItemLoaderCache for loading sidebar.
Fri, Dec 13, 6:04 AM
tomek accepted D14144: [native] Stop resetting ChatThreadList on navigation.
Fri, Dec 13, 5:57 AM
tomek accepted D14143: [native] Add loading indicator at the bottom of ChatThreadList.
Fri, Dec 13, 5:56 AM
tomek accepted D14142: [native] Factor out listLoadingIndicatorHeight.
Fri, Dec 13, 5:54 AM
tomek accepted D14141: [lib][native] Update native to use ChatThreadItemLoaderCache.
Fri, Dec 13, 5:46 AM
angelika updated the diff for D14135: [native] Move render function in MultimediaMessageMultimedia to functional component.

Rebase and address feedback

Fri, Dec 13, 5:43 AM
angelika updated the diff for D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.

Rebase and address feedback

Fri, Dec 13, 5:42 AM
angelika updated the diff for D14133: [native] Migrate opacity in MultimediaMessageMultimedia to Reanimated v2 API in functional component.

Rebase and address feedback

Fri, Dec 13, 5:42 AM
angelika updated the diff for D14132: [native] Move onPress and onLayout methods in MultimediaMessageMultimedia to functional component.

Rebase and address feedback

Fri, Dec 13, 5:42 AM
tomek accepted D14140: [lib] Introduce ChatThreadItemLoaderCache.
Fri, Dec 13, 5:42 AM
angelika updated the diff for D14131: [native] Move view ref in MultimediaMessageMultimedia to functional component.

Rebase and address feedback

Fri, Dec 13, 5:41 AM
angelika updated the diff for D14130: [native] Migrate ActionResultModal component to Reanimated v2 API.

Rebase and address feedback

Fri, Dec 13, 5:41 AM
angelika updated the diff for D14129: [native] Workarounds for bugs after reanimated migration.

Rebase and address feedback

Fri, Dec 13, 5:40 AM
angelika updated the diff for D14128: [native] Migrate useOverlayPosition, useContentAndHeaderOpacity, useDeliveryIconOpacity hooks to Reanimated V2 API.

Rebase and address feedback

Fri, Dec 13, 5:39 AM
angelika updated the diff for D14127: [native] Remove progress prop from tooltip buttons components.

Rebase and address feedback

Fri, Dec 13, 5:39 AM
angelika updated the diff for D14126: [native] Migrate RobotextMessageTooltipButton component to Reanimated V2 API.

Rebase and address feedback

Fri, Dec 13, 5:38 AM
angelika updated the diff for D14125: [native] Migrate MultimediaMessageTooltipButton component to Reanimated V2 API.

Rebase and address feedback

Fri, Dec 13, 5:38 AM
angelika updated the diff for D14124: [native] Migrate ReactionSelectionPopover component to Reanimated V2 API.

Rebase and address feedback

Fri, Dec 13, 5:37 AM
angelika updated the diff for D14123: [native] Migrate TooltipInlineEngagement to Reanimated V2 API.

Rebase and address feedback

Fri, Dec 13, 5:37 AM
ashoat added inline comments to D14113: [native] Enable Flow types in Reanimated worklets.
Fri, Dec 13, 5:37 AM
angelika updated the diff for D14122: [native] Migrate TextMessageTooltipButton to Reanimated V2 API.

Rebase and address feedback

Fri, Dec 13, 5:37 AM
angelika updated the diff for D14121: [native] Remove progress parameter from useAnimatedMessageTooltipButton.

Rebase and address feedback

Fri, Dec 13, 5:36 AM
angelika updated the diff for D14120: [native] Migrate threadColorOverride in useAnimatedMessageTooltipButton to Reanimate V2 API.

Rebase and address feedback

Fri, Dec 13, 5:36 AM
angelika updated the diff for D14119: [native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to Reanimate V2 API.

Rebase and address feedback

Fri, Dec 13, 5:35 AM
angelika updated the diff for D14118: [native] Add progressV2 field to tooltip button types.

Rebase and address feedback

Fri, Dec 13, 5:35 AM
angelika updated the diff for D14117: [native] Migrate Tooltip component to Reanimated v2 API.

Rebase and address feedback

Fri, Dec 13, 5:35 AM
angelika updated the diff for D14113: [native] Enable Flow types in Reanimated worklets.

Rebase and address feedback

Fri, Dec 13, 5:34 AM
angelika updated the diff for D14112: [native] Move render function from Tooltip to functional component.

Rebase and address feedback

Fri, Dec 13, 5:33 AM
angelika updated the diff for D14111: [native] Move methods from Tooltip to functional compononent.

Rebase and address feedback

Fri, Dec 13, 5:33 AM
angelika updated the diff for D14110: [native] Move haptics in Tooltip to functional compononent.

Rebase and address feedback

Fri, Dec 13, 5:32 AM
tomek accepted D14139: [lib] Rename useCreateChatThreadItem to useGetChatThreadItemLoader.
Fri, Dec 13, 5:32 AM
angelika updated the diff for D14109: [native] Move styles in Tooltip to functional component.

Rebase and address feedback

Fri, Dec 13, 5:32 AM
angelika updated the diff for D14108: [native] Move Reanimated nodes in Tooltip to functional component.

Rebase and address feedback

Fri, Dec 13, 5:31 AM
angelika updated the diff for D14107: [native] Move tooltip location getter in Tooltip to functional component.

Rebase and address feedback

Fri, Dec 13, 5:30 AM
angelika updated the diff for D14106: [native] Move tooltip height getter in Tooltip to functional component.

Rebase and address feedback

Fri, Dec 13, 5:30 AM
angelika updated the diff for D14104: [native] Move margin getter in Tooltip to functional component.

Rebase and address feedback

Fri, Dec 13, 5:29 AM
angelika updated the diff for D14103: [native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API.

Rebase and address feedback

Fri, Dec 13, 5:28 AM
angelika updated the diff for D14102: [native] Introduce positionsV2 values in OverlayNavigator.

Rebase and address feedback

Fri, Dec 13, 5:27 AM
angelika updated the diff for D14099: [native] Add reanimated makeMutable function type.

Rebase and address feedback

Fri, Dec 13, 5:27 AM
angelika updated the diff for D14098: [native] Fix reanimated cancelAnimation flow type.

Rebase and address feedback

Fri, Dec 13, 5:24 AM
tomek accepted D14138: [lib] Extract initialChatThreadItem.
Fri, Dec 13, 2:52 AM
First
Prev
Next